0004974: Employee Expenses: Expense Date field and Business Partner field value

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0004974

Openbravo ERP

08. Project and service management

public

2008-09-09 17:26

2009-03-03 17:16

Reporter

rafaroda

Assigned To

Dowid

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

2.40

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0004974: Employee Expenses: Expense Date field and Business Partner field value

Description

Employee Expenses lines tab should look like Invoiceable Expenses lines one.

Comparing the two screenshots attached, one can see that in Employee Expenses lines tab:
1) 'Expense Date' field is not shown.
2) 'Business Partner' field is filled with employee name instead of the business partner of the expense line (if any).

There is an issue with 'S_TIMEEXPENSELINE_V' view.

Steps To Reproduce

1. Go to Project & Service Management || Transactions || Expense Sheet
2. Add a new one and save
3. Go to 'Lines' tab.
4. Select Reinvoincing option, a product and a business partner.
5. Go back to 'Header' tab and click on 'Process' button.
5. Go to Project & Service Management || Transactions || Employee Expenses
6. Select the previous employee and go to 'Lines' tab.

Notice that:
1) 'Expense Date' field is not shown.
2) 'Business Partner' field is filled with employee name instead of business partner one.

Proposed Solution

S_TIMEEXPENSELINE_V view, that is the base for Employee Expense line tab, looks like:

SELECT tel.s_timeexpenseline_id, tel.ad_client_id, tel.ad_org_id, tel.isactive, tel.created, tel.createdby, tel.updated, tel.updatedby, tel.s_timeexpense_id, tel.line, tel.istimereport, te.datereport, tel.m_product_id, tel.qty, tel.expenseamt, tel.c_currency_id, tel.convertedamt, tel.s_resourceassignment_id, tel.description, tel.note, tel.isinvoiced, tel.c_project_id, tel.c_activity_id, tel.c_campaign_id, tel.c_invoiceline_id, tel.invoiceprice, tel.c_uom_id, tel.c_orderline_id, tel.c_projectphase_id, tel.c_projecttask_id, tel.s_timetype_id, te.c_bpartner_id
   FROM s_timeexpenseline tel
   JOIN s_timeexpense te ON tel.s_timeexpense_id = te.s_timeexpense_id
  WHERE tel.qty <> 0 AND tel.c_invoiceline_id IS NULL AND te.processed = 'Y' AND tel.isactive = 'Y' AND te.isactive = 'Y' AND tel.istimereport <> 'Y'

1) In order to show Expense Date field, 'tel.dateexpense' should be added before FROM clause.

2) In order to show correct value of expense line business partner, 'tel.c_bpartner_id' should be added before FROM clause. But this seem to conflict with current 'te.c_bpartner_id'.

Additional Information