Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049693Openbravo ERP07. Sales managementpublic2022-06-30 07:022022-07-11 10:23
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049693: API Order Loader: Return ticket logics to implement
DescriptionSMCP cannot use the originalOrderLineId field for return ticket

In case of a Return Ticket (so with the flag isReturn = true OR if amount negative)

At orderLine level there will be the returned item with the new field originalSalesOrderDocumentNumber

When the system processes the External Order Loader, the system will top the line with the same item of the original document number as “returned” (in the same logic as what is done with originalOrderLineId) in order to not allow to return twice the same item of the original document
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-06-30 07:02AtulOpenbravoNew Issue
2022-06-30 07:02AtulOpenbravoAssigned To => Triage Omni OMS
2022-06-30 07:02AtulOpenbravoOBNetwork customer => No
2022-06-30 07:02AtulOpenbravoModules => Core
2022-06-30 07:02AtulOpenbravoTriggers an Emergency Pack => No
2022-06-30 07:02AtulOpenbravoAssigned ToTriage Omni OMS => AtulOpenbravo
2022-07-01 20:38hgbotMerge Request Status => open
2022-07-01 20:38hgbotNote Added: 0138963
2022-07-01 20:43AtulOpenbravoStatusnew => scheduled
2022-07-03 20:51hgbotNote Added: 0138991
2022-07-07 07:51ivancaceresIssue Monitored: ivancaceres
2022-07-11 09:47hgbotMerge Request Statusopen => approved
2022-07-11 10:21hgbotResolutionopen => fixed
2022-07-11 10:21hgbotStatusscheduled => closed
2022-07-11 10:21hgbotFixed in Version => RR22Q4
2022-07-11 10:21hgbotNote Added: 0139223
2022-07-11 10:21hgbotNote Added: 0139224
2022-07-11 10:21hgbotNote Added: 0139225
2022-07-11 10:21hgbotNote Added: 0139226
2022-07-11 10:21hgbotNote Added: 0139227
2022-07-11 10:21hgbotNote Added: 0139228
2022-07-11 10:21hgbotNote Added: 0139229
2022-07-11 10:21hgbotNote Added: 0139230
2022-07-11 10:21hgbotNote Added: 0139231
2022-07-11 10:21hgbotNote Added: 0139232
2022-07-11 10:23hgbotNote Added: 0139233
2022-07-11 10:23hgbotNote Added: 0139234
2022-07-11 10:23hgbotNote Added: 0139235
2022-07-11 10:23hgbotNote Added: 0139236
2022-07-11 10:23hgbotNote Added: 0139237

Notes
(0138963)
hgbot   
2022-07-01 20:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/844 [^]
(0138991)
hgbot   
2022-07-03 20:51   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/208 [^]
(0139229)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d2c9003b712e5bd10e0dedeaaa17271380b334a5
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d2c9003b712e5bd10e0dedeaaa17271380b334a5 [^]

Related to ISSUE-0049693: Code review improvements

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139228)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a0fb0492c842795d998fc50d057c5a1b9ce84fbc
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a0fb0492c842795d998fc50d057c5a1b9ce84fbc [^]

Related to ISSUE-0049693: Add preference to consider original order
line in multiple return order lines.

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139227)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3d0f2581e658e5548a0b7871f8847c658b2c7c87
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3d0f2581e658e5548a0b7871f8847c658b2c7c87 [^]

Related to ISSUE-0049693:Improve computation of originalOrderLineId
in case Return Order has multiple lines with same product and
they need to be linked to same originalOrderLineId

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139226)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 045f9d2f62243a425c28e97b19859a3b8dc7ba77
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/045f9d2f62243a425c28e97b19859a3b8dc7ba77 [^]

Related To ISSUE-0049693: Compute returned quantity related
to originalOrderLine in the same return order with multiple
lines having same product, apply formatting

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139225)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: de2323391c334b72e366c14f03d0a7c95aab3d24
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/de2323391c334b72e366c14f03d0a7c95aab3d24 [^]

Related to ISSUE-0049693: Add check whether the isReturn flag
is true or line quantity is negative inorder to compute the
originalOrderLineId based on originlSalesOrderDocumentNo and
product UPCEAN properties.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139224)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 80433685a16c8c82f9fc9101ac8b5aebb9be3cc0
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/80433685a16c8c82f9fc9101ac8b5aebb9be3cc0 [^]

Related to ISSUE-0049693: Apply formatting

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139223)
hgbot   
2022-07-11 10:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2cce62b2ce52ecb0c215b165d2eb88f22b93a463
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2cce62b2ce52ecb0c215b165d2eb88f22b93a463 [^]

Fixes ISSUE-0049693: API Order Loader: Return ticket logics
to implement

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139230)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1ccbaa11f77ff7c0f3082eed6067b4b2780b0cb5
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1ccbaa11f77ff7c0f3082eed6067b4b2780b0cb5 [^]

Related to ISSUE-0049693: Code Review Improvements

**Remove preference to consider Original Order Line in multiple
return line and its usage.

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139231)
hgbot   
2022-07-11 10:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7490110d31ee6424b251aaa355c9e63473a0e31c
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7490110d31ee6424b251aaa355c9e63473a0e31c [^]

Related to ISSUE-0049693: Code review improvements

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139232)
hgbot   
2022-07-11 10:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/844 [^]
(0139233)
hgbot   
2022-07-11 10:23   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 72bd7dfcb2c0496329aa3910a805859cb0f1017b
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:56
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/72bd7dfcb2c0496329aa3910a805859cb0f1017b [^]

Related to ISSUE-0049693: Add junit test to verfiy the goods
shipment line in return order lines

---
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/VerifyReturnOrderLineDetailsIssue49693.java
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-for-return-order-minimal-1.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-for-return-order-multiline-1.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-return-order-minimal-1.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-return-order-multiline-1.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-return-order-multiline-2.json
M src-test/org/openbravo/test/mobile/retail/pack/webservice/baseIntegration/BaseRetailOrderLoaderTest.java
---
(0139234)
hgbot   
2022-07-11 10:23   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 0472787b12d97dde351cc2c52e37a72303b4c1d7
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:56
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/0472787b12d97dde351cc2c52e37a72303b4c1d7 [^]

Related to ISSUE-0049693:Add test data on improved computation
of originalOrderLineId in case Return Order has multiple lines
with same product that needs to be linked to same
originalOrderLineId

---
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-for-return-order-minimal-2.json
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/VerifyReturnOrderLineDetailsIssue49693.java
---
(0139235)
hgbot   
2022-07-11 10:23   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: fb07e16d65590f6eb7f64401329726264eafae64
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:56
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/fb07e16d65590f6eb7f64401329726264eafae64 [^]

Related to ISSUE-0049693: Set proper data in the return json,
add data for orphan line.

---
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-return-order-multiline-1.json
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-return-order-multiline-2.json
---
(0139236)
hgbot   
2022-07-11 10:23   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 16663228931fdfc04a9c9d0f38bd99b8f90f0755
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 11-07-2022 08:06:56
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/16663228931fdfc04a9c9d0f38bd99b8f90f0755 [^]

Related to ISSUE-0049693: Add VerifyReturnOrderLineDetails test
in job003

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/suites/concurrent/job003/WebServiceSuite.java
---
(0139237)
hgbot   
2022-07-11 10:23   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/208 [^]