Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049682POS2Restaurantspublic2022-06-29 14:132022-08-05 13:31
ReporterFelixaka 
Assigned Tosntgreale 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049682: JIRA 2722 - The coupon is printed when we printed a "Review payment"
DescriptionWhen a payement is done with an article that contained a coupon, the coupon and the ticket is printed. This is ok.

But when you would like to review the payment (See picture), This print the tikcet but also the coupon again..

This is not what is expected, only the ticket shoudl be printer
Steps To ReproduceIn Fs Test

-Go on the POS

-Select a product associated with a coupon (Bavette aloyau)

-Paid for it and print the ticket

-Then go to the section "Order"

-Choose the last order

-Click on "review payment" then click on "done" (see picture)

-Print the ticket

-See that it's printed also the coupon
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 2022-06-29_14h11_26.png (138,352) 2022-06-29 14:13
https://issues.openbravo.com/file_download.php?file_id=17256&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-06-29 14:13FelixakaNew Issue
2022-06-29 14:13FelixakaAssigned To => Retail
2022-06-29 14:13FelixakaFile Added: 2022-06-29_14h11_26.png
2022-06-29 14:13FelixakaTriggers an Emergency Pack => No
2022-07-12 14:13guilleaerTypebackport => defect
2022-07-12 14:20guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24468#r24468
2022-07-12 15:12sntgrealeAssigned ToRetail => sntgreale
2022-07-12 15:12sntgrealeStatusnew => scheduled
2022-07-22 22:21hgbotNote Added: 0139555
2022-08-05 13:31hgbotResolutionopen => fixed
2022-08-05 13:31hgbotStatusscheduled => closed
2022-08-05 13:31hgbotFixed in Version => 22Q4
2022-08-05 13:31hgbotNote Added: 0139920
2022-08-05 13:31hgbotNote Added: 0139921

Notes
(0139555)
hgbot   
2022-07-22 22:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1103 [^]
(0139920)
hgbot   
2022-08-05 13:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8972aed5d4429d444da153b3e1660b8e717f44d2
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 05-08-2022 13:29:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8972aed5d4429d444da153b3e1660b8e717f44d2 [^]

Fixes ISSUE-49682: Validation does not print coupon if coming from Review Payments.

---
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/CouponDeliveryControlMethod.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/__test__/DoTicketCompletionPostHook.test.js
---
(0139921)
hgbot   
2022-08-05 13:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1103 [^]