Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049663POS2Restaurantspublic2022-06-27 15:292022-07-05 13:00
Reportertimothee_catteeuw 
Assigned Toablasco 
PrioritynormalSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049663: JIRA 3109 - Performance issues when updating keymap through keymap editor
DescriptionWhen a modification is done thanks to Keymap editor, those one are correctly shared with other tills but :

- update process is really long (several seconds as you can in video attached to the Jira)
If someone apply a modification in Keymap editor, it can impact a cashier is working on another till during around 10 sec.

- No loader is displayed, the user doesn’t know what is waiting for

- moreover it happen even if the cashier is working on a ticket and he is forced to wait for the end of the process in order to continue his ticket. It would be more proper to update the key map when the cashier start a new ticket (or when he finish and pay the one he is working on)
Steps To ReproduceGo to WebPos
Open keymap editor
Open the layout option for the default keymap you are used to (because it is the first it will be displayed when you go to "sell" screen)
Change something on it (change the number of product)
and click save
Quickly go to the "sell" screen
--> The user has to wait between 5 and 10 sec before working again
--> no loader message is displayed
Proposed Solution- analyze optimization when importing keymap data on till

- display a loader message

- analyze the possibility of an asynchronous update, for exemple → if possible not allow importing and updating keymap modifications when the cashier is working on a ticket and wait that the current ticket is paid before updating data.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 004972022Q3 closed ablasco JIRA 3109 - Performance issues when updating keymap through keymap editor 
causes defect 0049709 closed ablasco [Key Map Editor] Empty screen is displayed when trying to edit products before save a new 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-06-27 15:29timothee_catteeuwNew Issue
2022-06-27 15:29timothee_catteeuwAssigned To => Retail
2022-06-27 15:29timothee_catteeuwOBNetwork customer => No
2022-06-27 15:29timothee_catteeuwTriggers an Emergency Pack => No
2022-06-27 15:33timothee_catteeuwProposed Solution updated
2022-06-29 13:10AugustoMauchAssigned ToRetail => ablasco
2022-06-29 13:11AugustoMauchStatusnew => scheduled
2022-06-30 17:28hgbotMerge Request Status => open
2022-06-30 17:28hgbotNote Added: 0138892
2022-07-01 11:45hgbotNote Added: 0138911
2022-07-02 00:26hgbotMerge Request Statusopen => approved
2022-07-02 01:16hgbotNote Added: 0138967
2022-07-02 01:16hgbotNote Added: 0138968
2022-07-02 01:16hgbotResolutionopen => fixed
2022-07-02 01:16hgbotStatusscheduled => closed
2022-07-02 01:16hgbotNote Added: 0138969
2022-07-02 01:16hgbotNote Added: 0138970
2022-07-04 09:48andre_montenegroRelationship addedcauses 0049709
2022-07-04 14:50cbernerStatusclosed => new
2022-07-04 14:50cbernerResolutionfixed => open
2022-07-04 14:51cbernerStatusnew => scheduled
2022-07-04 14:52cbernerStatusscheduled => resolved
2022-07-04 14:52cbernerResolutionopen => fixed
2022-07-04 14:52cbernerReview Assigned To => AugustoMauch
2022-07-04 14:52cbernerStatusresolved => closed
2022-07-04 14:52cbernerFixed in Version => 22Q4
2022-07-05 08:36guilleaerStatusclosed => new
2022-07-05 08:36guilleaerResolutionfixed => open
2022-07-05 08:36guilleaerFixed in Version22Q4 =>
2022-07-05 08:36guilleaerStatusnew => scheduled
2022-07-05 08:36guilleaerNote Added: 0139047
2022-07-05 12:59guilleaerStatusscheduled => resolved
2022-07-05 12:59guilleaerResolutionopen => fixed
2022-07-05 13:00guilleaerNote Added: 0139081
2022-07-05 13:00guilleaerStatusresolved => closed

Notes
(0138892)
hgbot   
2022-06-30 17:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1060 [^]
(0138911)
hgbot   
2022-07-01 11:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/790 [^]
(0138967)
hgbot   
2022-07-02 01:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e93c19d6aae2639793a8e28a5d52b6733a89f6f6
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 02-07-2022 00:28:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e93c19d6aae2639793a8e28a5d52b6733a89f6f6 [^]

Related to ISSUE-49663: Previous configuration is available while new version if being computed

It is convenient to have the previous version of a configuration while the one is being computed, i.e. to reuse some configurations
and recreate only some others

---
M web-jspack/org.openbravo.core2/src/core/ConfigurationSet.js
M web-jspack/org.openbravo.core2/src/core/Registry.js
---
(0138968)
hgbot   
2022-07-02 01:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/790 [^]
(0138969)
hgbot   
2022-07-02 01:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 628c0e228ad967a910e5c94396a2f8a0bae360df
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 02-07-2022 00:28:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/628c0e228ad967a910e5c94396a2f8a0bae360df [^]

Fixes ISSUE-49663 - Improve performance after saving a change in the keymap editor

Before this change, when saving a change in the keymap editor for a given keymap, all keymaps were being recomputed.

Now only the keymap being edited will be recomputed, the configuration for the rest will be reused from the current version of the configuration.

This change relies on the core2 change that provides the previous version of a configuration when the new one is being computed.

---
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapOnExitPopup/KeymapOnExitPopup.js
M web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/loadKeymapConfigurations.js
---
(0138970)
hgbot   
2022-07-02 01:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1060 [^]
(0139047)
guilleaer   
2022-07-05 08:36   
Reopened to fix some details
(0139081)
guilleaer   
2022-07-05 13:00   
Reclosed because problem has been resolved with the fix of issue
https://issues.openbravo.com/view.php?id=49709 [^]