Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049640POS2POSpublic2022-06-23 16:012022-07-04 16:58
Reportermtaal 
Assigned Toruben_jimenez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049640: Allow pager codes of 1 or 2 digits and remove preceeding zeros
DescriptionTwo changes:
- allow pager codes which are only 1 or 2 digits
- if a pager starts with a zero(s), remove the zeros:
05 --> 5
078 --> 78
008 --> 8
12340889 -> 88
Steps To ReproduceSee pager code
Proposed SolutionChange the validation logic for pager codes in the customer pager handler
Additional Information
TagsNo tags attached.
Relationships
depends on backport 004972622Q3 closed ruben_jimenez Allow pager codes of 1 or 2 digits and remove preceeding zeros 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-06-23 16:01mtaalNew Issue
2022-06-23 16:01mtaalAssigned To => mtaal
2022-06-23 16:01mtaalOBNetwork customer => No
2022-06-23 16:01mtaalTriggers an Emergency Pack => No
2022-06-26 18:59guilleaerStatusnew => scheduled
2022-06-27 16:58mtaalAssigned Tomtaal => ruben_jimenez
2022-06-27 17:00mtaalDescription Updatedbug_revision_view_page.php?rev_id=24369#r24369
2022-06-27 17:09mtaalNote Added: 0138792
2022-06-29 11:44ruben_jimenezNote Added: 0138840
2022-06-29 13:04hgbotMerge Request Status => open
2022-06-29 13:04hgbotNote Added: 0138843
2022-07-01 00:09hgbotMerge Request Statusopen => approved
2022-07-01 12:53hgbotNote Added: 0138920
2022-07-01 12:53hgbotNote Added: 0138921
2022-07-04 16:58guilleaerStatusscheduled => acknowledged
2022-07-04 16:58guilleaerStatusacknowledged => scheduled
2022-07-04 16:58guilleaerStatusscheduled => resolved
2022-07-04 16:58guilleaerResolutionopen => fixed
2022-07-04 16:58guilleaerReview Assigned To => mtaal
2022-07-04 16:58guilleaerStatusresolved => closed

Notes
(0138792)
mtaal   
2022-06-27 17:09   
The code which is responsible for validation:
https://gitlab.com/obcustomers/AGAP/com.openbravo.flunch.integration.beeper/-/blob/master/web-jspack/com.openbravo.flunch.integration.beeper/src/FlunchPagerDeliveryControlMethod.js#L76 [^]

To do the conversion of 001 to 1 and 078 to 78 additional logic needs to be added to the same file in different places.
(0138840)
ruben_jimenez   
2022-06-29 11:44   
Pager code 0 or 00 or 000 is illegal. So pager code starting with 1234000 is also illegal.
(0138843)
hgbot   
2022-06-29 13:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1054 [^]
(0138920)
hgbot   
2022-07-01 12:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 90b280a4d775cef34ca0b6513eabf057dd22df1b
Author: Ruben Jimenez <ruben.jimenez@openbravo.com>
Date: 01-07-2022 10:53:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/90b280a4d775cef34ca0b6513eabf057dd22df1b [^]

Related to ISSUE-49640: Checked pager number before set to remove preceeding zeros

---
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/BaseScanPagerKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ScanPagerPanel/ScanPagerKeypad/ScanPagerProductKeypad.jsx
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerUtils.js
---
(0138921)
hgbot   
2022-07-01 12:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1054 [^]