Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004964Openbravo ERPI. Performancepublic2008-09-09 17:262009-11-03 06:59
Reporterjaimetorre 
Assigned Toshuehner 
PrioritylowSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target Version2.40MP11Fixed in Version2.40MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004964: Slow compilation in sqlC part due to high amount of data
DescriptionWhen compiling, sqlC executes each query to verify the sql syntax. However, if the select returns a big amount of data, sqlC takes very long to respond.

sqlC execution time should not depend on the amount of data in the database. Data is not even needed to check the correction of the sql. In order to avoid this issue, an impossilbe condition (e.g., 1=2) should be added to the sql query before testing it.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0004038 closed shuehner Slow compilation in sqlC part due to high amount of data 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-09-09 17:26anonymousNew Issue
2008-09-09 17:26anonymousAssigned To => marvintm
2008-09-09 17:26anonymousStatusnew => scheduled
2008-09-09 17:26anonymousfix_in_branch => 2.40
2008-11-05 12:02cromeroPrioritynormal => low
2008-11-05 12:02cromeroCategoryA. Platform (WAD, XmlEngine, SQLC) => I. Performance
2009-01-09 15:20rafarodaAssigned Tomarvintm => shuehner
2009-01-19 10:31rafarodaversion => 2.40
2009-08-02 19:42psarobeStatusscheduled => closed
2009-08-02 19:42psarobeResolutionopen => suspended
2009-10-13 10:14shuehnerStatusclosed => new
2009-10-13 10:14shuehnerResolutionsuspended => open
2009-10-13 10:14shuehnerStatusnew => scheduled
2009-10-13 10:14shuehnerfix_in_branch2.40 => pi
2009-10-13 10:15shuehnerfix_in_branchpi => 2.40
2009-10-13 10:23shuehnerNote Added: 0020966
2009-10-15 13:22hgbotCheckin
2009-10-15 13:22hgbotNote Added: 0021050
2009-10-15 13:22hgbotStatusscheduled => resolved
2009-10-15 13:22hgbotResolutionopen => fixed
2009-10-15 13:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/0b7c8b69af9c12841ff4c7263f4fff26c6e41fb1 [^]
2009-10-22 19:26psarobeTag Attached: main
2009-10-29 09:47psarobeTag Detached: main
2009-10-29 09:48psarobeTarget Version => 2.40MP11
2009-11-03 06:59arunkumarStatusresolved => closed
2009-11-03 06:59arunkumarNote Added: 0021521
2009-11-03 06:59arunkumarFixed in Version => 2.40MP11

Notes
(0020966)
shuehner   
2009-10-13 10:23   
Push of fix pending. Waiting for 2.40 branch to be unfrozen
(0021050)
hgbot   
2009-10-15 13:22   
Repository: erp/stable/2.40
Changeset: 0b7c8b69af9c12841ff4c7263f4fff26c6e41fb1
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Oct 13 10:22:07 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/0b7c8b69af9c12841ff4c7263f4fff26c6e41fb1 [^]

Fixed 4964: Improve SqlC performance at compile time (for big datasets)
- Include optional parameters in SqlC query execution at compile time as this
  leads to better performance in many cases
- This requires the optional parameters to be valid parts of an SQL statement
- New behavior can be configured via new Openbravo.properties setting:
  sqlc.queryExecutionStrategy=traditional,optimized
- Enable traditional by default (in template and when new setting is missing)
- Can be enabled manually to get better compile time performance if in custom
  code all optional parameters are valid sql.

---
M config/Openbravo.properties.template
M src-core/src/org/openbravo/data/Sqlc.java
M src/buildAD.xml
---
(0021521)
arunkumar   
2009-11-03 06:59   
Tested & Working fine