Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049636POS2Restaurantspublic2022-06-23 11:242022-07-15 14:24
Reportermmohammad 
Assigned Toablasco 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049636: FLUN-3105 - Wrong behavior when blind return with a product with pager and modifiers
DescriptionWhen you make a blind return for a product with biper and modifiers
with the "convert to return" option, we are asked to fill the modifiers and biper option. What is not necessary because of return.

Obtained result : the modifiers and beeper number are asked

Expected result : the product is directly added to the basket as a standard product.



Steps To ReproduceSteps :


- Login in POS2
- On the button area below the ticket info, click on the three dots button to open extra options
- Click on the "Convert to return" option. This ticket will represent now a return ticket.
- Add a product that has modifiers (i.e. Carbonio Helmet)
- The Product Configuration wizard will open, but it should not because there is no need to configure products that are about to be returned
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 004972822Q3 closed ablasco FLUN-3105 - Wrong behavior when blind return with a product with pager and modifiers 
Attached Filespng 3105_1.png (101,088) 2022-06-23 11:24
https://issues.openbravo.com/file_download.php?file_id=17220&type=bug
png

png 3105_2.png (96,628) 2022-06-23 11:25
https://issues.openbravo.com/file_download.php?file_id=17221&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-06-23 11:24mmohammadNew Issue
2022-06-23 11:24mmohammadAssigned To => Retail
2022-06-23 11:24mmohammadFile Added: 3105_1.png
2022-06-23 11:24mmohammadTriggers an Emergency Pack => No
2022-06-23 11:25mmohammadFile Added: 3105_2.png
2022-06-27 12:02timothee_catteeuwSummaryFLUN-3105 Error on blind return with a product with pager and modifiers => FLUN-3105 - Wrong behavior when blind return with a product with pager and modifiers
2022-06-27 12:02timothee_catteeuwDescription Updatedbug_revision_view_page.php?rev_id=24362#r24362
2022-06-27 12:02timothee_catteeuwSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24364#r24364
2022-06-27 16:17AugustoMauchAssigned ToRetail => ablasco
2022-06-27 16:17AugustoMauchStatusnew => scheduled
2022-06-27 16:26AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24367#r24367
2022-06-28 17:34hgbotNote Added: 0138829
2022-06-30 00:20hgbotResolutionopen => fixed
2022-06-30 00:20hgbotStatusscheduled => closed
2022-06-30 00:20hgbotNote Added: 0138877
2022-06-30 00:20hgbotNote Added: 0138878
2022-07-04 11:09timothee_catteeuwStatusclosed => new
2022-07-04 11:10timothee_catteeuwNote Added: 0139000
2022-07-05 08:34guilleaerStatusnew => scheduled
2022-07-07 13:49hgbotNote Added: 0139155
2022-07-07 14:15timothee_catteeuwNote Added: 0139156
2022-07-07 14:22timothee_catteeuwNote Edited: 0139156bug_revision_view_page.php?bugnote_id=0139156#r24447
2022-07-12 14:34guilleaerNote Edited: 0139000bug_revision_view_page.php?bugnote_id=0139000#r24470
2022-07-12 14:35guilleaerNote Edited: 0139000bug_revision_view_page.php?bugnote_id=0139000#r24471
2022-07-15 14:24hgbotStatusscheduled => closed
2022-07-15 14:24hgbotNote Added: 0139357
2022-07-15 14:24hgbotFixed in Version => 22Q4
2022-07-15 14:24hgbotNote Added: 0139358

Notes
(0138829)
hgbot   
2022-06-28 17:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1053 [^]
(0138877)
hgbot   
2022-06-30 00:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 681ae055df97d601b7c4df8e3f5b2cfc59d55eff
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 30-06-2022 00:16:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/681ae055df97d601b7c4df8e3f5b2cfc59d55eff [^]

Fixes ISSUE-49636 - Configurable Product options should not appear in return Ticket

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
---
(0138878)
hgbot   
2022-06-30 00:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1053 [^]
(0139000)
timothee_catteeuw   
2022-07-04 11:10   
(edited on: 2022-07-12 14:35)
CHANGES STARTING FROM HERE NEEDS TO BE BACKPORTED
-----------------------------------
backport issue created (https://issues.openbravo.com/view.php?id=49728 [^])
-----------------------------------


Not totally good.

→ no modifier are asked when I select products → OK

→ but when I want refund by pressing refund button, it is not possible because of this message → KO

Product is not fully configured. Please, complete or abort the current product configuration.
(0139155)
hgbot   
2022-07-07 13:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1079 [^]
(0139156)
timothee_catteeuw   
2022-07-07 14:15   
(edited on: 2022-07-07 14:22)
Linked topic :
If I click reimburse button
I select this kind of menu ( menu containing a product with at least one modifier)
Webpos ask to select the modifier but it is useless because of return

--> there is the same issue with menu

https://issues.openbravo.com/view.php?id=49757 [^] created
(0139357)
hgbot   
2022-07-15 14:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1079 [^]
(0139358)
hgbot   
2022-07-15 14:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b6c1baf51427854180e873c6f115ff5c9317b781
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 15-07-2022 12:17:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b6c1baf51427854180e873c6f115ff5c9317b781 [^]

Fixes ISSUE-49636 - Blind Return proceed to payment without Configurable Product Definition

---
M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ProductConfiguration.js
---