Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049627POS2POSpublic2022-06-22 14:172022-08-17 15:14
Reportercberner 
Assigned Toablasco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049627: Product search should filter out the service products that require to be linked to a product
DescriptionWhen a product is configured as a Service Product and marked with Linked To Product, it should not appear in the product search, as it is not possible to add it without having a product to link it with.

In old POS this works this way, the product search doesn't display service products marked with linked to product.
Steps To Reproduce1. Open and login WebPOS2
2. Click on the product search bar and write installation pack
3. Check that installation unit is shown, although is a service product and should only be added to a given linked product.

Repeat the process in old pos and see that there is filtered out. Some gifs have been attached to this issue.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesgif ServiceProductAppearingInProductSearch.gif (250,052) 2022-06-22 14:17
https://issues.openbravo.com/file_download.php?file_id=17210&type=bug
gif

gif ServiceProductNotAppearingInProductSearch.gif (159,354) 2022-06-22 14:18
https://issues.openbravo.com/file_download.php?file_id=17211&type=bug
gif
Issue History
Date ModifiedUsernameFieldChange
2022-06-22 14:17cbernerNew Issue
2022-06-22 14:17cbernerAssigned To => Retail
2022-06-22 14:17cbernerFile Added: ServiceProductAppearingInProductSearch.gif
2022-06-22 14:17cbernerTriggers an Emergency Pack => No
2022-06-22 14:18cbernerFile Added: ServiceProductNotAppearingInProductSearch.gif
2022-08-01 12:35AugustoMauchAssigned ToRetail => ablasco
2022-08-01 12:35AugustoMauchStatusnew => scheduled
2022-08-03 11:51hgbotNote Added: 0139835
2022-08-03 12:18hgbotNote Added: 0139836
2022-08-17 15:14hgbotResolutionopen => fixed
2022-08-17 15:14hgbotStatusscheduled => closed
2022-08-17 15:14hgbotFixed in Version => RR22Q4
2022-08-17 15:14hgbotNote Added: 0140203
2022-08-17 15:14hgbotNote Added: 0140204
2022-08-17 15:14hgbotNote Added: 0140205
2022-08-17 15:14hgbotFixed in VersionRR22Q4 => 22Q4
2022-08-17 15:14hgbotNote Added: 0140206

Notes
(0139835)
hgbot   
2022-08-03 11:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1119 [^]
(0139836)
hgbot   
2022-08-03 12:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/887 [^]
(0140203)
hgbot   
2022-08-17 15:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ffc9fdb1ebafd786110e443d2ad70fc789a7bd1a
Author: Adrián Blasco <adrian.blasco@openbravo.com>
Date: 17-08-2022 13:14:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ffc9fdb1ebafd786110e443d2ad70fc789a7bd1a [^]

Fixes ISSUE-49627: Properties in Cache Products to Filter Linked Service products for Product search

Several extra properties have been added to the products cache:
id, includeProducts, includeProductCategories, productType, isLinkedToProduct and proposalType

Some of this properties are not directly related with this issue, and have been added to improve the timings on some of the queries related with linked and related services.

---
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductModel.js
---
(0140204)
hgbot   
2022-08-17 15:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/887 [^]
(0140205)
hgbot   
2022-08-17 15:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1119 [^]
(0140206)
hgbot   
2022-08-17 15:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c8b0dff2aff584065d14091b3197a728fece92e8
Author: Adrián Blasco <adrian.blasco@openbravo.com>
Date: 17-08-2022 13:14:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c8b0dff2aff584065d14091b3197a728fece92e8 [^]

Fixes ISSUE-49627: Linked Service products should not appear in normal Product search

Linked service products now only appear on the Service Configuration step, as they should, and are filtered out on the normal product search.

---
M web-jspack/org.openbravo.pos2/src/components/ProductKeymap/__mock__/MockCriteria.js
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/FilteredProductsKeymap/FilteredProductsKeymap.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductSearch/FilteredProductsKeymap/GetFilteredProductsKeymapInfo.js
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/ServiceConfigurationStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceConfigurationStep/__test__/ServiceConfigurationStep.test.jsx
M web-jspack/org.openbravo.pos2/src/core/productSearch/__test__/mockMasterdataProduct.js
M web-jspack/org.openbravo.pos2/src/core/productSearch/__test__/productSearchEngine.test.js
M web-jspack/org.openbravo.pos2/src/core/productSearch/productSearchEngine.js
---