Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049597POS2POSpublic2022-06-17 10:202022-07-22 14:27
Reporternoemieroussel 
Assigned ToTriage Platform Base 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049597: A form that is not in edit mode should not be validated
DescriptionA form that it is in edit mode should should be validated before save, but if the form is not in edit mode it should not be validated.

This is a problem when in db the bp data miss any of the mandatory fields, and when opening the bp details form you close it or do any action like "view orders", it tries to validate the form when it shouldn't.


JIRA: OP-1378
Steps To ReproducePrevious steps:
- go to the db and remove the address of john doo

Steps:
- assign john doo to the ticket
- click in the john doo button in the ticket
- in the menu select view detail, it will open the view details of the bp
- click on "view orders" button

ERROR: it will validate the form and cancel the navigation
Proposed Solution
Additional Information
TagsFASH
Relationships
related to feature request 0049095 closed gorka_gil Show the customer activity 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-06-17 10:20noemierousselNew Issue
2022-06-17 10:20noemierousselAssigned To => Retail
2022-06-17 10:20noemierousselTriggers an Emergency Pack => No
2022-06-17 11:47noemierousselDescription Updatedbug_revision_view_page.php?rev_id=24307#r24307
2022-06-17 11:47noemierousselSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24309#r24309
2022-06-17 11:48noemierousselSeveritymajor => minor
2022-06-17 11:49noemierousselDescription Updatedbug_revision_view_page.php?rev_id=24310#r24310
2022-06-17 12:01gorka_gilSummary"View orders" button does not work when clicking on the "view details" button from an identified customer => A form that is not in edit mode should not be validated
2022-06-17 12:01gorka_gilDescription Updatedbug_revision_view_page.php?rev_id=24311#r24311
2022-06-17 12:01gorka_gilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24312#r24312
2022-06-17 13:59gorka_gilRelationship addedrelated to 0049095
2022-07-08 12:39rafarodaTag Attached: FASH
2022-07-12 13:51gorka_gilSeverityminor => major
2022-07-12 13:57guilleaerAssigned ToRetail => Triage Platform Base
2022-07-13 11:37hgbotNote Added: 0139295
2022-07-22 14:27hgbotResolutionopen => fixed
2022-07-22 14:27hgbotStatusnew => closed
2022-07-22 14:27hgbotFixed in Version => 22Q4
2022-07-22 14:27hgbotNote Added: 0139553
2022-07-22 14:27hgbotNote Added: 0139554

Notes
(0139295)
hgbot   
2022-07-13 11:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/798 [^]
(0139553)
hgbot   
2022-07-22 14:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b096ecf641b5dbf9bea2eda8035df81ca598ba0f
Author: Adrián Blasco <adrian.blasco@openbravo.com>
Date: 22-07-2022 12:27:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b096ecf641b5dbf9bea2eda8035df81ca598ba0f [^]

Fixes ISSUE-49597: A form that is not in edit mode should not be validated

Applied in BaseForm.jsx check on readOnly mode, if the form is in read only mode, it will not try to validate it. The same if a field is in read only mode, it will not try to validate that particular field on focus or on blur.

---
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
---
(0139554)
hgbot   
2022-07-22 14:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/798 [^]