0049498: General Ledger Journal Report does not properly implement xsql-scrollable interface (and uses too much memory)

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049498

Openbravo ERP

09. Financial management

public

2022-06-07 17:08

Reporter

shuehner

Assigned To

Triage Omni OMS

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049498: General Ledger Journal Report does not properly implement xsql-scrollable interface (and uses too much memory)

Description

Issue 35157 from 2017 converted this report to use the xsql scrollable interface which avoids loading all rows of the result into an Vector or java-array at once.

However the converted code is buggy and loads the scrollable output directly into Vector/java-array defeating the improvement:

Example here:
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java#L955 [^]

When being worked all scrollable-xsql calls should be reviewed.

Steps To Reproduce

https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java#L955 [^]

Proposed Solution

Pass scrollable interface directly into renderJR as intended.
The size=0 check can be probably replaced by scrollable.hasData() call

Additional Information