Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049453ModulesDiscounts Engine for Backendpublic2022-05-31 16:332022-06-15 13:21
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0049453: Support extending the discount rule filtering query used by the Discounts web service
DescriptionIt would be nice if the query that filters the candidate discount rules to be used by the Discounts web service could be extended to add custom filters.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0049358 closed caristu Retail Modules Support selecting the discounts to be loaded into a terminal by a store set based criteria 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-31 16:33caristuNew Issue
2022-05-31 16:33caristuAssigned To => caristu
2022-05-31 16:34caristuRelationship addedrelated to 0049358
2022-05-31 16:37hgbotNote Added: 0137902
2022-06-07 13:57hgbotNote Added: 0138112
2022-06-15 13:21hgbotResolutionopen => fixed
2022-06-15 13:21hgbotStatusnew => closed
2022-06-15 13:21hgbotNote Added: 0138367
2022-06-15 13:21hgbotNote Added: 0138368
2022-06-15 13:21hgbotNote Added: 0138369
2022-06-15 13:21hgbotNote Added: 0138370
2022-06-15 13:21hgbotNote Added: 0138371
2022-06-15 13:21hgbotNote Added: 0138372
2022-06-15 13:21hgbotNote Added: 0138373

Notes
(0137902)
hgbot   
2022-05-31 16:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/17 [^]
(0138112)
hgbot   
2022-06-07 13:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/55 [^]
(0138367)
hgbot   
2022-06-15 13:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 8f51c80580ca9a50d7dd9138ed986e43dcea0b7d
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 07-06-2022 14:01:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/8f51c80580ca9a50d7dd9138ed986e43dcea0b7d [^]

fixes ISSUE-49453: extensible filtering in the applicable discount rule query

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0138368)
hgbot   
2022-06-15 13:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 7cde17045d57f1d998c982938abadf7ca0910ec9
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 07-06-2022 15:37:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/7cde17045d57f1d998c982938abadf7ca0910ec9 [^]

related to ISSUE-49453: code improvements

  - Can directly stream the query results
  - Avoid problems that may be caused because of SimpleDateFormat not
being thread-safe

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0138369)
hgbot   
2022-06-15 13:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/17 [^]
(0138370)
hgbot   
2022-06-15 13:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 01eb82685ffb6d0ea5b2eeeea8530b2239a0b9f7
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 07-06-2022 13:54:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/01eb82685ffb6d0ea5b2eeeea8530b2239a0b9f7 [^]

related to ISSUE-49453: DiscountRuleFilter definition

---
A src/org/openbravo/retail/discounts/DiscountRuleFilter.java
A src/org/openbravo/retail/discounts/DiscountRuleFilterProvider.java
---
(0138371)
hgbot   
2022-06-15 13:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 2eac2dde81d63363782eb3709419adb167c9cd47
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 08-06-2022 14:00:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/2eac2dde81d63363782eb3709419adb167c9cd47 [^]

related to ISSUE-49453: support setting ticket date on tests

---
M src-test/org/openbravo/retail/discounts/test/base/model/Ticket.java
---
(0138372)
hgbot   
2022-06-15 13:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/55 [^]
(0138373)
hgbot   
2022-06-15 13:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 2103e2872a63415ac0551b53107fc325fccf069e
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 13-06-2022 16:56:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/2103e2872a63415ac0551b53107fc325fccf069e [^]

related to ISSUE-49453: fix warn in javadoc

---
M src-test/org/openbravo/retail/discounts/test/base/model/ExternalBusinessPartner.java
---