0049438: PostImportEntry is not being executed in some escenarios with multiple documents

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049438

Retail Modules

Web POS

public

2022-05-30 15:05

2023-06-14 13:51

Reporter

gorkaion

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR22Q3

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049438: PostImportEntry is not being executed in some escenarios with multiple documents

Description

When a POS Message contain multiple documents on the data array. If one of them fails and go to the EWI window the PostImportEntry is never executed for the documents that are properly processed.

This is a big problem for implementers that trigger external synchronization processes when a document is created in backend.

The problem is caused by the fact that as there is one document failing the exec is returning a failure so the PostImportEntry hook execution is executed.

When the EWI is fixed the process is calling the hook but this is only run for the document that originally failed.

The expected flow was broken with the fix of issue 0036037. Originally it was always executed regardless the result of the import entry process.

In my opinion this should be the expected behavior (always executed) and the implementer should check if the import entry was properly processed or not. With current approach is not possible to implement a postprocess hook to trigger a warning or rollback process on failures.

Steps To Reproduce

1. Generate a message with 2 documents in the data array.
2. Make one of the document to fail.
3. Notice that the hook is not executed.
4. Fix the EWI and check the hook is executed but on a new import entry that only contain the document that failed.

Proposed Solution

* hook to be executed regardless of the result.
* add more information to implementer with the result of the process to easily determine if a document on the data array has been processed or not. Perhaps by modifying the json in the import entry?

Additional Information

Tags

NOR

Relationships

related to	design defect	0041109	new	Triage Platform Base	Openbravo ERP	Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor
caused by	defect	0036037	closed	migueldejuana	Retail Modules	PostImportEntry hook is getting executed even if the record goes to Errors While Importing window
related to	defect	0052739	closed	ranjith_qualiantech_com	Retail Modules	Issue when the role in the POS does not have access to the C_IMPORT_ENTRY
causes	defect	0053973	closed	Rajesh_18	Retail Modules	Data Import Entries record related to cashup is empty if the cashup goes to Errors While Importing POS Data