Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049412Openbravo ERP04. Warehouse managementpublic2022-05-25 13:262022-10-06 10:35
Reportermqueralt 
Assigned ToTriage Omni WMS 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049412: AWO, Close DO automatically when Skip Delta
DescriptionAfter ‘Skip Delta’, the reception must be closed automatically because no new deliveries or other extra actions must be done.
Steps To ReproduceNA
Proposed SolutionCreate a PostConfirmGroupOfTasksHook for deal with DO close after 'Skip Delta'.
Additional Information
TagsNo tags attached.
Relationships
causes defect 0050249 closed AtulOpenbravo Modules Close DO can be launched from two different places, creating problems in Push API 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-25 13:26mqueraltNew Issue
2022-05-25 13:26mqueraltAssigned To => Triage Omni WMS
2022-05-25 13:26mqueraltOBNetwork customer => No
2022-05-25 13:26mqueraltModules => Core
2022-05-25 13:26mqueraltTriggers an Emergency Pack => No
2022-06-01 14:30hgbotMerge Request Status => open
2022-06-01 14:30hgbotNote Added: 0137945
2022-06-08 20:03hgbotNote Added: 0138174
2022-06-09 03:22hgbotNote Added: 0138176
2022-06-13 16:04hgbotMerge Request Statusopen => approved
2022-06-13 16:04hgbotResolutionopen => fixed
2022-06-13 16:04hgbotStatusnew => closed
2022-06-13 16:04hgbotNote Added: 0138310
2022-06-13 16:04hgbotNote Added: 0138311
2022-06-13 16:05hgbotNote Added: 0138312
2022-06-13 16:05hgbotNote Added: 0138313
2022-06-13 16:05hgbotNote Added: 0138314
2022-06-13 16:05hgbotNote Added: 0138315
2022-09-14 17:50vmromanosRelationship addedcauses 0050249
2022-10-06 10:35hgbotNote Added: 0141721

Notes
(0137945)
hgbot   
2022-06-01 14:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/9 [^]
(0138174)
hgbot   
2022-06-08 20:03   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/9 [^]
(0138176)
hgbot   
2022-06-09 03:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/57 [^]
(0138310)
hgbot   
2022-06-13 16:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 0c18b5987fddb90f94c6daa8a1031f6d076489d3
Author: Martin Taal <martin.taal@openbravo.com>
Date: 13-06-2022 14:04:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/0c18b5987fddb90f94c6daa8a1031f6d076489d3 [^]

Fixes ISSUE-49412: close DO on the basis of preference

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/utils/AWOTestUtils.java
---
(0138311)
hgbot   
2022-06-13 16:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/57 [^]
(0138312)
hgbot   
2022-06-13 16:05   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/merge_requests/9 [^]
(0138313)
hgbot   
2022-06-13 16:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder [^]
Changeset: 83f8e08dffa852efbf88f7ad666b762bc5078323
Author: Martin Taal <martin.taal@openbravo.com>
Date: 13-06-2022 14:05:12
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.distributionorder/-/commit/83f8e08dffa852efbf88f7ad666b762bc5078323 [^]

Fixes ISSUE-49412: Close DO when Skip Delta

---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
---
(0138314)
hgbot   
2022-06-13 16:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders [^]
Changeset: 74c439a5388ec4a37b9307097afdaec2f2e76cec
Author: Martí Queralt <marti.queralt@openbravo.com>
Date: 13-06-2022 14:05:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/commit/74c439a5388ec4a37b9307097afdaec2f2e76cec [^]

Fixes ISSUE-49412: AWO, Close DO automatically when Skip Delta

---
A src-db/database/sourcedata/AD_PREFERENCE.xml
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/CloseDOIfSkipDeltaTaskGroup.java
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
---
(0138315)
hgbot   
2022-06-13 16:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/9 [^]
(0141721)
hgbot   
2022-10-06 10:35   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders [^]
Changeset: 8eb12d5f04961105f72344a89cb249ba4995fb8b
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 06-10-2022 10:33:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/commit/8eb12d5f04961105f72344a89cb249ba4995fb8b [^]

Related to ISSUE-50249 Related to ISSUE-49412: delete tasks hook not working

Bug caught by the JUnit tests:
org.openbravo.warehouse.advancedwarehouseoperations.distributionorders.test.OBDOWithAWOTests.DOAWO040_SkipDelta
org.openbravo.warehouse.advancedwarehouseoperations.distributionorders.test.OBDOWithAWOTests.DOAWO060_SkipDelta_Default

When confirming a DO with skip delta and the OBDOA_Close_DOI_After_Skip_Delta or
the OBDOA_Close_DOR_After_Skip_Delta preferences are set, the system closes the
DO.

Before the 0050249 fix, the AfterDistributionOrderProcessedHook were not executed
for the 0049412 flow, therefore the AfterDOAWOProcessedHook class was not executed
either, which was wrong.

After the 0050249 fix, the class AfterDOAWOProcessedHook is executed. However, this class
had a bug were it was not possible to delete an assigned task.

The fix refreshes the task (only if necessary) to get an updated version without the assignee
and it adds some useful comments to understand the technical solution approach.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterDOAWOProcessedHook.java
---