Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049391ModulesOpen APIpublic2022-05-24 18:262022-06-01 17:28
Reportervmromanos 
Assigned ToTriage Omni WMS 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0049391: Use searchkey instead of name in warehouse related entity mappings
DescriptionRecently we added the following entity mappings related to warehouse:
* Goods movement (IN/OUT)
* Physical inventory (IN/OUT)
* Stock (OUT)

For all of them we tried to follow the same approach: to identify the warehouse and organization by name.

This approach is wrong and we should be using search key instead for both entities
Steps To ReproduceNA
Proposed SolutionChange all the places where we are using name to identify the organization or warehouse to use the searchkey instead.

This implies: imports, exports, and export filter parameters.

Note that it will require to change the Entity Mapping definition, any java code related (like Property mapping handlers), and automated tests.
Additional Information
TagsFASH
Relationships
caused by feature request 0049329 closed Triage Omni WMS Openbravo ERP Openbravo API to support Goods Movement 
caused by feature request 0049164 closed Triage Omni WMS Openbravo ERP Openbravo API to export current Stock 
caused by feature request 0049155 closed Triage Omni WMS Openbravo ERP Openbravo API to support Physical Inventories 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-24 18:26vmromanosNew Issue
2022-05-24 18:26vmromanosAssigned To => Triage Platform Conn
2022-05-24 18:26vmromanosOBNetwork customer => No
2022-05-24 18:26vmromanosAssigned ToTriage Platform Conn => ramprakash
2022-05-24 18:28vmromanosRelationship addedcaused by 0049329
2022-05-24 18:28vmromanosRelationship addedcaused by 0049164
2022-05-24 18:28vmromanosRelationship addedcaused by 0049155
2022-05-25 08:20vmromanosAssigned Toramprakash => Triage Omni WMS
2022-05-25 11:18hgbotMerge Request Status => open
2022-05-25 11:18hgbotNote Added: 0137720
2022-05-25 11:19hgbotNote Added: 0137721
2022-05-30 08:48rafarodaIssue Monitored: rafaroda
2022-05-30 08:48rafarodaTag Attached: FASH
2022-06-01 17:28hgbotMerge Request Statusopen => approved
2022-06-01 17:28hgbotResolutionopen => fixed
2022-06-01 17:28hgbotStatusnew => closed
2022-06-01 17:28hgbotNote Added: 0137948
2022-06-01 17:28hgbotNote Added: 0137949
2022-06-01 17:28hgbotNote Added: 0137950
2022-06-01 17:28hgbotNote Added: 0137951

Notes
(0137720)
hgbot   
2022-05-25 11:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/51 [^]
(0137721)
hgbot   
2022-05-25 11:19   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/17 [^]
(0137948)
hgbot   
2022-06-01 17:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 9a7ace1fc502b10369aa52e5654e6494e942f32c
Author: Prakash M <prakash@qualiantech.com>
Date: 01-06-2022 15:28:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/9a7ace1fc502b10369aa52e5654e6494e942f32c [^]

Fixes ISSUE-49391: Changed to searchkey instead of name in warehouse and organization entity mappings

---
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
M src/org/openbravo/api/mappings/goodsmovementline/ImportGoodsMvmtLineJavaPropertyMappingHandler.java
---
(0137949)
hgbot   
2022-06-01 17:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/51 [^]
(0137950)
hgbot   
2022-06-01 17:28   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a30ddbf301ab53f2dd6d6a62247188ced44f536f
Author: Prakash M <prakash@qualiantech.com>
Date: 25-05-2022 14:45:47
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a30ddbf301ab53f2dd6d6a62247188ced44f536f [^]

Related to ISSUE-49391: Fixed test by changing to searchkey instead of name for warehouse and organization

---
M src-test/data/export/filter/inventory/InventoryByWarehouseDateRange.json
M src-test/data/export/filter/stock/StockByProduct.json
M src-test/data/export/filter/stock/StockByWarehouse.json
M src-test/data/export/filter/stock/StockByWarehouseBin.json
M src-test/data/export/filter/stock/StockByWarehouseBinProduct.json
M src-test/data/importer/GoodsMovement.json
M src-test/data/importer/Inventory.json
---
(0137951)
hgbot   
2022-06-01 17:28   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/17 [^]