Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049381POS2POSpublic2022-05-23 17:552022-05-26 16:02
Reportergorka_gil 
Assigned Togorka_gil 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049381: Improve presentation of the image of last scanned product
DescriptionThe last scanned product image should not have a background color white but transparent.

And needs to be scaled to fill the space available but maintaining aspect ratio.

The no image image should not be a img tag but a mask, to allow the opacity.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0049137 closed Retail add scan tab to pos2 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-23 17:55gorka_gilNew Issue
2022-05-23 17:55gorka_gilAssigned To => gorka_gil
2022-05-23 17:55gorka_gilTriggers an Emergency Pack => No
2022-05-23 17:55gorka_gilRelationship addedrelated to 0049137
2022-05-23 18:03hgbotNote Added: 0137642
2022-05-23 18:08hgbotNote Added: 0137643
2022-05-26 16:00hgbotResolutionopen => fixed
2022-05-26 16:00hgbotStatusnew => closed
2022-05-26 16:00hgbotNote Added: 0137765
2022-05-26 16:00hgbotNote Added: 0137766
2022-05-26 16:00hgbotNote Added: 0137767
2022-05-26 16:00hgbotNote Added: 0137768
2022-05-26 16:00hgbotNote Added: 0137769
2022-05-26 16:00hgbotNote Added: 0137770
2022-05-26 16:00hgbotNote Added: 0137771
2022-05-26 16:00hgbotNote Added: 0137772
2022-05-26 16:00hgbotNote Added: 0137773
2022-05-26 16:00hgbotNote Added: 0137774
2022-05-26 16:00hgbotNote Added: 0137775
2022-05-26 16:00hgbotNote Added: 0137776
2022-05-26 16:00hgbotNote Added: 0137777
2022-05-26 16:00hgbotNote Added: 0137778
2022-05-26 16:02hgbotNote Added: 0137779
2022-05-26 16:02hgbotNote Added: 0137780
2022-05-26 16:02hgbotNote Added: 0137781
2022-05-26 16:02hgbotNote Added: 0137782
2022-05-26 16:02hgbotNote Added: 0137783

Notes
(0137642)
hgbot   
2022-05-23 18:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/966 [^]
(0137643)
hgbot   
2022-05-23 18:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/755 [^]
(0137773)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5f8308bb0f0a46447261501c57dc37d7f84b7ad6
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5f8308bb0f0a46447261501c57dc37d7f84b7ad6 [^]

Related to ISSUE-49381: Fix icons of browse and scan

---
M web-jspack/org.openbravo.pos2/src/assets/icons/browse.svg
M web-jspack/org.openbravo.pos2/src/assets/icons/scan.svg
---
(0137772)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 487e9f6f03b1f14b63f57202d85f94d6807619ee
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/487e9f6f03b1f14b63f57202d85f94d6807619ee [^]

Related to ISSUE-49381: Remove no useful story

---
R web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/stories/ProductScanProductInfoImage.stories.jsx
---
(0137771)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8207b367d391c6f406ebd5879bd6de178e8405b7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8207b367d391c6f406ebd5879bd6de178e8405b7 [^]

Related to ISSUE-49381: Fix noImage style

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/ProductScanProductInfoImage.jsx
---
(0137770)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5184aefdbc391857ee26cc3ff9999ae2bb7715ef
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5184aefdbc391857ee26cc3ff9999ae2bb7715ef [^]

Related to ISSUE-49381: Replace scan icon

---
M web-jspack/org.openbravo.pos2/src/assets/icons/scan.svg
---
(0137769)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1290a7a739385aa506559d409a010a54441b47c7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1290a7a739385aa506559d409a010a54441b47c7 [^]

Related to ISSUE-49381: Review last scanned product: Fix z-index to allow seleccion of name and review background-color definition

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScan.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
---
(0137768)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a0903ff59d834bc573e984da3fc72184e384f885
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a0903ff59d834bc573e984da3fc72184e384f885 [^]

Related to ISSUE-49381: Review, use ProductScanProductInfoImage instead PropertyImage

When no image, is displayed a div with mask instead a img

---
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/ProductScanProductInfoImage.jsx
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/__test__/ProductScanProductInfoImage.test.jsx
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/index.js
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/stories/ProductScanProductInfoImage.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/__test__/ProductScan.test.jsx
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0137767)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4ff2c15834365e258c8862dc83347ef2c15bfcfc
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4ff2c15834365e258c8862dc83347ef2c15bfcfc [^]

Related to ISSUE-49381: Review, use css variables

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
---
(0137766)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 69f920b4bfea5fb4aac1f33d7847a651b9a98fe4
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/69f920b4bfea5fb4aac1f33d7847a651b9a98fe4 [^]

Related to ISSUE-49381: Review, fix the expand of small images

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
---
(0137765)
hgbot   
2022-05-26 16:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 620ed506057eb923127622c02d7afc21db3ebe16
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/620ed506057eb923127622c02d7afc21db3ebe16 [^]

Fixes ISSUE-49381: improve last scanned product image

- remove white background color around image
- scale image to fit space
- no image: use a mask background image instead a img tag to allow play with color and opacity

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
---
(0137774)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ed7b0ebc500d9749643231c28b38181f8d9a4966
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ed7b0ebc500d9749643231c28b38181f8d9a4966 [^]

Related to ISSUE-49381: Fix space between time and date

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanDateInfo/ProductScanDateInfo.scss
---
(0137775)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5d4d6211b67010e54fb8ec30950345cb0f7842a7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5d4d6211b67010e54fb8ec30950345cb0f7842a7 [^]

Related to ISSUE-49381: Use font var instead hardcoded size

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanDateInfo/ProductScanDateInfo.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
---
(0137776)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f57c14594aa196a5904cbdc3c7e8d0effdebab60
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:58:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f57c14594aa196a5904cbdc3c7e8d0effdebab60 [^]

Related to ISSUE-49381: Fix separation between time and date

---
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanDateInfo/ProductScanDateInfo.scss
---
(0137777)
hgbot   
2022-05-26 16:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 672e8e10ecfd5982416aa6c2226a43addb4c0781
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 15:59:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/672e8e10ecfd5982416aa6c2226a43addb4c0781 [^]

Related to ISSUE-49381: Merge branch 'fr/49381-lastScannedImage'

---
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/ProductScanProductInfoImage.jsx
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/__test__/ProductScanProductInfoImage.test.jsx
A web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfoImage/index.js
M web-jspack/org.openbravo.pos2/src/assets/icons/browse.svg
M web-jspack/org.openbravo.pos2/src/assets/icons/scan.svg
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScan.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanDateInfo/ProductScanDateInfo.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.config.json
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss
M web-jspack/org.openbravo.pos2/src/components/ProductScan/__test__/ProductScan.test.jsx
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0137778)
hgbot   
2022-05-26 16:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/966 [^]
(0137779)
hgbot   
2022-05-26 16:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 61861819b61659587f838d1ce0ee8bf15e8b4ac8
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 25-05-2022 16:53:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/61861819b61659587f838d1ce0ee8bf15e8b4ac8 [^]

Related to ISSUE-49381: improve last scanned product image

- Use the correct svg of no image icon
- Allow specify variant class as property

---
M web-jspack/org.openbravo.core2/src/assets/icons/noImage.svg
M web-jspack/org.openbravo.core2/src/components/PropertyImage/PropertyImage.jsx
---
(0137780)
hgbot   
2022-05-26 16:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 95d75211c1a2169d9d23d2b96e12a918ecde5373
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 25-05-2022 16:53:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/95d75211c1a2169d9d23d2b96e12a918ecde5373 [^]

Related to ISSUE-49381: stop using propertyImage, created in pos2 the ProductScanProductInfoImage component

---
M web-jspack/org.openbravo.core2/src/ob-init.js
R web-jspack/org.openbravo.core2/src/components/PropertyImage/PropertyImage.jsx
R web-jspack/org.openbravo.core2/src/components/PropertyImage/__test__/PropertyImage.test.jsx
R web-jspack/org.openbravo.core2/src/components/PropertyImage/index.js
R web-jspack/org.openbravo.core2/src/components/PropertyImage/stories/PropertyImage.stories.jsx
---
(0137781)
hgbot   
2022-05-26 16:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0a95a124aab9beaa21e2b84701e0898491f568ed
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 13:52:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0a95a124aab9beaa21e2b84701e0898491f568ed [^]

Related to ISSUE-49381: Fix images

---
M web-jspack/org.openbravo.core2/src/assets/icons/logoOpenbravo.svg
M web-jspack/org.openbravo.core2/src/assets/icons/noImage.svg
---
(0137782)
hgbot   
2022-05-26 16:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e93be99fecce084bb016e3809c5027c21fb90e9b
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 26-05-2022 16:01:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e93be99fecce084bb016e3809c5027c21fb90e9b [^]

Related to ISSUE-49381: Merge branch 'fr/49381-lastScannedImage'

---
M web-jspack/org.openbravo.core2/src/assets/icons/logoOpenbravo.svg
M web-jspack/org.openbravo.core2/src/assets/icons/noImage.svg
M web-jspack/org.openbravo.core2/src/ob-init.js
R web-jspack/org.openbravo.core2/src/components/PropertyImage/PropertyImage.jsx
R web-jspack/org.openbravo.core2/src/components/PropertyImage/__test__/PropertyImage.test.jsx
R web-jspack/org.openbravo.core2/src/components/PropertyImage/index.js
R web-jspack/org.openbravo.core2/src/components/PropertyImage/stories/PropertyImage.stories.jsx
---
(0137783)
hgbot   
2022-05-26 16:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/755 [^]