Openbravo Issue Tracking System - Retail Modules
View Issue Details
0049377Retail ModulesNexo Implementationpublic2022-05-23 15:222022-06-27 17:15
shuehner 
adrianromero 
normalmajorhave not tried
closedfixed 
5
 
 
No
0049377: nexoprovider module pacakge.json semver should be reviewed and package-lock.json should be updated
a.) package.json of nexoprovider module hardcodes versions of its dependencies very strictly.

That should be reviewed and unless special reason exists more typical ^ semver instead of = should be used.

JSONIX part is managed in the related design defect https://issues.openbravo.com/view.php?id=49609 [^]

b.1) npm audit issues (easy)
run "npm audit fix"

b.2) npm audit issues
xmldom avoiding old versions is still not possible as depended upon by jsonix@3.0.0

c.) jsonix@3.0.0 contains jsonix-schema-compiler-full.jar including outdated other libraries
jsonix-schema-compiler-full.jar (shaded: commons-beanutils:commons-beanutils:1.9.2)
jsonix-schema-compiler-full.jar (shaded: commons-collections:commons-collections:3.2.1)

Note:
- jsonix upstream seems to not have released a new version >3.0.0 yet

run npm audit
run owasp-dependency check with "npm install" done before in the module
No tags attached.
related to design defect 0049609 new adrianromero nexoprovider module package.json versions should be reviewed because of jsonix dependency 
Issue History
2022-05-23 15:22shuehnerNew Issue
2022-05-23 15:22shuehnerAssigned To => Triage Platform Conn
2022-05-23 15:22shuehnerTriggers an Emergency Pack => No
2022-06-01 10:50adrianromeroAssigned ToTriage Platform Conn => adrianromero
2022-06-20 16:29hgbotNote Added: 0138571
2022-06-20 17:49adrianromeroIssue cloned0049609
2022-06-20 17:49adrianromeroRelationship addedrelated to 0049609
2022-06-20 17:51adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=24323#r24323
2022-06-27 17:15hgbotResolutionopen => fixed
2022-06-27 17:15hgbotStatusnew => closed
2022-06-27 17:15hgbotNote Added: 0138795
2022-06-27 17:15hgbotNote Added: 0138796
2022-06-27 17:15hgbotNote Added: 0138797

Notes
(0138571)
hgbot   
2022-06-20 16:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/merge_requests/12 [^]
(0138795)
hgbot   
2022-06-27 17:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider [^]
Changeset: a1d9f10799d137a81328e89e68a7fbfec1942e83
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 20-06-2022 16:26:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/commit/a1d9f10799d137a81328e89e68a7fbfec1942e83 [^]

Fixes ISSUE-49377: nexoprovider module pacakge.json semver should be reviewed and package-lock.json should be updated

---
M package-lock.json
M package.json
---
(0138796)
hgbot   
2022-06-27 17:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider [^]
Changeset: 2ea02ad1581dca938e3e71e3ead749dda6a836b0
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 20-06-2022 16:39:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/commit/2ea02ad1581dca938e3e71e3ead749dda6a836b0 [^]

Fixes ISSUE-49377: nexoprovider module package.json ver should be reviewed and package-lock.json should be updated

---
M package-lock.json
M package.json
---
(0138797)
hgbot   
2022-06-27 17:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.nexoprovider/-/merge_requests/12 [^]