Openbravo Issue Tracking System - Retail Modules
View Issue Details
0049368Retail ModulesDiscounts and Promotionspublic2022-05-20 12:552022-05-24 19:00
cberner 
AugustoMauch 
normalminorhave not tried
closedfixed 
5
 
 
No
0049368: Comparator selector in module propertycondition in tab CRM Property Condition doesn't filter accordingly
In window Discounts and Promotions, in the tab CRM Property Condition when creating or modifying a record, there's a selector for the comparator, this one should only show the comparators that are supported for the CRM Property selected reference type.

As of now, it shows all the comparators registered in the application, some of this will not work on the given property. For example, with a CRM Property that is a String reference, Is Today comparator should not appear in the selector.
1. Install module org.openbravo.discounts.propertycondition
2. Open backoffice and login as system admin
3. Go to Discounts and Promotions window and select one discount
4. In CRM Property Condition tab, add a new record and check that the Comparator selector doesn't filter accordingly.
No tags attached.
png NotWorkingComparatorSelector.png (374,615) 2022-05-20 12:55
https://issues.openbravo.com/file_download.php?file_id=17046&type=bug
Issue History
2022-05-20 12:55cbernerNew Issue
2022-05-20 12:55cbernerAssigned To => cberner
2022-05-20 12:55cbernerFile Added: NotWorkingComparatorSelector.png
2022-05-20 12:55cbernerTriggers an Emergency Pack => No
2022-05-24 13:19AugustoMauchAssigned Tocberner => AugustoMauch
2022-05-24 13:19AugustoMauchStatusnew => scheduled
2022-05-24 13:30hgbotNote Added: 0137677
2022-05-24 19:00hgbotResolutionopen => fixed
2022-05-24 19:00hgbotStatusscheduled => closed
2022-05-24 19:00hgbotNote Added: 0137683
2022-05-24 19:00hgbotNote Added: 0137684

Notes
(0137677)
hgbot   
2022-05-24 13:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/2 [^]
(0137683)
hgbot   
2022-05-24 19:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^]
Changeset: 45b3f864acd1b0a10de112338dd16173007a753c
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 24-05-2022 13:30:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/45b3f864acd1b0a10de112338dd16173007a753c [^]

Fixes ISSUE-49368: Adds a validator to show only comparators available for currently selected field

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0137684)
hgbot   
2022-05-24 19:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/2 [^]