Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049357Retail ModulesWeb POSpublic2022-05-19 11:022022-06-09 07:42
Reporterfermin_ostivar 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR19Q3.3 
Target VersionFixed in VersionRR22Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049357: changePayments is not set in SCO Mode
DescriptionThe changePayments is not set in SCO Mode.

The changePayments array is not set in the receipt in SCO mode because the updatePending trigger is not catched in SCO mode so the values amount and origAmount of the payment are different from paid in the payment object.

Amount and origAmount are set if changePayments exists but in SCO mode changePayments is undefined.
Steps To Reproduce1) Disable handlers to avoid cash payment in SCO Mode
2) Add extra amount in mock payment provider to force overpayment
3) Configure cash payment method in TouchPoint
4) Create an order in SCO Mode
Proposed SolutionAdd changePayments to receipt in SCO mode as Traditional Mode
Additional Information
TagsNo tags attached.
Relationships
Attached Files? example.json (11,536) 2022-05-19 11:02
https://issues.openbravo.com/file_download.php?file_id=17037&type=bug
txt debug.txt (1,507) 2022-05-19 11:04
https://issues.openbravo.com/file_download.php?file_id=17039&type=bug
diff 49357_19Q3_posterminal.diff (7,572) 2022-06-06 06:26
https://issues.openbravo.com/file_download.php?file_id=17119&type=bug
diff 49357_19Q3_selfcheckout.diff (1,178) 2022-06-06 06:26
https://issues.openbravo.com/file_download.php?file_id=17120&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-05-19 11:02fermin_ostivarNew Issue
2022-05-19 11:02fermin_ostivarAssigned To => Retail
2022-05-19 11:02fermin_ostivarFile Added: example.json
2022-05-19 11:02fermin_ostivarOBNetwork customer => Gold
2022-05-19 11:02fermin_ostivarTriggers an Emergency Pack => No
2022-05-19 11:03fermin_ostivarFile Added: debug.txt
2022-05-19 11:04fermin_ostivarFile Deleted: debug.txt
2022-05-19 11:04fermin_ostivarFile Added: debug.txt
2022-05-31 10:01ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-05-31 12:04ranjith_qualiantech_comStatusnew => scheduled
2022-06-06 06:19hgbotMerge Request Status => open
2022-06-06 06:19hgbotNote Added: 0138079
2022-06-06 06:19hgbotNote Added: 0138080
2022-06-06 06:26ranjith_qualiantech_comFile Added: 49357_19Q3_posterminal.diff
2022-06-06 06:26ranjith_qualiantech_comFile Added: 49357_19Q3_selfcheckout.diff
2022-06-09 07:42hgbotMerge Request Statusopen => approved
2022-06-09 07:42hgbotResolutionopen => fixed
2022-06-09 07:42hgbotStatusscheduled => closed
2022-06-09 07:42hgbotNote Added: 0138181
2022-06-09 07:42hgbotFixed in Version => RR22Q3
2022-06-09 07:42hgbotNote Added: 0138182
2022-06-09 07:42hgbotNote Added: 0138183
2022-06-09 07:42hgbotNote Added: 0138184

Notes
(0138079)
hgbot   
2022-06-06 06:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/merge_requests/33 [^]
(0138080)
hgbot   
2022-06-06 06:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/819 [^]
(0138181)
hgbot   
2022-06-09 07:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/819 [^]
(0138182)
hgbot   
2022-06-09 07:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dd6d56bbf16bbf796a0e832ecde183990558f9fb
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 09-06-2022 05:42:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dd6d56bbf16bbf796a0e832ecde183990558f9fb [^]

Fixed ISSUE-49357: Moved Receipt calculateChange to Order Model from payment view

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0138183)
hgbot   
2022-06-09 07:42   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout [^]
Changeset: f35f4634268d19dc762f79d098a2d5c8b524793c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-06-2022 12:48:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/commit/f35f4634268d19dc762f79d098a2d5c8b524793c [^]

Related to ISSUE-49357: Receipt changePayment should be updated when payment is added

---
M web/org.openbravo.retail.selfcheckout/source/view/scoModel.js
---
(0138184)
hgbot   
2022-06-09 07:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.selfcheckout/-/merge_requests/33 [^]