Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049329Openbravo ERP04. Warehouse managementpublic2022-05-16 09:552022-06-07 19:15
Reporterprakashmurugesan88 
Assigned ToTriage Omni WMS 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049329: Openbravo API to support Goods Movement
DescriptionCreate API to:
1. Import Goods Movement into Openbravo
2. Export Goods Movement from Openbravo
Steps To ReproduceNA
Proposed SolutionExtend the Openbravo API to support importing/exporting goods movement documents
Additional Information
TagsNo tags attached.
Relationships
related to defect 0049393 closed Triage Platform Conn Modules Performance improvements in goods movement and physical inventory import 
causes feature request 0049391 closed Triage Omni WMS Modules Use searchkey instead of name in warehouse related entity mappings 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-16 09:55prakashmurugesan88New Issue
2022-05-16 09:55prakashmurugesan88Assigned To => Triage Omni WMS
2022-05-16 09:55prakashmurugesan88Modules => Core
2022-05-16 09:55prakashmurugesan88Triggers an Emergency Pack => No
2022-05-17 16:19hgbotNote Added: 0137393
2022-05-17 16:19hgbotNote Added: 0137394
2022-05-18 03:16hgbotNote Added: 0137402
2022-05-18 17:07vmromanosNote Deleted: 0137394
2022-05-20 07:27hgbotNote Added: 0137555
2022-05-20 08:00hgbotNote Added: 0137556
2022-05-23 14:05hgbotNote Added: 0137613
2022-05-23 14:05hgbotNote Added: 0137614
2022-05-23 14:11hgbotResolutionopen => fixed
2022-05-23 14:11hgbotStatusnew => closed
2022-05-23 14:11hgbotNote Added: 0137615
2022-05-23 14:11hgbotNote Added: 0137616
2022-05-23 14:11hgbotNote Added: 0137617
2022-05-23 14:11hgbotNote Added: 0137618
2022-05-23 14:11hgbotNote Added: 0137619
2022-05-23 14:11hgbotNote Added: 0137620
2022-05-23 14:11hgbotNote Added: 0137621
2022-05-23 14:11hgbotNote Added: 0137622
2022-05-23 14:11hgbotNote Added: 0137623
2022-05-23 14:11hgbotNote Added: 0137624
2022-05-23 14:11hgbotNote Added: 0137625
2022-05-23 14:11hgbotNote Added: 0137626
2022-05-23 14:11hgbotNote Added: 0137627
2022-05-23 14:11hgbotNote Added: 0137628
2022-05-23 14:11hgbotNote Added: 0137629
2022-05-23 14:11hgbotNote Added: 0137630
2022-05-24 08:36hgbotNote Added: 0137655
2022-05-24 11:58hgbotNote Added: 0137676
2022-05-24 18:28vmromanosRelationship addedcauses 0049391
2022-05-24 18:39vmromanosRelationship addedrelated to 0049393
2022-06-07 19:15hgbotNote Added: 0138128

Notes
(0137393)
hgbot   
2022-05-17 16:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/44 [^]
(0137402)
hgbot   
2022-05-18 03:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/2 [^]
(0137555)
hgbot   
2022-05-20 07:27   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/601 [^]
(0137556)
hgbot   
2022-05-20 08:00   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/15 [^]
(0137613)
hgbot   
2022-05-23 14:05   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 723b7adc8eabb1743c3f7dd6f327b8f7deda4543
Author: Prakash M <prakash@qualiantech.com>
Date: 20-05-2022 13:57:53
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/723b7adc8eabb1743c3f7dd6f327b8f7deda4543 [^]

Related to ISSUE-49329: Created Index for M_Movement.MOVEMENTDATE column to avoid performance problems

---
M src-db/database/model/tables/M_MOVEMENT.xml
---
(0137614)
hgbot   
2022-05-23 14:05   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/601 [^]
(0137615)
hgbot   
2022-05-23 14:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 094b68bf72f9b95fb8b9acfbed9df70fbff2a282
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 23-05-2022 14:07:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/094b68bf72f9b95fb8b9acfbed9df70fbff2a282 [^]

Fixed ISSUE-49329: API for Goods Movements import/export

---
A src/org/openbravo/api/event/goodsmovement/GoodsMvmtLinesEventHandler.java
A src/org/openbravo/api/hook/goodsmovement/ImportGoodsMvmtBaseOBObjectFetcher.java
A src/org/openbravo/api/hook/goodsmovement/ImportedGoodsMvmtBaseOBObjectAfterFlushHook.java
A src/org/openbravo/api/hook/goodsmovementline/ImportGoodsMvmtLineOBObjectInitializer.java
A src/org/openbravo/api/mappings/goodsmovement/ImportGoodsMvmtJavaPropertyMappingHandler.java
A src/org/openbravo/api/mappings/goodsmovementline/ImportGoodsMvmtLineJavaPropertyMappingHandler.java
M examples/Openbravo API.postman_collection.json
M src-db/database/sourcedata/API_EXPORT_FILTER.xml
M src-db/database/sourcedata/API_EXPORT_FILTER_PARAM.xml
M src-db/database/sourcedata/OBEI_ENTITY_MAPPING.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0137616)
hgbot   
2022-05-23 14:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/44 [^]
(0137617)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: 8bbedc2936ddbbe325be162412a0b717fa8a365d
Author: Prakash M <prakash@qualiantech.com>
Date: 19-05-2022 10:57:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/8bbedc2936ddbbe325be162412a0b717fa8a365d [^]

Related to ISSUE-49329: Created hook to add/remove preference to allow Goods Movement outside AWO

---
A src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/AWOAPIGoodsMvmtHookConstants.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportGoodsMvmtOBObjectInitializer.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportedGoodsMvmtBaseOBObjectAfterFlushHookExtension.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookConstants.java
---
(0137618)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: 2a37d6866f14e69b32d2fdfc6faf6d20af9e7501
Author: Prakash M <prakash@qualiantech.com>
Date: 20-05-2022 11:24:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/2a37d6866f14e69b32d2fdfc6faf6d20af9e7501 [^]

Related to ISSUE-49329: Removed preference checks with context organization
As goods movement organization can be different and it will not be available here
So creating preference always

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookConstants.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportGoodsMvmtOBObjectInitializer.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportedGoodsMvmtBaseOBObjectAfterFlushHookExtension.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/inventory/ImportInventoryOBObjectInitializer.java
R src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/AWOAPIGoodsMvmtHookConstants.java
---
(0137619)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: 1cff23a1ee1d026321fd03bd9a9cad938b80be8e
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 20-05-2022 10:21:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/1cff23a1ee1d026321fd03bd9a9cad938b80be8e [^]

Related to ISSUE-49329: minor code improvement

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportGoodsMvmtOBObjectInitializer.java
---
(0137621)
hgbot   
2022-05-23 14:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: 7886439d8917ec42a018b07e882b47f167061dd4
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 23-05-2022 14:09:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/7886439d8917ec42a018b07e882b47f167061dd4 [^]

Fixed ISSUE-49329: Goods Movement support

---
A src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportGoodsMvmtOBObjectInitializer.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportedGoodsMvmtBaseOBObjectAfterFlushHookExtension.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookConstants.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/AWOAPIHookUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/inventory/ImportInventoryOBObjectInitializer.java
---
(0137620)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api [^]
Changeset: d356957019c7753680a78f5b756a40b666174434
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 20-05-2022 13:08:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/commit/d356957019c7753680a78f5b756a40b666174434 [^]

Related to ISSUE-49329: avoid checking organization from context

This check is not accurate and it's better to create always the preference (regardless it's not actually needed).

Also note that this module will be installed with AWO, so it's very likely that we might need to create it.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/goodsmovement/ImportGoodsMvmtOBObjectInitializer.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/api/hooks/inventory/ImportInventoryOBObjectInitializer.java
---
(0137622)
hgbot   
2022-05-23 14:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/2 [^]
(0137623)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a378feae7ff93c2d3bc66fe53a3d4f179ed505fc
Author: Prakash M <prakash@qualiantech.com>
Date: 19-05-2022 17:15:36
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a378feae7ff93c2d3bc66fe53a3d4f179ed505fc [^]

Related to ISSUE-49329: Added test for Goods Movement Export API

---
A src-test/data/export/filter/goodsmovement/GoodsMvmtById.json
A src-test/data/export/filter/goodsmovement/GoodsMvmtByNameAndOrg.json
A src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0137624)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 408f00316daaa9d283d1839731261850706fe688
Author: Prakash M <prakash@qualiantech.com>
Date: 19-05-2022 17:15:36
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/408f00316daaa9d283d1839731261850706fe688 [^]

Related to ISSUE-49329: Added test for Goods Movement Import API

---
A src-test/data/importer/GoodsMovement.json
A src-test/org/openbravo/api/tests/importer/ImportGoodsMovement.java
---
(0137625)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: a89ce0b77d0880f7faba62485a0e5b3de281c0df
Author: Prakash M <prakash@qualiantech.com>
Date: 20-05-2022 11:28:23
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/a89ce0b77d0880f7faba62485a0e5b3de281c0df [^]

Related to ISSUE-49329: Removed Filter By Goods Movement Name Test

---
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
---
(0137626)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: afcbe308f6a878fd7abb14afa2ecb02341cee73c
Author: Prakash M <prakash@qualiantech.com>
Date: 20-05-2022 15:22:39
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/afcbe308f6a878fd7abb14afa2ecb02341cee73c [^]

Related to ISSUE-49329: Added new test for export goods movement with org id

---
A src-test/org/openbravo/api/tests/importer/ImportGoodsMovementWithAWOEnabled.java
M src-test/org/openbravo/api/tests/StandaloneTestSuite.java
M src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
M src-test/org/openbravo/api/tests/importer/ImportGoodsMovement.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0137627)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: eb42a5295a082640cf8af4ef33def49575f70a8d
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 20-05-2022 14:29:12
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/eb42a5295a082640cf8af4ef33def49575f70a8d [^]

Related to ISSUE-49329: Fixed ApiImportMappingsTest after adding goods movement

It is necessary to mock request context because the goods movement import (or any other document that
has a documentNo), will fail due to the SetDocumentNoHandler that is trying to calculate the documentNo
based on the VariablesSecureApp

---
M src-test/org/openbravo/api/tests/importer/ApiImportMappingsTest.java
---
(0137628)
hgbot   
2022-05-23 14:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 3021abe6b6e8c6ac10fd4008efb639b7dc3fab2d
Author: Prakash M <prakash@qualiantech.com>
Date: 20-05-2022 18:43:55
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/3021abe6b6e8c6ac10fd4008efb639b7dc3fab2d [^]

Related to ISSUE-49329: Fixed ImportGoodsMovementTest

It is necessary to mock request context because the goods movement import (or any other document that
has a documentNo), will fail due to the SetDocumentNoHandler that is trying to calculate the documentNo
based on the VariablesSecureApp

---
M src-test/org/openbravo/api/tests/StandaloneTestSuite.java
M src-test/org/openbravo/api/tests/importer/ImportGoodsMovement.java
M src-test/org/openbravo/api/tests/importer/ImportGoodsMovementWithAWOEnabled.java
---
(0137629)
hgbot   
2022-05-23 14:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 98514700dcb32c51b35132813be2ab1dab29f764
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 23-05-2022 14:09:04
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/98514700dcb32c51b35132813be2ab1dab29f764 [^]

Fixed ISSUE-49329: API for Goods Movements import/export tests

---
A src-test/data/export/filter/goodsmovement/GoodsMvmtById.json
A src-test/data/export/filter/goodsmovement/GoodsMvmtByNameAndOrg.json
A src-test/data/importer/GoodsMovement.json
A src-test/org/openbravo/api/tests/export/ApiExportGoodsMovementFilters.java
A src-test/org/openbravo/api/tests/importer/ImportGoodsMovement.java
A src-test/org/openbravo/api/tests/importer/ImportGoodsMovementWithAWOEnabled.java
M src-test/org/openbravo/api/tests/StandaloneTestSuite.java
M src-test/org/openbravo/api/tests/importer/ApiImportMappingsTest.java
M src-test/org/openbravo/api/tests/util/ApiTestConstants.java
---
(0137630)
hgbot   
2022-05-23 14:11   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/merge_requests/15 [^]
(0137655)
hgbot   
2022-05-24 08:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/3 [^]
(0137676)
hgbot   
2022-05-24 11:58   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: bd709ac6da9b7a4134add9481ec3cd1a5610e3da
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 24-05-2022 11:57:11
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/bd709ac6da9b7a4134add9481ec3cd1a5610e3da [^]

Related to ISSUE-49329: temporary removing failing tests in Oracle

Platform team is researching this topic meanwhile.

---
M src-test/org/openbravo/api/tests/StandaloneTestSuite.java
---
(0138128)
hgbot   
2022-06-07 19:15   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.api/-/merge_requests/3 [^]