Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049325Retail ModulesWeb POSpublic2022-05-14 06:352022-06-09 07:44
Reportercollazoandy4 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049325: Barcode duplicity in digital coupons doesn't check draft payments if more than one order is paid
DescriptionWhen more than one order is paid with digital coupon and Check Barcode Duplicity preference is enabled this duplicity doesn't take into account the payments in draft
Steps To ReproduceEnable Check Barcode Duplicity preference
Log in YS-11 Pos terminal
Create two receipts and paid it using digital coupon as payment method
Register two payments with the same barcode and check that the duplicity validation doesn't work
Also the check number by the same issuing company validation doesn't work either
Proposed SolutionUse the multiorder payment model to run the barcode and check number with the same issuing company validations in Pay Open Tickets process.

Proposed diff attached
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0049324 closed rqueralta Missing coupon argument in obidcoPreAddCouponHook 
Attached Filespatch Added-verification-for-check-numbers.patch (1,214) 2022-05-14 06:35
https://issues.openbravo.com/file_download.php?file_id=17022&type=bug
patch Added-verification-for-used-digital-coupo.patch (903) 2022-05-14 06:36
https://issues.openbravo.com/file_download.php?file_id=17023&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-05-14 06:35collazoandy4New Issue
2022-05-14 06:35collazoandy4Assigned To => Retail
2022-05-14 06:35collazoandy4File Added: Added-verification-for-check-numbers.patch
2022-05-14 06:35collazoandy4Triggers an Emergency Pack => No
2022-05-14 06:36collazoandy4File Added: Added-verification-for-used-digital-coupo.patch
2022-05-14 06:36collazoandy4Relationship addeddepends on 0049324
2022-05-18 22:01rqueraltaAssigned ToRetail => rqueralta
2022-05-18 22:01rqueraltaStatusnew => scheduled
2022-05-23 15:36hgbotNote Added: 0137639
2022-05-23 15:37hgbotNote Added: 0137640
2022-06-09 07:44hgbotResolutionopen => fixed
2022-06-09 07:44hgbotStatusscheduled => closed
2022-06-09 07:44hgbotNote Added: 0138185
2022-06-09 07:44hgbotNote Added: 0138186
2022-06-09 07:44hgbotNote Added: 0138187
2022-06-09 07:44hgbotNote Added: 0138188

Notes
(0137639)
hgbot   
2022-05-23 15:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/merge_requests/9 [^]
(0137640)
hgbot   
2022-05-23 15:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/10 [^]
(0138185)
hgbot   
2022-06-09 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons [^]
Changeset: f2bdc0690fc368ac6d069bf8e1fd3c677cb4db0a
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 09-06-2022 05:44:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/commit/f2bdc0690fc368ac6d069bf8e1fd3c677cb4db0a [^]

Fixed BUG-49325: Added verification for check numbers

---
M web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js
---
(0138186)
hgbot   
2022-06-09 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.digitalcoupons/-/merge_requests/9 [^]
(0138187)
hgbot   
2022-06-09 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^]
Changeset: ec50e30f24094685a2f1d6ce9cac59d3dc7e865f
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 19-05-2022 15:13:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/ec50e30f24094685a2f1d6ce9cac59d3dc7e865f [^]

Fixed BUG-49325: Added verification for used digital coupons

---
M web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
---
(0138188)
hgbot   
2022-06-09 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/10 [^]