Openbravo Issue Tracking System - Retail Modules
View Issue Details
0049313Retail ModulesWeb POSpublic2022-05-12 18:222022-06-09 10:55
tristan_coussaert 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
30Openbravo Appliance 14.04
 
 
approved
Gold
42124
No
0049313: Latency when paying with a giftcard with a lot of transactions
Hello,

It seems that in 20Q2 release there is some latency for the debit line of the amount of the giftcard to appear when choosing a giftcard with a lot of transactions as a payment method.

When reading the giftcard before paying (FindGiftCard) there is a line fetching all the information about the giftcard (the transactions are included).
 
It cause some latency because there are probably additional request being played and useless json being created.

In FindGiftCard class :

JSONObject jsongiftcard = toJsonConverter.toJsonObject(giftcard, DataResolvingMode.FULL);

The problem was reproductible in 20Q2 release (calinauto test)
On the Webpos,
Add a product to the basket
Click on Checkout
Click on More...
Click on Gift Card
Click on Pay Total
Enter a giftcard number with a lot of transactions
Click on Apply
Process is slow

If you do the same operation with a giftcard with few transactions, it will be much faster
No tags attached.
Issue History
2022-05-12 18:22tristan_coussaertNew Issue
2022-05-12 18:22tristan_coussaertAssigned To => Retail
2022-05-12 18:22tristan_coussaertOBNetwork customer => No
2022-05-12 18:22tristan_coussaertTriggers an Emergency Pack => No
2022-05-19 10:17egoitzOBNetwork customerNo => Gold
2022-05-19 10:17egoitzProjectPOS2 => Retail Modules
2022-05-19 10:18egoitzCategoryPOS => Web POS
2022-05-19 10:18egoitzSupport ticket => 42124
2022-05-31 10:00ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-05-31 12:04ranjith_qualiantech_comStatusnew => scheduled
2022-06-01 12:15hgbotMerge Request Status => open
2022-06-01 12:15hgbotNote Added: 0137937
2022-06-09 10:54hgbotMerge Request Statusopen => approved
2022-06-09 10:55hgbotResolutionopen => fixed
2022-06-09 10:55hgbotStatusscheduled => closed
2022-06-09 10:55hgbotNote Added: 0138198
2022-06-09 10:55hgbotNote Added: 0138199

Notes
(0137937)
hgbot   
2022-06-01 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/124 [^]
(0138198)
hgbot   
2022-06-09 10:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 5428a68d6408c9f492f4c4d6a1e08a67de2c18ea
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 09-06-2022 08:54:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/5428a68d6408c9f492f4c4d6a1e08a67de2c18ea [^]

Fixed ISSUE-49313: Update DataToJsonConverter to skip OneToMany property for improving performance

---
M src/org/openbravo/retail/giftcards/DataToJsonConverterExt.java
M src/org/openbravo/retail/giftcards/FindGiftCard.java
---
(0138199)
hgbot   
2022-06-09 10:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/124 [^]