Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049308Openbravo LocalizationsLocalization Italypublic2022-05-12 13:132022-05-24 09:35
ReporterXABIER_AGUADO 
Assigned Toigor_trebol 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusmerged
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customerGold
Regression introduced in release
Summary0049308: RT Printer - Fiscal department /index does not allow edits
DescriptionIf I want to update / edit a Fiscal department /index created by a different user it wont let us save the changes.


Steps To ReproduceGo to Tax Rates window --> Filter by 'Organization = Italy'
Try editing the fiscal department/index of:
-Iva 22 Vendite
-Iva 10 Vendite
-Iva 4 Vendite
It wont let us change any of them. Both fields, Fiscal department and fiscal index, neeed to be fully configurable.
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Filespng Screenshot from 2022-05-12 11-05-21.png (104,178) 2022-05-18 12:46
https://issues.openbravo.com/file_download.php?file_id=17031&type=bug
png

png Screenshot from 2022-05-12 11-06-27.png (49,338) 2022-05-18 12:46
https://issues.openbravo.com/file_download.php?file_id=17032&type=bug
png

png Screenshot from 2022-05-12 11-07-44.png (38,526) 2022-05-18 12:46
https://issues.openbravo.com/file_download.php?file_id=17033&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-05-12 13:13XABIER_AGUADONew Issue
2022-05-12 13:13XABIER_AGUADOAssigned To => psanjuan
2022-05-12 13:13XABIER_AGUADOOBNetwork customer => No
2022-05-12 13:56rafarodaTag Attached: NOR
2022-05-16 09:27psanjuanNote Added: 0137303
2022-05-16 09:27psanjuanAssigned Topsanjuan => XABIER_AGUADO
2022-05-16 09:27psanjuanStatusnew => feedback
2022-05-18 12:46sebastien_lironFile Added: Screenshot from 2022-05-12 11-05-21.png
2022-05-18 12:46sebastien_lironFile Added: Screenshot from 2022-05-12 11-06-27.png
2022-05-18 12:46sebastien_lironFile Added: Screenshot from 2022-05-12 11-07-44.png
2022-05-18 12:48sebastien_lironNote Added: 0137422
2022-05-18 12:49sebastien_lironAssigned ToXABIER_AGUADO => psanjuan
2022-05-18 12:49sebastien_lironStatusfeedback => new
2022-05-18 14:26psanjuanOBNetwork customerNo => Gold
2022-05-18 14:26psanjuanAssigned Topsanjuan => aferraz
2022-05-20 09:06aferrazAssigned Toaferraz => igor_trebol
2022-05-23 15:03hgbotMerge Request Status => open
2022-05-23 15:03hgbotNote Added: 0137635
2022-05-24 09:31hgbotMerge Request Statusopen => merged
2022-05-24 09:31hgbotNote Added: 0137661
2022-05-24 09:31hgbotResolutionopen => fixed
2022-05-24 09:31hgbotStatusnew => resolved
2022-05-24 09:31hgbotNote Added: 0137662
2022-05-24 09:32hgbotNote Added: 0137663
2022-05-24 09:33hgbotNote Added: 0137665
2022-05-24 09:35aferrazStatusresolved => closed

Notes
(0137303)
psanjuan   
2022-05-16 09:27   
Hello Xabier, as you know we can not reproduce this bug in any of our environments.
Please review your enviroment.
(0137422)
sebastien_liron   
2022-05-18 12:48   
The saft tax code value are these.

 Screenshot from 2022-05-12 11-05-21.png

if this field is not set (empty), then you won’t be able to change the row, since the value is not correct but mandatory :

  Screenshot from 2022-05-12 11-06-27.png


this field should be editable in the Portuguese configuration section , but since you are on an org without the Portuguese flag, you won’t be able to see it.


Screenshot from 2022-05-12 11-07-44.png

So my recommandation is to delete this wrongly set tax rate OR to remove the display logic on the saft tax code since it is keeping other country from working well OR to remove the mandatory and change it by an event handler
(0137635)
hgbot   
2022-05-23 15:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/32 [^]
(0137661)
hgbot   
2022-05-24 09:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/32 [^]
(0137662)
hgbot   
2022-05-24 09:31   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: 60c0b675cddf5763746a5ad75e950af41681a05d
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 24-05-2022 07:31:36
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/60c0b675cddf5763746a5ad75e950af41681a05d [^]

Fixes ISSUE-49308: Set Tax Code as non-mandatory and added a check so it cannot be null if the organization is Portuguese

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/com/practicsbs/saftpt/handler/SaftTaxRateFieldsHandler.java
---
(0137663)
hgbot   
2022-05-24 09:32   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: 37f4859fffc1bc95fbf6fd6adfbf6462a395d71d
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 24-05-2022 07:32:38
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/37f4859fffc1bc95fbf6fd6adfbf6462a395d71d [^]

Fixes ISSUE-49308: Set Tax Code as non-mandatory and added a check so it cannot be null if the organization is Portuguese


(cherry picked from commit 60c0b675cddf5763746a5ad75e950af41681a05d)
---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/com/practicsbs/saftpt/handler/SaftTaxRateFieldsHandler.java
---
(0137665)
hgbot   
2022-05-24 09:33   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: 39de65ddcec21cb9845f5d3a99f64672d8ccfaf4
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 24-05-2022 07:33:54
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/39de65ddcec21cb9845f5d3a99f64672d8ccfaf4 [^]

Fixes ISSUE-49308: Set Tax Code as non-mandatory and added a check so it cannot be null if the organization is Portuguese


(cherry picked from commit 60c0b675cddf5763746a5ad75e950af41681a05d)
---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/com/practicsbs/saftpt/handler/SaftTaxRateFieldsHandler.java
---