Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
0049307Openbravo LocalizationsLocalization Portugalpublic2022-05-12 12:182022-08-22 11:47
ucarrion 
igor_trebol 
highmajoralways
closedfixed 
5
 
 
0049307: Cannot login into a Portuguese terminal if there's no return prefix defined
If you set a prefix as empty for any Portuguese configured touchpoint and, given a situation, you deactivate it and activate it back, then you get a popup in the loading screen telling that there's a prefix missing (as if it was null).

If there's a null prefix defined at touchpoint level, the user will never by able to login. This has no sense if there are document types not communicated to SAFT (so, no SAFT signed).
Preconditions: to select a touchpoint that is into an organization Portuguese configured.

-Set the returndocno_prefix as empty ( '' ) for the mentioned till
-Do login on the till: normally everything works fine
-Deactivate the till into the backoffice. Save
-Activate it back. Save
-Try to do login again, a popup appears because of that null value.
Only the prefixes for the doctypes marked as 'Is SAFT signed' in c_doctype should be considered when doing this control on the login.
NOR
Issue History
2022-05-12 12:18ucarrionNew Issue
2022-05-12 12:18ucarrionAssigned To => psanjuan
2022-05-12 12:22rafarodaTag Attached: NOR
2022-05-16 12:12psanjuanNote Added: 0137314
2022-05-16 12:19psanjuanNote Edited: 0137314bug_revision_view_page.php?bugnote_id=0137314#r24096
2022-05-16 12:19psanjuanAssigned Topsanjuan => aferraz
2022-06-16 12:15ucarrionSummaryReturn docno prefix set as null when deactivating the touchpoint => Cannot login into a Portuguese terminal if there's no return prefix defined
2022-06-16 12:15ucarrionDescription Updatedbug_revision_view_page.php?rev_id=24299#r24299
2022-06-16 12:15ucarrionProposed Solution updated
2022-07-12 17:32aferrazAssigned Toaferraz => igor_trebol
2022-07-19 15:08ucarrionNote Added: 0139428
2022-08-10 14:26hgbotNote Added: 0140047
2022-08-11 07:53jorge-garciaStatusnew => scheduled
2022-08-22 11:46hgbotResolutionopen => fixed
2022-08-22 11:46hgbotStatusscheduled => closed
2022-08-22 11:46hgbotNote Added: 0140285
2022-08-22 11:46hgbotNote Added: 0140286
2022-08-22 11:47hgbotNote Added: 0140287

Notes
(0137314)
psanjuan   
2022-05-16 12:12   
(edited on: 2022-05-16 12:19)
When the value is left empty in Openbravo backoffice, it is shown as "Null" in DB while it should be "empty".

Besides that, and as a consequence of the above, at the time of login in the POS, an error message saying:

Error
There was an error loading the POS Terminal. There are empty Terminal Prefixes and all must be defined.

This error message should not appear in case no prefix is configured for a document configured as "Is SAFT signed" = NO.

(0139428)
ucarrion   
2022-07-19 15:08   
After a discussion with Álvaro, we decided to postpone the due date one month because the issue has a workaround (just run an script) and in terms of Norauto PROD there will not be more stores joining in PROD until September as the soonest.
(0140047)
hgbot   
2022-08-10 14:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/58 [^]
(0140285)
hgbot   
2022-08-22 11:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 60948dc447a0f28aeedb4d226481ffdf9e75e7aa
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 22-08-2022 09:46:36
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/60948dc447a0f28aeedb4d226481ffdf9e75e7aa [^]

Fixes ISSUE-49307: Empty prefixes only block login if the corresponding document is saft signed

---
M src/com/practicsbs/saftpt/retail/SaftrInitialValidations.java
---
(0140286)
hgbot   
2022-08-22 11:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/58 [^]
(0140287)
hgbot   
2022-08-22 11:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: f6445116dd44146e9103aa36138ff121b209a287
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 22-08-2022 09:47:24
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/f6445116dd44146e9103aa36138ff121b209a287 [^]

Fixes ISSUE-49307: Empty prefixes only block login if the corresponding document is saft signed


(cherry picked from commit 60948dc447a0f28aeedb4d226481ffdf9e75e7aa)
---
M src/com/practicsbs/saftpt/retail/SaftrInitialValidations.java
---