Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049229Openbravo LocalizationsLocalization Portugalpublic2022-05-05 13:272022-07-13 12:21
Reporterpsanjuan 
Assigned Toigor_trebol 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customer
Regression introduced in release
Summary0049229: The simplified invoices must comply with nº 1 of art 40 of CIVA.
DescriptionThe simplified invoices must comply with nº 1 of art 40 of CIVA.

The software must know which type of business the user has, to be able to issue compliant documents (the value is controlled by NetTotal);
Steps To Reproducen/A
Proposed SolutionAdjust PT certification Code (Simplified Invoice Threshold) to new Business Partner Type field (see JIRA RM- 547), therefore for the "Identified" customers":
* if "Company" business partner type is configured, simplified invoice threshold is 100,00€
* if "Individuals" bp type is configured, simplified invoice threshold is 1000.00€

Same way in those case where an not identified customer (anonymous) customer buys a product and gives his/her NIF in the "Tax ID pop up" the existing logic must be adapted.
* if the tax id enters by 1,2 and 3, the BP can be considered as an "individual", simplified invoice threshold is 1000,00€
* if the tax id entered is 5 or 6, the BP can be considered as a "company", simplified invoice threshold is 100,00€
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0047952 closed ruben_jimenez Openbravo ERP There should be a way to distinguish persons/individuals from companies. 
depends on defect 0049714 closed ruben_jimenez Openbravo ERP New name and Help and description required for the new field "Business Partner Type", and POS label 
related to feature request 0049537 scheduled igor_trebol Openbravo Localizations Define threshold value preferences 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-05 13:27psanjuanNew Issue
2022-05-05 13:27psanjuanAssigned To => psanjuan
2022-05-16 12:01psanjuanRelationship addedrelated to 0047952
2022-05-18 13:47psanjuanProposed Solution updated
2022-05-18 13:49psanjuanProposed Solution updated
2022-05-18 13:50psanjuanProposed Solution updated
2022-05-18 14:05psanjuanNote Added: 0137430
2022-05-18 14:21aferrazNote Added: 0137434
2022-05-18 15:07aferrazNote Edited: 0137434bug_revision_view_page.php?bugnote_id=0137434#r24115
2022-06-06 10:52aferrazRelationship replaceddepends on 0047952
2022-06-10 15:44hgbotNote Added: 0138278
2022-06-13 12:03hgbotNote Added: 0138298
2022-06-13 12:51igor_trebolRelationship addedrelated to 0049537
2022-06-20 13:38aferrazTypedesign defect => feature request
2022-06-20 16:34hgbotResolutionopen => fixed
2022-06-20 16:34hgbotStatusnew => closed
2022-06-20 16:34hgbotNote Added: 0138572
2022-06-20 16:34hgbotNote Added: 0138573
2022-06-20 16:51hgbotNote Added: 0138577
2022-06-20 16:51hgbotNote Added: 0138578
2022-06-27 11:49hgbotNote Added: 0138778
2022-07-05 09:52aferrazAssigned Topsanjuan => igor_trebol
2022-07-13 12:20hgbotNote Added: 0139297
2022-07-13 12:20hgbotNote Added: 0139299
2022-07-13 12:21aferrazRelationship addeddepends on 0049714

Notes
(0137430)
psanjuan   
2022-05-18 14:05   
Related to Jira https://openbravo.atlassian.net/browse/RM-564 [^] [^]
(0137434)
aferraz   
2022-05-18 14:21   
(edited on: 2022-05-18 15:07)
Remove OBSIT_CheckTaxableCustomer hook from https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold [^] and use new legal customer type instead implemented in 0047952.

Module https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold.pt_PT [^] won't be needed anymore.

Set legal customer type to ticket business partner, together with taxId (0048874), from Customer Tax ID popup in https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/ [^]
(0138278)
hgbot   
2022-06-10 15:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold/-/merge_requests/11 [^]
(0138298)
hgbot   
2022-06-13 12:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/54 [^]
(0138572)
hgbot   
2022-06-20 16:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 1864f7f87f51b3f584a19132f402b876a812545a
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 20-06-2022 14:34:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/1864f7f87f51b3f584a19132f402b876a812545a [^]

Fixes ISSUE-49229: Customer tax id pop-up now sets the legal customer type for anonymous clients

---
M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js
---
(0138573)
hgbot   
2022-06-20 16:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/54 [^]
(0138577)
hgbot   
2022-06-20 16:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold [^]
Changeset: d2b3b89dbd9526c8cbb8bd2b6e581b00e223b6b5
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 20-06-2022 14:51:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold/-/commit/d2b3b89dbd9526c8cbb8bd2b6e581b00e223b6b5 [^]

FIXES ISSUE-49229: Thresholds now use the BP's Legal Customer Type field to check if they are taxable

---
M web/org.openbravo.retail.simpinvoicethreshold/js/prePaymentHook.js
---
(0138578)
hgbot   
2022-06-20 16:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold/-/merge_requests/11 [^]
(0138778)
hgbot   
2022-06-27 11:49   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 2bdf27f89eacbfd937f5b767caf7dab2353f8d23
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 27-06-2022 11:49:35
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/2bdf27f89eacbfd937f5b767caf7dab2353f8d23 [^]

Related to ISSUE-49229: Remove simplified invoice threshold selenium test suite as this module is automated using jest tests

---
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/suites/concurrent/job014/SimplifiedInvoiceThresholdSuite.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/suites/concurrent/job014/SimplifiedInvoiceThresholdSuiteHV.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/siinvoicethreshold/AllSimplifiedInvoiceThresholdTests.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/siinvoicethreshold/AllSimplifiedInvoiceThresholdTestsHV.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/siinvoicethreshold/SimplifiedInvoiceThresholdTest.java
R src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/siinvoicethreshold/SimplifiedInvoiceThresholdTestHelper.java
---
(0139297)
hgbot   
2022-07-13 12:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold [^]
Changeset: 2026532656f7caf06e81044e8bfa3827ea0b3020
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 13-07-2022 10:20:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.simpinvoicethreshold/-/commit/2026532656f7caf06e81044e8bfa3827ea0b3020 [^]

Related to ISSUE-49229: Renamed legalCustomerType property as businessPartnerType done in 0049714

---
M web-test/model/business-object/ticket/TicketUtils-isBusinessPartnerTaxable.test.js
M web/org.openbravo.retail.simpinvoicethreshold/app/model/business-object/ticket/TicketUtils.js
---
(0139299)
hgbot   
2022-07-13 12:20   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 309e87cfa4af9df69eb22d8766d3b585ff93cf66
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 13-07-2022 10:20:46
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/309e87cfa4af9df69eb22d8766d3b585ff93cf66 [^]

Related to ISSUE-49229: Renamed legalCustomerType property as businessPartnerType done in 0049714

---
M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js
---