Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049204Retail ModulesDiscounts and Promotionspublic2022-05-04 09:592022-08-01 10:23
Reporterrfacon 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049204: Modifying the Availibility subtab doesn't update the discount audit section
DescriptionModifying the Availibility subtab doesn't update the discount audit section
Steps To Reproduce1. Configure a discount in the Backend, for example:
- Discount/Promotion Type: Price adjustment
- Active = Y
- Define the discount for a product, for example Baby carrier and select "Included Products" = Only those defined.

2. Check the updated date put in the audit section

3. In the subtab 'Availability' add a row: define 'All week' for example

4. Click on the main tab of the discount and refresh the form, you will see that the Updated date hasen't changed. Date is not modified also in case of deleting a row in the 'Availability' subtab
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0049195 closed radhakrishnan Availability subtab records can be deleted 
related to defect 0049194 closed radhakrishnan Discount availability should be validated with POS time instead of server time 
related to feature request 0048383pi closed jetxarri Allow to activate promotions on 2 distinct time slots within the same day 
related to defect 0049518 closed radhakrishnan API call - A promotion with an availability set on the last hours of a day is also applied on the last hours of the day before 
related to defect 0049517 closed radhakrishnan API call - Availability of a promotion is calculated on universal time by the API 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-04 09:59rfaconNew Issue
2022-05-04 09:59rfaconAssigned To => Retail
2022-05-04 09:59rfaconTriggers an Emergency Pack => No
2022-05-04 10:28rafarodaTag Attached: NOR
2022-05-04 10:28rafarodaRelationship addedrelated to 0049195
2022-05-04 10:28rafarodaRelationship addedrelated to 0049194
2022-05-04 10:29rafarodaRelationship addeddepends on 0048383
2022-05-04 10:29rafarodaRelationship deleteddepends on 0048383
2022-05-04 10:29rafarodaRelationship addedrelated to 0048383
2022-05-04 10:30rafarodaTypebackport => defect
2022-06-07 21:45rafarodaIssue Monitored: rafaroda
2022-06-08 15:37radhakrishnanAssigned ToRetail => radhakrishnan
2022-06-09 07:41radhakrishnanStatusnew => scheduled
2022-06-09 23:43rafarodaRelationship addedrelated to 0049518
2022-06-09 23:43rafarodaRelationship addedrelated to 0049517
2022-07-04 09:08aaroncaleroNote Added: 0138996
2022-07-04 09:08aaroncaleroAssigned Toradhakrishnan => rafaroda
2022-07-04 09:08aaroncaleroStatusscheduled => feedback
2022-07-08 15:06rafarodaNote Added: 0139211
2022-07-08 15:07rafarodaAssigned Torafaroda => aaroncalero
2022-08-01 06:24marvintmStatusfeedback => scheduled
2022-08-01 06:24marvintmAssigned Toaaroncalero => ranjith_qualiantech_com
2022-08-01 10:23marvintmReview Assigned To => marvintm
2022-08-01 10:23marvintmNote Added: 0139759
2022-08-01 10:23marvintmStatusscheduled => closed
2022-08-01 10:23marvintmResolutionopen => unable to reproduce

Notes
(0138996)
aaroncalero   
2022-07-04 09:08   
This is the default behaviour of all windows/tables across all the application.
When you change a value of a child tab, only the audit fields of said tab are updated.

Is there any reason to require the discount header to be updated when changing any of its child tabs?
(0139211)
rafaroda   
2022-07-08 15:06   
Hi Aaron: in Live Builds updating child tabs in Product window or Discounts & Promotion window does update the header UPDATED field https://drive.google.com/file/d/1I_Qyde0C7AmH0vcnt4QXHbsIK3ArpOGc/view?usp=sharing [^]

For Availability tab to update Discounts & Promotion window UPDATED field: the interest is that an incremental master data refresh does update the promotion in POS
(0139759)
marvintm   
2022-08-01 10:23   
The availability of the discount is managed in a separate master data model. Therefore, there is no need to update the product header audit information. In our tests, we didn't manage to find any problems with it, either in full refresh or incremental refresh changes.

Regarding the comment from Rafa, the reason in live builds the changes in some filters causes changes in the audit info of the discounts main entity is that the Magento integration module is installed, and there is a trigger that causes this. This should not be needed in general for the data refresh to work correctly.