Openbravo Issue Tracking System - POS2
View Issue Details
0049197POS2Restaurantspublic2022-05-03 15:402022-06-07 19:46
timothee_catteeuw 
AtulOpenbravo 
normalmajoralways
closedfixed 
5
 
 
No
0049197: JIRA 2934 - Verified return has to call EcranCuissonService.svc/rest/AnnulerCommande when product is linked to pager
In restaurant context sometimes a product can be a pager product. When this kind of product is included in the basket, after paying a WS call to a pager server is done, ex : http://127.0.0.1/EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI [^]

This call inform the cooker working in the kitchen.

But the customer can ask the cashier to cancel his order containing the previous product. In that case it is necessary to call again the pager server, ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^]

Nowadays this call is only implemented when an order is cancel and replace.

The request here is to implement that also when doing a verified return, because this option will be also selected by the cashier in order to return a product and this product can be a pager product.
Case 1 :

Do a ticket including a pager product

Pay it

Check WS calls done from the till, this call is done for the pager product, EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI

go to sales history on WebPos

search for the order you previously done and select the verified return option

select the pager product and valid

click on reimburse button

→ KO, no call is done for the pager product which was returned

It is necessary to call the pager server with the numéro de commande linked to the product (ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^])

As a reminder Numéro de commande =
POS Number + 'D' + Ticket nmuber + 'D' + Product line number in the order

Example = 50069D651D0

Case 2 :

Do a ticket including several pager products

Pay it

Check WS calls done from the till, several calls are done (1 by pager product) EcranCuissonService.svc/rest/AjouterNouvelleCommandeWI

go to sales history on WebPos

search for the order you previously done and select the verified return option

select all the products in the ticket and valid

click on reimburse button

→ KO, no call is done for the pager products which were returned

It is necessary to call the pager server for each product with the linked numéro de commande (ex : http://127.0.0.1/EcranCuissonService.svc/rest/AnnulerCommande/50069D651D0 [^])

As a reminder Numéro de commande =
POS Number + 'D' + Ticket nmuber + 'D' + Product line number in the order

Example = 50069D651D0
No tags attached.
Issue History
2022-05-03 15:40timothee_catteeuwNew Issue
2022-05-03 15:40timothee_catteeuwAssigned To => Retail
2022-05-03 15:40timothee_catteeuwTriggers an Emergency Pack => No
2022-05-12 23:21mtaalAssigned ToRetail => AtulOpenbravo
2022-05-16 20:04mtaalAssigned ToAtulOpenbravo => mtaal
2022-05-16 20:06mtaalAssigned Tomtaal => AtulOpenbravo
2022-05-25 13:46AtulOpenbravoStatusnew => scheduled
2022-06-02 14:18hgbotNote Added: 0137988
2022-06-06 22:41hgbotNote Added: 0138099
2022-06-07 19:32hgbotNote Added: 0138131
2022-06-07 19:41hgbotNote Added: 0138132
2022-06-07 19:41hgbotNote Added: 0138133
2022-06-07 19:45hgbotNote Added: 0138134
2022-06-07 19:45hgbotNote Added: 0138135
2022-06-07 19:46hgbotNote Added: 0138136
2022-06-07 19:46hgbotResolutionopen => fixed
2022-06-07 19:46hgbotStatusscheduled => closed
2022-06-07 19:46hgbotNote Added: 0138137

Notes
(0137988)
hgbot   
2022-06-02 14:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/38 [^]
(0138099)
hgbot   
2022-06-06 22:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/992 [^]
(0138131)
hgbot   
2022-06-07 19:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/151 [^]
(0138132)
hgbot   
2022-06-07 19:41   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 01eb2012c0f6e3e5151abfa625de95e496662c0f
Author: Martin Taal <martin.taal@openbravo.com>
Date: 07-06-2022 17:41:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/01eb2012c0f6e3e5151abfa625de95e496662c0f [^]

Related to ISSUE-49197: use the correct property names in the menu item and implement clear dcm info in the pickuphandler

---
M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java
M web-jspack/org.openbravo.pos2.restaurant/src/core/pickupPoint/RestaurantPickupHandler.js
---
(0138133)
hgbot   
2022-06-07 19:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/151 [^]
(0138134)
hgbot   
2022-06-07 19:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 2134acc563a4dfbc84d51bc9e170a07d2963da4f
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 07-06-2022 17:45:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/2134acc563a4dfbc84d51bc9e170a07d2963da4f [^]

Related to BUG-49197: Add lineNo information when adding verified return ticket line.

---
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
---
(0138135)
hgbot   
2022-06-07 19:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/38 [^]
(0138136)
hgbot   
2022-06-07 19:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/992 [^]
(0138137)
hgbot   
2022-06-07 19:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: adee2d302ab92df178a36a545ebda7d75fd9a4c2
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 07-06-2022 17:46:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/adee2d302ab92df178a36a545ebda7d75fd9a4c2 [^]

Fixes BUG-49197: JIRA 2934 - Verified return has to call EcranCuissonService.svc/rest/AnnulerCommande when product is linked to pager

---
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/PickupHandler.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/DCMController.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/__test__/PagerDeliveryControlMethod.test.js
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/registerDeliveryControlMethods.js
---