Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049194Retail ModulesDiscounts and Promotionspublic2022-05-03 14:272022-06-23 12:26
Reporterrfacon 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049194: Discount availability should be validated with POS time instead of server time
DescriptionDiscount availability should be validated with POS time instead of server time
Steps To Reproduce1. Configure a discount in the Backend, for example:
- Discount/Promotion Type: Price adjustment
- Active = Y
- Availability subtab: Monday and Tuesday (do not inform the fields "Starting Time" and "Ending Time").
- Define the discount for a product, for example Baby carrier and select "Included Products" = Only those defined.

2. Open a terminal on Monday and verify that the discount is applied correctly to the "Baby Carrier" product.

3. In the Backend, open the discount defined in point 1, and inform:
- Availability: Tuesday -> "Starting Time" Tuesday = 8:00:00 and "Ending Time" Tuesday =18:05:00

Result: Open the terminal again the next Tuesday and verify that the discount is not applied to the "Baby Carrier" product.
Proposed Solution
Additional Information
TagsNOR
Relationships
related to feature request 0048383pi closed jetxarri Allow to activate promotions on 2 distinct time slots within the same day 
related to defect 0049204 closed ranjith_qualiantech_com Modifying the Availibility subtab doesn't update the discount audit section 
related to defect 0049195 closed radhakrishnan Availability subtab records can be deleted 
related to defect 0049518 closed radhakrishnan API call - A promotion with an availability set on the last hours of a day is also applied on the last hours of the day before 
related to defect 0049517 closed radhakrishnan API call - Availability of a promotion is calculated on universal time by the API 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-03 14:27rfaconNew Issue
2022-05-03 14:27rfaconAssigned To => Retail
2022-05-03 14:27rfaconTriggers an Emergency Pack => No
2022-05-04 10:28rafarodaRelationship addedrelated to 0049204
2022-05-04 10:28rafarodaRelationship addedrelated to 0049195
2022-05-04 10:29rafarodaRelationship addedrelated to 0048383
2022-05-04 10:29rafarodaTag Attached: NOR
2022-05-04 10:30rafarodaTypebackport => defect
2022-06-07 21:44rafarodaIssue Monitored: rafaroda
2022-06-08 16:10radhakrishnanAssigned ToRetail => radhakrishnan
2022-06-09 15:03radhakrishnanStatusnew => scheduled
2022-06-09 23:45rafarodaRelationship addedrelated to 0049518
2022-06-09 23:45rafarodaRelationship addedrelated to 0049517
2022-06-21 08:23hgbotNote Added: 0138589
2022-06-23 12:26hgbotNote Added: 0138685
2022-06-23 12:26hgbotResolutionopen => fixed
2022-06-23 12:26hgbotStatusscheduled => closed
2022-06-23 12:26hgbotFixed in Version => RR22Q3
2022-06-23 12:26hgbotNote Added: 0138686

Notes
(0138589)
hgbot   
2022-06-21 08:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/57 [^]
(0138685)
hgbot   
2022-06-23 12:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/57 [^]
(0138686)
hgbot   
2022-06-23 12:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 641202873812c8e322ce8b6b3280e47c8a3c9ff4
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 21-06-2022 11:43:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/641202873812c8e322ce8b6b3280e47c8a3c9ff4 [^]

Fixed ISSUE-49194: Updated validation in Discount availability
Discount availability time should be validated with POS time instead of server time

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---