Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049181POS2Restaurantspublic2022-05-02 11:562022-05-27 15:37
Reporterjavietxe 
Assigned Tosntgreale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049181: FLUN-2936: Menu Items without prices are being shown
DescriptionIf a product configured as Menu Item is in the assortment, it is being shown as eligible no matter if it has an active price or not.

It must have a price in order to be selectable as menu item.
Steps To ReproducePrerequisites:

-Have a menu configured with different menu items in order to be sold in the POS (all the menu items in the assortment and in the pricelists, with active prices).

Steps:
- Log in the POS
- Select the menu: check that all the menu items are present to select them.
- Cancel the order and close the till
- Log in the backoffice
- Deactivate the price of one of the menu items
- Log in the POS again
- Refresh master data
- Select the menu and check that the menu item with the not active price is still present.


Update:

After check seems that working with several price lists/schemas/keymaps products are shown when they are part of the main price list even when adding the menu through a schema which is using a price list without this product
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-02 11:56javietxeNew Issue
2022-05-02 11:56javietxeAssigned To => Retail
2022-05-02 11:56javietxeTriggers an Emergency Pack => No
2022-05-02 18:42guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24001#r24001
2022-05-03 18:37hgbotNote Added: 0136914
2022-05-11 21:09sntgrealeAssigned ToRetail => sntgreale
2022-05-11 21:09sntgrealeStatusnew => acknowledged
2022-05-12 13:43sntgrealeStatusacknowledged => scheduled
2022-05-27 15:37hgbotResolutionopen => fixed
2022-05-27 15:37hgbotStatusscheduled => closed
2022-05-27 15:37hgbotNote Added: 0137825
2022-05-27 15:37hgbotNote Added: 0137826
2022-05-27 15:37hgbotNote Added: 0137827
2022-05-27 15:37hgbotNote Added: 0137828
2022-05-27 15:37hgbotNote Added: 0137829
2022-05-27 15:37hgbotNote Added: 0137830

Notes
(0136914)
hgbot   
2022-05-03 18:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/137 [^]
(0137825)
hgbot   
2022-05-27 15:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: f1e8cf285095fd8fa5866585d171eb31a84301a8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 27-05-2022 15:30:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/f1e8cf285095fd8fa5866585d171eb31a84301a8 [^]

fixed ISSUE-49181: Menu wizard will not show menu items which are not part of the pricelist of the current schema

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductKeymapLayout.jsx
---
(0137826)
hgbot   
2022-05-27 15:37   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 43cb68b4d4ee7fc01854ed9cdb07e9bfe6623d67
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 27-05-2022 15:30:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/43cb68b4d4ee7fc01854ed9cdb07e9bfe6623d67 [^]

related to ISSUE-49181: Use filter and map instead of reduce

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductKeymapLayout.jsx
---
(0137827)
hgbot   
2022-05-27 15:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 26ae19edf39df7ba08cbf4c888fc830f92937ba9
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 27-05-2022 15:30:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/26ae19edf39df7ba08cbf4c888fc830f92937ba9 [^]

Fixes ISSUE-49181: Add mock schema and terminal to the test.

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/__test__/MenuWizardProductKeymapLayout.test.jsx
---
(0137828)
hgbot   
2022-05-27 15:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 9f3bb04fbc3d6581b1ff4f7148d871d4b9de1e02
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 27-05-2022 15:30:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/9f3bb04fbc3d6581b1ff4f7148d871d4b9de1e02 [^]

Fixes ISSUE-49181: Add mock schema, terminal and ticket to the test.

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/__test__/MenuWizardProductKeymapLayout.test.jsx
---
(0137829)
hgbot   
2022-05-27 15:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 6b3c9cdb5e9ce000ed06d02067653e14ce4ff844
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 27-05-2022 15:30:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/6b3c9cdb5e9ce000ed06d02067653e14ce4ff844 [^]

Fixes ISSUE-49181: Modification tests. Rearrangement of the affected stories.

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/__test__/MenuWizardProductKeymapLayout.test.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/stories/MenuWizardProductKeymapLayout.stories.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/__test__/MenuWizard.test.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/stories/MenuWizard.stories.jsx
---
(0137830)
hgbot   
2022-05-27 15:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/137 [^]