Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049170Openbravo ERPA. Platformpublic2022-04-29 07:382022-05-18 11:41
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049170: matchesObject should not compare array properties with strict equality
DescriptionGiven:

  json1 = { arrayProperty: [{p1: 'A', p2: 'B'}] }
  json2 = { arrayProperty: [{p1: 'A'}] }

Then:

  assertThat(json1, matchesObject(json2)) must be true.

But currently this is not being asserted correctly as it returns false.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0048373 closed caristu Provide test matchers for asserting JSON objects 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-04-29 07:38caristuNew Issue
2022-04-29 07:38caristuAssigned To => Triage Platform Base
2022-04-29 07:38caristuOBNetwork customer => No
2022-04-29 07:38caristuModules => Core
2022-04-29 07:38caristuTriggers an Emergency Pack => No
2022-04-29 07:39caristuAssigned ToTriage Platform Base => caristu
2022-04-29 07:47hgbotMerge Request Status => open
2022-04-29 07:47hgbotNote Added: 0136849
2022-04-29 07:48caristuStatusnew => scheduled
2022-04-29 07:48caristuDescription Updatedbug_revision_view_page.php?rev_id=23984#r23984
2022-04-29 07:48caristuDescription Updatedbug_revision_view_page.php?rev_id=23985#r23985
2022-04-29 07:48caristuDescription Updatedbug_revision_view_page.php?rev_id=23986#r23986
2022-05-04 13:09alostaleRelationship addedrelated to 0048373
2022-05-04 13:11hgbotMerge Request Statusopen => approved
2022-05-04 13:11hgbotResolutionopen => fixed
2022-05-04 13:11hgbotStatusscheduled => closed
2022-05-04 13:11hgbotFixed in Version => PR22Q3
2022-05-04 13:11hgbotNote Added: 0136934
2022-05-04 13:11hgbotNote Added: 0136935
2022-05-05 11:09caristuIssue cloned0049226
2022-05-05 11:09caristuRelationship addedrelated to 0049226
2022-05-18 11:41caristuRelationship deletedrelated to 0049226

Notes
(0136849)
hgbot   
2022-04-29 07:47   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/580 [^]
(0136934)
hgbot   
2022-05-04 13:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 92044af7d3b9bc3d71ad6b94f80f5404cf2b9e79
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 04-05-2022 08:26:11
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/92044af7d3b9bc3d71ad6b94f80f5404cf2b9e79 [^]

fixes BUG-49170: matchesObject shouldn't compare array props with strict equal

---
M src-test/src/org/openbravo/test/matchers/json/JSONMatcher.java
M src-test/src/org/openbravo/test/matchers/json/JSONMatchersTest.java
---
(0136935)
hgbot   
2022-05-04 13:11   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/580 [^]