Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
0049160Openbravo LocalizationsLocalization Spainpublic2022-04-28 09:562022-05-19 13:16
wicherr 
igor_trebol 
highmajoralways
closedfixed 
5
 
 
0049160: return tickets at 0€ are recorded as "Return Material Sales Invoice" but Invoice Type Key = Invoice
Return tickets at 0€ are recorded as "Return Material Sales Invoice" but Invoice Type Key = Invoice instead of :
- Invoice Type Key = "Corrective invoice"
- Rectification Invoice Type = "Difference"
- Rectification Reason = R1 or R5

So the sent to SII fails with the message : Si el documento de transacción es 'Reversed Invoice' la 'Clave tipo factura' NO puede ser 'Factura'.
- Create a return
- Put the product at 0€
- Invoice the ticket
- "Pay" and save
- Check the invoice
- Sent the invoice to SII
Fix the integration of the invoice checking the document type of the invoice also to fill the specific fields for SII

Scenario 3 - NOT CORRECT

- create a new sale, select the anonymous customer and enter a line.
- change the price of the product to 0
- Select the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Simplified Invoice has been created . SII Invoice Type = Simplified invoice - THIS IS NOT CORRECT IT SHOULD BE: invoice Type Key = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R5

Scenario 4 - NOT CORRECT

- create a new sale, select a customer and enter a line.
- change the price of the product to 0
- Use the option Issue Invoice
- Select also the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Invoice has been created. SII Invoice Type = invoice - THIS IS NOT CORRECT IT SHOULD BE: invoice Type Key = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R1
NOR
Issue History
2022-04-28 09:56wicherrNew Issue
2022-04-28 09:56wicherrAssigned To => psanjuan
2022-04-28 09:56wicherrTag Attached: NOR
2022-04-28 16:51psanjuanNote Added: 0136839
2022-04-28 16:57psanjuanNote Edited: 0136839bug_revision_view_page.php?bugnote_id=0136839#r23980
2022-04-28 16:57psanjuanProposed Solution updated
2022-04-28 17:39rafarodaIssue Monitored: rafaroda
2022-04-29 11:08psanjuanNote Added: 0136861
2022-05-03 10:09psanjuanNote Edited: 0136861bug_revision_view_page.php?bugnote_id=0136861#r24003
2022-05-03 15:58psanjuanNote Edited: 0136861bug_revision_view_page.php?bugnote_id=0136861#r24006
2022-05-03 15:58psanjuanAssigned Topsanjuan => vmromanos
2022-05-03 16:06psanjuanNote Edited: 0136861bug_revision_view_page.php?bugnote_id=0136861#r24007
2022-05-03 16:46vmromanosAssigned Tovmromanos => aferraz
2022-05-12 16:54aferrazAssigned Toaferraz => igor_trebol
2022-05-16 15:49igor_trebolNote Added: 0137341
2022-05-16 16:36hgbotNote Added: 0137342
2022-05-17 13:47hgbotResolutionopen => fixed
2022-05-17 13:47hgbotStatusnew => closed
2022-05-17 13:47hgbotNote Added: 0137382
2022-05-17 13:47hgbotNote Added: 0137383
2022-05-17 15:18hgbotNote Added: 0137390
2022-05-19 13:16psanjuanNote Added: 0137535

Notes
(0136839)
psanjuan   
2022-04-28 16:51   
(edited on: 2022-04-28 16:57)
Go to Web POS:

Scenario 1 - CORRECT

- create a new sale, select the anonymous customer and enter a line.
- change the price of the product to 0
- Complete the sale

In the backoffice: A VBS AR Simplified Invoice has been created. SII Invoice Type = Simplified invoice

Scenario 2 - CORRECT

- create a new sale, select a customer and enter a line.
- change the price of the product to 0
- Use the option Issue Invoice. Complete the sale

In the backoffice: A VBS AR Invoice has been created. SII Invoice Type = invoice

Scenario 3 - NOT CORRECT

- create a new sale, select the anonymous customer and enter a line.
- change the price of the product to 0
- Select the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Simplified Invoice has been created . SII Invoice Type = Simplified invoice - THIS IS NOT CORRECT IT SHOULD BE: invoice Type Key = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R5

Scenario 4 - NOT CORRECT

- create a new sale, select a customer and enter a line.
- change the price of the product to 0
- Use the option Issue Invoice
- Select also the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Invoice has been created. SII Invoice Type = invoice - THIS IS NOT CORRECT IT SHOULD BE: invoice Type Key = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R1

(0136861)
psanjuan   
2022-04-29 11:08   
(edited on: 2022-05-03 16:06)
Mix of positive and negative lines
Scenario 5 - CORRECT

- create a new sale, select an anonymous customer and enter two lines, each one for a given product.
- return one of them
- change the price of the both product lies to 0, so the total of the sale is 0,00
- Complete the sale

In the backoffice: A VBS AR Simplified Invoice has been created. SII Invoice Type = Simplified Invoice. THIS IS CORRECT.

Scenario 6 - CORRECT

- create a new sale, select a customer and enter two lines, each one for a given product.
- return one of them
- change the price of the both product lies to 0, so the total of the sale is 0,00
- use the option Issue Invoice.
- Complete the sale

In the backoffice: A VBS AR Invoice has been created. SII Invoice Type = Invoice. THIS IS CORRECT.

(0137341)
igor_trebol   
2022-05-16 15:49   
Test plan:

Beside the 6 scenarios presented in the ticket:

Scenario 7:

- create a new sale, select an anonymous customer and enter two lines, each one for a given product.
- return one of them
- change the price of the other one to match the value of the returned product, so the total is still 0
- Complete the sale

In the backoffice: A VBS AR Simplified Invoice has been created. SII Invoice Type = Simplified Invoice.

Scenario 8

- create a new sale, select a customer and enter two lines, each one for a given product.
- return one of them
- change the price of the other one to match the value of the returned product, so the total is still 0
- use the option Issue Invoice.
- Complete the sale

In the backoffice: A VBS AR Invoice has been created. SII Invoice Type = Invoice.

Scenario 9:

- create a new sale, select the anonymous customer and enter a line.
- Select the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Simplified Invoice has been created . SII Invoice Type = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R5

Scenario 10:

- create a new sale, select a customer and enter a line.
- Use the option Issue Invoice
- Select also the option "Return this Receipt" so the quantity of the order is negative.
- Complete the sale

In the backoffice: A VBS Reversed Sales Invoice has been created. SII Invoice Type = "Corrective Invoice" - "Rectification Invoice Type" = Differences and "Rectification Reason " R1
(0137342)
hgbot   
2022-05-16 16:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/4 [^]
(0137382)
hgbot   
2022-05-17 13:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: 7c3b2c8416c4d3f97e21c67201f052a223c657aa
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 17-05-2022 11:47:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/7c3b2c8416c4d3f97e21c67201f052a223c657aa [^]

Fixes ISSUE-49160: When creating an invoice for a return it now checks the transaction document, instead of the ammount to set up the SII type fields.

---
M src/org/openbravo/module/sii/retail/hook/SIIOrderLoaderHook.java
---
(0137383)
hgbot   
2022-05-17 13:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/4 [^]
(0137390)
hgbot   
2022-05-17 15:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: eb31217ef23ee01e6fdc4724f119ac96140a68b5
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 17-05-2022 15:17:12
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/eb31217ef23ee01e6fdc4724f119ac96140a68b5 [^]

Related to ISSUE-49160: update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0137535)
psanjuan   
2022-05-19 13:16   
Tested OK.