Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049123POS2POSpublic2022-04-25 19:442022-06-17 08:56
Reportergorka_gil 
Assigned Togorka_gil 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049123: Removing a filter in order selector doesn't reset the filter
DescriptionWhen removing a filter from orders selector it should reset its value and stop filtering by it
Steps To Reproduce- Login in the pos,
- go to orders,
- click on button 'add filter',
- select delivery status,
- select any delivery (for example 'delivered'),
- the grid will be filtered correctly,
- then click on X on the left of the delivery status filter to remove it,
- it will be correctly removed,
ERROR:
- the grid will continue filtered,
- and if added again the button it will continue with the same value
Proposed Solution
Additional Information
TagsFASH
Relationships
related to feature request 0049095 closed gorka_gil Show the customer activity 
related to defect 0049513 closed gorka_gil All filters from a filterable grid should be able to be reset 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-04-25 19:44gorka_gilNew Issue
2022-04-25 19:44gorka_gilAssigned To => Retail
2022-04-25 19:44gorka_gilOBNetwork customer => No
2022-04-25 19:44gorka_gilTriggers an Emergency Pack => No
2022-06-03 11:30gorka_gilRelationship addedrelated to 0049095
2022-06-08 18:03gorka_gilRelationship addedrelated to 0049513
2022-06-13 18:35hgbotMerge Request Status => open
2022-06-13 18:35hgbotNote Added: 0138323
2022-06-13 18:38gorka_gilAssigned ToRetail => gorka_gil
2022-06-13 18:59hgbotNote Added: 0138324
2022-06-15 19:05hgbotMerge Request Statusopen => approved
2022-06-16 12:21hgbotNote Added: 0138403
2022-06-16 12:21hgbotResolutionopen => fixed
2022-06-16 12:21hgbotStatusnew => closed
2022-06-16 12:21hgbotNote Added: 0138404
2022-06-16 12:21hgbotNote Added: 0138405
2022-06-16 12:21hgbotNote Added: 0138406
2022-06-16 12:21hgbotNote Added: 0138407
2022-06-16 12:21hgbotNote Added: 0138408
2022-06-17 08:56rafarodaTag Attached: FASH

Notes
(0138323)
hgbot   
2022-06-13 18:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/770 [^]
(0138324)
hgbot   
2022-06-13 18:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1001 [^]
(0138403)
hgbot   
2022-06-16 12:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/770 [^]
(0138404)
hgbot   
2022-06-16 12:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 6906a6366cdeb20a7bf7df993c004ad41c11ca33
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 10:21:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6906a6366cdeb20a7bf7df993c004ad41c11ca33 [^]

Fixes ISSUE-49123: Now in a filterable grid, removing a filter stops filtering by it

---
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/FilterBar.jsx
M web-jspack/org.openbravo.core2/src/components/FilterableGrid/useOptionalFilters.js
---
(0138405)
hgbot   
2022-06-16 12:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1001 [^]
(0138406)
hgbot   
2022-06-16 12:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c33c2b05499ff56afce643899e12ba80899a8a8e
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 10:21:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c33c2b05499ff56afce643899e12ba80899a8a8e [^]

Related to ISSUE-49123: Fix bp selector in orders to allow delete or remove. Refactor initialFilters of listRemoteWindow

To reset the bp button value on remove was needed to remove the initial filter value of this field,
but the api don't allow that.

Refactor the api of set initial values to allow add/update, remove and remove all

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/ListRemoteWindowInitialFilters.js
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/ViewOrdersOfCustomer.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/ListRemoteWindowHooks.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetListRemoteWindowInitialFilters.js
---
(0138407)
hgbot   
2022-06-16 12:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 577493fab56c3da6a40ac7371214743122aada8d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 10:21:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/577493fab56c3da6a40ac7371214743122aada8d [^]

Related to ISSUE-49123: Adapt tests

---
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGridBPFilter.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/ViewOrdersOfCustomer.test.js
---
(0138408)
hgbot   
2022-06-16 12:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6a12c63b00c93ac80bba402bef9a6f2d4d517e30
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 16-06-2022 10:21:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6a12c63b00c93ac80bba402bef9a6f2d4d517e30 [^]

Related to ISSUE-49123: Review: rename ListRemoteWindowInitialFilters to TicketListRemoteWindowInitialFilters

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/TicketListRemoteWindowInitialFilters.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/TicketListRemoteWindowHooks.js
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGrid.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/TicketListRemoteGridBPFilter.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGridBPFilter.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/ViewOrdersOfCustomer.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/ViewOrdersOfCustomer.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/ListRemoteWindowInitialFilters.js
---