Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049073Retail ModulesDiscounts and Promotionspublic2022-04-19 10:102022-09-02 13:30
ReporterAugustoMauch 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049073: Create new hook in discount engine to filter out discounts programatically, using ticket information
DescriptionA new hook should be added to discount engine to allow filtering out discounts with the ticket information. This allows to extend the engine with several filters from different modules.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-04-19 10:10AugustoMauchNew Issue
2022-04-19 10:10AugustoMauchAssigned To => cberner
2022-04-19 10:10AugustoMauchOBNetwork customer => No
2022-04-19 10:10AugustoMauchTriggers an Emergency Pack => No
2022-04-19 13:16AugustoMauchStatusnew => scheduled
2022-04-19 17:50cbernerDescription Updatedbug_revision_view_page.php?rev_id=23928#r23928
2022-04-20 12:13hgbotMerge Request Status => open
2022-04-20 12:13hgbotNote Added: 0136625
2022-05-11 15:15hgbotMerge Request Statusopen => approved
2022-05-20 12:48hgbotNote Added: 0137574
2022-05-20 12:48hgbotNote Added: 0137575
2022-09-02 13:30AugustoMauchStatusscheduled => resolved
2022-09-02 13:30AugustoMauchResolutionopen => fixed
2022-09-02 13:30AugustoMauchStatusresolved => closed

Notes
(0136625)
hgbot   
2022-04-20 12:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/53 [^]
(0137574)
hgbot   
2022-05-20 12:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: b151b08cca361248228e5d7593573db4a6a0b34c
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 20-05-2022 12:46:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/b151b08cca361248228e5d7593573db4a6a0b34c [^]

Related to FR-49073: Merge branch 'fr/49073-hook-discounts'

Create a new hook to allow introducing different rules to filter out if
a discount should be applied to the current ticket or not. This adds
isApplicableToTicket hooks to the main discount engine and a way to
register them in other modules.

---
A src-test/org/openbravo/retail/discounts/test/base/model/ExternalBusinessPartner.java
M src-test/org/openbravo/retail/discounts/test/base/model/DiscountsTestModelObject.java
M src-test/org/openbravo/retail/discounts/test/base/model/Ticket.java
M src/org/openbravo/retail/discounts/DiscountDataHookSelector.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---
(0137575)
hgbot   
2022-05-20 12:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/53 [^]