0049023: Remove --legacy-peer-deps flag when possible

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049023

POS2

Core

public

2022-04-11 10:06

2024-03-14 11:21

Reporter

jarmendariz

Assigned To

Triage Platform Base

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049023: Remove --legacy-peer-deps flag when possible

Description

As part of issue 0048870, the flag --legacy-peer-deps were introduced to avoid installing the local Openbravo modules as peer dependencies, which greatly increases the build time. Also, some peer dependency warnings were found during npm install, specifically for react-spring, which its current version does not support React 17.

Steps To Reproduce

See description

Proposed Solution

This issue should be done after 0049012 and once this issue in react-spring is fixed: https://github.com/pmndrs/react-spring/issues/1861 [^]

Then we should test that the project builds properly and that jest tests run successfully and it doesn't appear the 'multiple React instances' error.

Additional Information

Tags

No tags attached.

Relationships

related to	feature request	0048870	closed	jarmendariz	Add support to Node 16/Npm 8
depends on	design defect	0049012	new	Triage Platform Base	Remove peer dependencies of local OB modules
Not all the children of this issue are yet resolved or closed.