Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049011Openbravo ERPA. Platformpublic2022-04-08 11:192022-05-31 10:31
Reporteralostale 
Assigned Tomeriem_azaf 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR22Q3Fixed in VersionPR22Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049011: remove obsolete Translation Required field from Module window
DescriptionTranslation required field is present in Module window, it is never used so it could be removed.

Together with it there is a validation to ensure modules with "UI artifacts" mark this flag. This validation should also be removed as it provides no value.
Steps To Reproduce1. Create a module with the Translation Required flag unchecked
2. Create a new window for that module
3. Run validations
  -> It complains about that module not being marked as translation required
Proposed Solution1. Remove the field from Module window
2. Remove checkUIArtifacts from ModuleValidator [1]
3. Deprecate the column in AD
   We'll keep the column to prevent a formal change when exporting every module


[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/system/ModuleValidator.java#L186 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0049264PR22Q2.1 closed meriem_azaf remove obsolete Translation Required field from Module window 
depends on backport 0049265PR22Q1.3 closed meriem_azaf remove obsolete Translation Required field from Module window 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
causes defect 0049413 closed meriem_azaf API Change: Removed Translation Required field from Module window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-04-08 11:19alostaleNew Issue
2022-04-08 11:19alostaleAssigned To => Triage Platform Base
2022-04-08 11:19alostaleModules => Core
2022-04-08 11:19alostaleTriggers an Emergency Pack => No
2022-04-08 11:20alostaleTarget Version => PR22Q3
2022-04-08 11:29alostaleRelationship addedblocks 0032688
2022-04-11 12:48AugustoMauchAssigned ToTriage Platform Base => meriem_azaf
2022-04-11 12:48AugustoMauchStatusnew => scheduled
2022-05-09 13:03AugustoMauchStatusscheduled => resolved
2022-05-09 13:03AugustoMauchFixed in SCM revision => asdf
2022-05-09 13:03AugustoMauchResolutionopen => fixed
2022-05-09 13:03AugustoMauchStatusresolved => new
2022-05-09 13:03AugustoMauchResolutionfixed => open
2022-05-09 13:04AugustoMauchStatusnew => scheduled
2022-05-13 14:08hgbotNote Added: 0137268
2022-05-25 14:07meriem_azafRelationship addedcauses 0049413
2022-05-26 11:04hgbotResolutionopen => fixed
2022-05-26 11:04hgbotStatusscheduled => closed
2022-05-26 11:04hgbotFixed in Version => PR22Q3
2022-05-26 11:04hgbotNote Added: 0137752
2022-05-26 11:04hgbotNote Added: 0137753
2022-05-31 10:31cbernerFixed in SCM revisionasdf =>

Notes
(0137268)
hgbot   
2022-05-13 14:08   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/597 [^]
(0137752)
hgbot   
2022-05-26 11:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6932031f8f077c3eef28cc6fdafccc8f7b6744a1
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 26-05-2022 10:53:38
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6932031f8f077c3eef28cc6fdafccc8f7b6744a1 [^]

Fixes ISSUE-49011: Remove obsolete Translation Required field from Module window

The problem that creating a new module with the translation required flag unchecked and create also a new window for that module after running the validatio it complains about that module not being marked as translation required.

To fix this, we removed the field translation required from Module window and also the function checkUIArtifacts from ModuleValidator. we deprecated the column in AD.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/CreateCustomModule.java
M src/org/openbravo/service/system/ModuleValidator.java
---
(0137753)
hgbot   
2022-05-26 11:04   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/597 [^]