Openbravo Issue Tracking System - Modules
View Issue Details
0048948ModulesFrench Fiscalpublic2022-03-31 15:342023-03-06 18:17
shuehner 
francisco_ofarril 
normalmajorhave not tried
closedfixed 
5
 
 
0048948: certification.france.dev: Fix HQL queries not using HQL style + not using bind-parameters
This module contains several HQL queries not following the HQL style we have (i.e. avoiding StringBuilder).
Apart several having non-constant parts inside their HQL (i.e. dynamic entity name) which fails automatic checking (maybe rewritable with OBCriteria insead).
-
Apply HQL Style to all queries
+ Review the ones having dynamic entity names
No tags attached.
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2022-03-31 15:34shuehnerNew Issue
2022-03-31 15:34shuehnerAssigned To => Triage Omni OMS
2022-03-31 15:34shuehnerIssue generated from0048946
2022-03-31 15:34shuehnerRelationship addedblocks 0041287
2022-03-31 15:35shuehnerNote Added: 0136215
2022-12-16 15:34aferrazAssigned ToTriage Omni OMS => francisco_ofarril
2022-12-16 17:33francisco_ofarrilStatusnew => acknowledged
2022-12-22 19:53hgbotNote Added: 0144946
2023-01-23 17:15hgbotNote Added: 0145771
2023-01-30 17:56aferrazNote Deleted: 0145771
2023-02-23 18:09hgbotResolutionopen => fixed
2023-02-23 18:09hgbotStatusacknowledged => closed
2023-02-23 18:09hgbotNote Added: 0146937
2023-02-23 18:09hgbotNote Added: 0146938
2023-02-24 10:12hgbotNote Added: 0146961
2023-02-24 12:19hgbotNote Added: 0146976
2023-02-24 12:19hgbotNote Added: 0146979
2023-03-01 23:31hgbotNote Added: 0147203
2023-03-06 09:43hgbotNote Added: 0147284
2023-03-06 09:43hgbotNote Added: 0147285
2023-03-06 15:19hgbotNote Added: 0147303
2023-03-06 18:17hgbotNote Added: 0147305
2023-03-06 18:17hgbotNote Added: 0147306

Notes
(0136215)
shuehner   
2022-03-31 15:35   
Issue is to be fixed mainly in .dev module to improve automated code-checking. If while doing this all issues are formal fixes only push to non-dev repo is not required to be done immediately) => But should be done eventually to keep both in sync.
(0144946)
hgbot   
2022-12-22 19:53   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/30 [^]
(0146937)
hgbot   
2023-02-23 18:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: 0aeb99b24969ea268ec86d27211bba07f826223c
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 23-02-2023 17:09:03
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/0aeb99b24969ea268ec86d27211bba07f826223c [^]

Fixes ISSUE-48948: Fix HQL queries not using HQL style + not using bind-parameters

---
M src/org/openbravo/certification/france/aggregation/AggregationDayDao.java
M src/org/openbravo/certification/france/aggregation/AggregationYearDao.java
M src/org/openbravo/certification/france/alert/AlertUtils.java
M src/org/openbravo/certification/france/background/FrenchFiscalSecurityManager.java
M src/org/openbravo/certification/france/ticket/TicketUtils.java
M src/org/openbravo/certification/france/ui/UIIssueHandlerHelper.java
M src/org/openbravo/certification/france/ui/UIUtils.java
M src/org/openbravo/certification/france/ui/UIVerificationBackground.java
M src/org/openbravo/certification/france/utils/TerminalUtils.java
---
(0146938)
hgbot   
2023-02-23 18:09   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/30 [^]
(0146961)
hgbot   
2023-02-24 10:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/7 [^]
(0146976)
hgbot   
2023-02-24 12:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/7 [^]
(0146979)
hgbot   
2023-02-24 12:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: 21eeb16ecdbab75ac5b201f2eb35e104e4297056
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 24-02-2023 11:19:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/21eeb16ecdbab75ac5b201f2eb35e104e4297056 [^]

Fixes ISSUE-51440, Fixes ISSUE-51510, Fixes ISSUE-48948: Obfuscate from dev

---
A web-jspack/org.openbravo.certification.france/src/registerGlobalAction.js
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/sourcedata/AD_MODULE.xml
M web-jspack/org.openbravo.certification.france/src/ob-init.js
M web-jspack/org.openbravo.certification.france/src/registerLoginAction.js
M web-jspack/org.openbravo.certification.france/src/registerRemoteServerListener.js
M web/org.openbravo.certification.france/app/model/business-object/html/Html.js
M web/org.openbravo.certification.france/app/model/business-object/html/HtmlUtils.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/AddObcfrTerminalMonitor.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/CompleteTicketPostHook.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/InitializeHtml.js
M web/org.openbravo.certification.france/app/model/business-object/html/actions/PrintTicketPostHook.js
M web/org.openbravo.certification.france/js/terminal/terminalLoadedFromBackendHook.js
M web/org.openbravo.certification.france/js/terminalmonitor/connectedToERPEvent.js
---
(0147203)
hgbot   
2023-03-01 23:31   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/37 [^]
(0147284)
hgbot   
2023-03-06 09:43   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: c3716ba7542dd491c8c2d692c48ef7340940e06c
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 06-03-2023 08:43:37
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/c3716ba7542dd491c8c2d692c48ef7340940e06c [^]

Related to ISSUE-48948: Add setMaxResults(1) when use uniqueResult()

---
M src/org/openbravo/certification/france/aggregation/AggregationYearDao.java
M src/org/openbravo/certification/france/background/FrenchFiscalSecurityManager.java
M src/org/openbravo/certification/france/ui/UIIssueHandlerHelper.java
---
(0147285)
hgbot   
2023-03-06 09:43   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/37 [^]
(0147303)
hgbot   
2023-03-06 15:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/8 [^]
(0147305)
hgbot   
2023-03-06 18:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: c328ab234558b891a55e8fa812a579c6c169ac14
Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com>
Date: 06-03-2023 17:17:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/c328ab234558b891a55e8fa812a579c6c169ac14 [^]

Related to ISSUE-48948: Add setMaxResults(1) when use uniqueResult(). Obfuscate from dev

---
M lib/runtime/org.openbravo.certification.france-1.0.jar
M src-db/database/sourcedata/AD_MODULE.xml
---
(0147306)
hgbot   
2023-03-06 18:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/8 [^]