Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048943Retail ModulesSend By Emailpublic2022-03-31 13:112022-07-01 15:01
Reporteraferraz 
Assigned Toaferraz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048943: Improve Send By Email module to reuse the templates defined for printing
Descriptionhttps://openbravo.atlassian.net/browse/RM-517 [^]
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-31 13:11aferrazNew Issue
2022-03-31 13:11aferrazAssigned To => aferraz
2022-03-31 13:11aferrazTriggers an Emergency Pack => No
2022-03-31 13:22hgbotNote Added: 0136210
2022-04-06 13:13hgbotNote Added: 0136355
2022-04-06 15:48hgbotNote Added: 0136364
2022-04-06 16:28hgbotNote Added: 0136371
2022-04-11 10:19hgbotNote Added: 0136456
2022-04-11 10:20hgbotNote Added: 0136457
2022-04-25 17:47hgbotNote Added: 0136729
2022-04-25 18:44hgbotNote Added: 0136732
2022-04-27 13:43hgbotNote Added: 0136805
2022-04-27 13:44aferrazNote Deleted: 0136805
2022-04-27 16:08hgbotNote Added: 0136810
2022-04-27 16:08aferrazNote Deleted: 0136810
2022-04-27 17:20hgbotNote Added: 0136821
2022-04-27 17:35aferrazNote Deleted: 0136821
2022-04-29 11:45hgbotNote Added: 0136862
2022-04-29 12:00aferrazNote Deleted: 0136862
2022-04-29 12:15hgbotNote Added: 0136864
2022-04-29 12:16aferrazNote Deleted: 0136864
2022-04-29 12:46hgbotNote Added: 0136865
2022-04-29 12:49aferrazNote Deleted: 0136865
2022-05-02 16:01hgbotNote Added: 0136887
2022-05-02 16:01hgbotNote Added: 0136888
2022-05-02 16:04aferrazNote Deleted: 0136887
2022-05-02 16:04aferrazNote Deleted: 0136888
2022-05-04 10:11aferrazNote Deleted: 0136457
2022-05-04 10:11aferrazNote Deleted: 0136456
2022-05-04 10:12aferrazNote Deleted: 0136732
2022-05-04 10:12aferrazNote Deleted: 0136364
2022-05-04 15:03hgbotNote Added: 0136942
2022-06-06 17:03hgbotNote Added: 0138091
2022-07-01 14:39hgbotNote Added: 0138939
2022-07-01 14:39hgbotResolutionopen => fixed
2022-07-01 14:39hgbotStatusnew => closed
2022-07-01 14:39hgbotFixed in Version => RR22Q4
2022-07-01 14:39hgbotNote Added: 0138940
2022-07-01 14:40hgbotNote Added: 0138941
2022-07-01 14:41hgbotNote Added: 0138942
2022-07-01 14:41hgbotNote Added: 0138943
2022-07-01 14:41hgbotNote Added: 0138944
2022-07-01 14:41hgbotNote Added: 0138945
2022-07-01 14:41hgbotNote Added: 0138946
2022-07-01 14:41hgbotNote Added: 0138947
2022-07-01 14:41hgbotNote Added: 0138948
2022-07-01 14:41hgbotNote Added: 0138949
2022-07-01 14:41hgbotNote Added: 0138950
2022-07-01 14:41hgbotNote Added: 0138951
2022-07-01 14:41hgbotNote Added: 0138952
2022-07-01 14:42hgbotNote Added: 0138953
2022-07-01 14:42hgbotNote Added: 0138954
2022-07-01 15:01hgbotNote Added: 0138955

Notes
(0136210)
hgbot   
2022-03-31 13:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/10 [^]
(0136355)
hgbot   
2022-04-06 13:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/762 [^]
(0136371)
hgbot   
2022-04-06 16:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/916 [^]
(0136729)
hgbot   
2022-04-25 17:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/356 [^]
(0136942)
hgbot   
2022-05-04 15:03   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/25 [^]
(0138091)
hgbot   
2022-06-06 17:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/126 [^]
(0138939)
hgbot   
2022-07-01 14:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/356 [^]
(0138940)
hgbot   
2022-07-01 14:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: efc56392d6075e5edb6f66123c5c30ac377850cc
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 06-06-2022 16:04:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/efc56392d6075e5edb6f66123c5c30ac377850cc [^]

Fixes ISSUE-48943: Changing the use of OB.UTIL.showError by OB.App.UserNotifier.notifyError

---
---
(0138941)
hgbot   
2022-07-01 14:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/762 [^]
(0138944)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 16a0fd42f8ed56c98f942dcee6ef6dfd651c5e6f
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/16a0fd42f8ed56c98f942dcee6ef6dfd651c5e6f [^]

Fixes ISSUE-48943: Improving logic to generate giftCardData object

---
M web-jspack/org.openbravo.retail.giftcards/src/model/creditnote/utils/GenerateGiftCardData.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
M web-jspack/org.openbravo.retail.giftcards/src/model/messages/MessagesUtils.js
---
(0138946)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: d7e05c52a58e7f5780e988a4ea48e09f6883dbdc
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d7e05c52a58e7f5780e988a4ea48e09f6883dbdc [^]

Fixes ISSUE-48943: Minor fix generateGiftCardData

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
---
(0138945)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 89d40a40823e89ddd0dbc4e1a87fc1a0a55d3a54
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/89d40a40823e89ddd0dbc4e1a87fc1a0a55d3a54 [^]

Fixes ISSUE-48943: Setting generateGiftCardData as a local function and assigning giftCardData object to the Credit Note.

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
M web-jspack/org.openbravo.retail.giftcards/src/model/messages/MessagesUtils.js
R web-jspack/org.openbravo.retail.giftcards/src/model/creditnote/utils/GenerateGiftCardData.js
---
(0138943)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 8c2fd0b62b8e2bff92cc831d7a689eccaaf0fa42
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/8c2fd0b62b8e2bff92cc831d7a689eccaaf0fa42 [^]

Fixes ISSUE-48943: Printing and sending by email the Credit Notes
Note: Pendent to fix one more issue related to cnData.get function

---
A web-jspack/org.openbravo.retail.giftcards/src/model/creditnote/utils/GenerateGiftCardData.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
---
(0138942)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 854c90e8771356622ee836c59db7aea92a0d0bf0
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/854c90e8771356622ee836c59db7aea92a0d0bf0 [^]

Fixes ISSUE-48943: Getting "creditNote" as an independent parameter to pass it into generateDeliverCreditNoteMessages function and modifying completeTicket post hook in CreditNoteTicketExtension.js to call generateDeliverCreditNoteMessages.
Note: Sending by email fails

---
A web-jspack/org.openbravo.retail.giftcards/src/model/messages/MessagesExtension.js
A web-jspack/org.openbravo.retail.giftcards/src/model/messages/MessagesUtils.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/CreditNoteTicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
---
(0138947)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 78fcaed7820832470d2f82218c9a675130671993
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/78fcaed7820832470d2f82218c9a675130671993 [^]

Fixes ISSUE-48943: Adding test for generateDeliverCreditNoteMessages

---
A web-jspack/org.openbravo.retail.giftcards/src/model/messages/__test__/MessagesUtils.test.js
---
(0138948)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: b137ff6038e0eb9960ca2bdee46987dd0498499b
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b137ff6038e0eb9960ca2bdee46987dd0498499b [^]

Fixes ISSUE-48943: Adding print/send popup when a Credit Note is selected.

---
A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CreditNoteGlobalActions.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
---
(0138949)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: ec2310e6f85f8df04c50196648a495d07fb21506
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ec2310e6f85f8df04c50196648a495d07fb21506 [^]

Fixes ISSUE-48943: Applying changes to import and copyrights

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/CreditNoteGlobalActions.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
M web-jspack/org.openbravo.retail.giftcards/src/model/messages/MessagesExtension.js
---
(0138950)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 7509d229235bc17c56eb24270510b7b4bd44bc39
Author: gdayron777 <gustavo.salas@doceleguas.com>
Date: 01-07-2022 14:31:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/7509d229235bc17c56eb24270510b7b4bd44bc39 [^]

Fixes ISSUE-48943: Minor adjust to Copyright

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/actions/SendPrintCreditNoteMessage.js
---
(0138951)
hgbot   
2022-07-01 14:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: dd3181823dd79d975e9e2e78d9496f48e358c68e
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 01-07-2022 14:34:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/dd3181823dd79d975e9e2e78d9496f48e358c68e [^]

Fixes ISSUE-48943: Refactor code to include a CreditNotePrinter

Instead of create a function to send credit note to a printer,
use a class to generate a credit note printer to handle message
print

---
A web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/CreditNotePrinter.js
M web-jspack/org.openbravo.retail.giftcards/src/ob-init.js
R web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/SendCreditNoteToPrinter.js
---
(0138952)
hgbot   
2022-07-01 14:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/126 [^]
(0138953)
hgbot   
2022-07-01 14:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/10 [^]
(0138954)
hgbot   
2022-07-01 14:42   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/25 [^]
(0138955)
hgbot   
2022-07-01 15:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/916 [^]