Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048874Openbravo LocalizationsLocalization Portugalpublic2022-03-23 11:162022-06-27 12:48
Reporteraferraz 
Assigned Toaferraz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customer
Regression introduced in release
Summary0048874: Simplified Invoice Threshold should be adapted to work with Customer Tax ID popup
DescriptionSimplified Invoice Threshold should be adapted to work with Customer Tax ID popup
Steps To Reproduce- Configure SAFT module and Simplified Invoice Threshold preferences.
- In WebPOS create a ticket for anonymous customer.
- Click on checkout button. Check Customer Tax ID popup is shown.
- Enter 123456789 tax ID and complete the ticket. Realize threshold defined for VAT taxable is not applied.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0048858 closed psanjuan Portugal - Simplified Invoice Threshold extension to Tax ID pop-up 
related to feature request 0048887 closed aferraz Simplified Invoice Threshold for Portugal should consider tax ID starting by 6 as VAT taxable person 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-23 11:16aferrazNew Issue
2022-03-23 11:16aferrazAssigned To => aferraz
2022-03-23 11:17aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23799#r23799
2022-03-23 11:20aferrazTypedefect => feature request
2022-03-23 11:20aferrazSummarySimplified Invoice Threshold not working when using anonymous customer and entering taxID directly from POS => Simplified Invoice Threshold should be adapted to work with Customer Tax ID popup
2022-03-23 11:20aferrazDescription Updatedbug_revision_view_page.php?rev_id=23801#r23801
2022-03-23 13:31aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23802#r23802
2022-03-23 14:00hgbotNote Added: 0135966
2022-03-23 14:02hgbotNote Added: 0135967
2022-03-23 14:12hgbotNote Added: 0135968
2022-03-23 14:51aferrazNote Added: 0135970
2022-03-24 14:18aferrazRelationship addedrelated to 0048887
2022-03-24 17:18aferrazRelationship addedhas duplicate 0048858
2022-03-25 08:52hgbotResolutionopen => fixed
2022-03-25 08:52hgbotStatusnew => closed
2022-03-25 08:52hgbotNote Added: 0136013
2022-03-25 08:52hgbotNote Added: 0136014
2022-03-25 08:53hgbotNote Added: 0136015
2022-03-25 08:53hgbotNote Added: 0136016
2022-03-25 08:53hgbotNote Added: 0136017
2022-03-25 08:53hgbotNote Added: 0136018
2022-06-27 12:48aferrazNote Added: 0138783

Notes
(0135966)
hgbot   
2022-03-23 14:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/42 [^]
(0135967)
hgbot   
2022-03-23 14:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/43 [^]
(0135968)
hgbot   
2022-03-23 14:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/44 [^]
(0135970)
aferraz   
2022-03-23 14:51   
Test plan:

In Backoffice:
- Change Vall Blanca Store organization country to Portugal.
- Change VBS Customer business partner country to Portugal.
- Create Tax Rate for IVA Normal tax category from Portugal country to Portugal destination country with 23 rate.
- Define Web POS - Simplified Invoices Threshold for non VAT taxable preference with 100 value.
- Define Web POS - Simplified Invoices Threshold for VAT taxable preference with 200 value.

In WebPOS:
- Create a ticket for anonymous customer with 1 unit of Avalanche transceiver.
- Click on checkout button and enter a non VAT taxable tax ID (not starting with 5). Check following error is shown: It is not possible to issue a simplified invoice for an amount up to its threshold (100). Please decrease the amount or issue a full invoice.

- Create a ticket for anonymous customer with 1 unit of Avalanche transceiver.
- Click on checkout button and enter a VAT taxable tax ID (starting with 5). Check no error is shown and you can complete the ticket.

- Create a ticket for anonymous customer with 2 units of Avalanche transceiver.
- Click on checkout button and enter a VAT taxable tax ID (starting with 5). Check following error is shown: It is not possible to issue a simplified invoice for an amount up to its threshold (200). Please decrease the amount or issue a full invoice.
(0136013)
hgbot   
2022-03-25 08:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 5bdeddc91730723f5940c2d1cec0dd60021c7895
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 25-03-2022 07:52:46
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/5bdeddc91730723f5940c2d1cec0dd60021c7895 [^]

Fixes ISSUE-48874: Show Customer Tax ID popup in OBPOS_PrePaymentHook and wait until tax ID is introduced

---
M web/com.practicsbs.saftpt.retail/js/hooks/checkpaymentapproval.js
M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js
---
(0136014)
hgbot   
2022-03-25 08:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/42 [^]
(0136015)
hgbot   
2022-03-25 08:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 49870978dde303e4099c2c08e2ff2241e2fade5b
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 25-03-2022 07:53:04
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/49870978dde303e4099c2c08e2ff2241e2fade5b [^]

Fixes ISSUE-48874: [20Q3] Show Customer Tax ID popup in OBPOS_PrePaymentHook and wait until tax ID is introduced

---
M web/com.practicsbs.saftpt.retail/js/hooks/checkpaymentapproval.js
M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js
---
(0136016)
hgbot   
2022-03-25 08:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/43 [^]
(0136017)
hgbot   
2022-03-25 08:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 0a40f1c7892dfe06fb3d99fa98a97778185ef4fb
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 25-03-2022 07:53:47
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/0a40f1c7892dfe06fb3d99fa98a97778185ef4fb [^]

Fixes ISSUE-48874: [19Q3] Show Customer Tax ID popup in OBPOS_PrePaymentHook and wait until tax ID is introduced

---
M src/com/practicsbs/saftpt/retail/SafrComponentProvider.java
M web/com.practicsbs.saftpt.retail/js/hooks/prepayment.js
R web/com.practicsbs.saftpt.retail/js/hooks/checkpaymentapproval.js
---
(0136018)
hgbot   
2022-03-25 08:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/44 [^]
(0138783)
aferraz   
2022-06-27 12:48   
Added to certification branch: https://gitlab.com/openbravo/devel/pmods/com.practicsbs.saftpt.retail/-/commit/e6ef2c3e567f425d540936a1164d98ba6766fe45 [^]