Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048834POS2POSpublic2022-03-18 14:042022-05-24 10:18
Reporterplujan 
Assigned Toasier_perez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048834: [Coverage] The Jest coverage of BaseSwipeableLine.jsx is not good enough
DescriptionFile: org.openbravo.core2/web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine BaseSwipeableLine.jsx
Results of jest coverage: 33.8% Statements 24/71 21.28% Branches 20/94 38.46% Functions 5/13 32.86% Lines 23/70
Most of the untested code seems to be part of "Forward Ref"
Steps To ReproduceRun the jest coverage report and check the above file coverage.
Proposed SolutionKeep the coverage percentage in a value good enough for the code that can be covered with standard unit tests.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-18 14:04plujanNew Issue
2022-03-18 14:04plujanAssigned To => Retail
2022-03-18 14:04plujanTriggers an Emergency Pack => No
2022-05-05 12:37plujanAssigned ToRetail => asier_perez
2022-05-10 13:42asier_perezStatusnew => acknowledged
2022-05-13 14:09asier_perezStatusacknowledged => scheduled
2022-05-16 13:10hgbotNote Added: 0137316
2022-05-17 15:36plujanProposed Solution updated
2022-05-24 09:20hgbotNote Added: 0137656
2022-05-24 09:20hgbotNote Added: 0137657
2022-05-24 09:51hgbotNote Added: 0137667
2022-05-24 09:58hgbotNote Added: 0137668
2022-05-24 09:58hgbotResolutionopen => fixed
2022-05-24 09:58hgbotStatusscheduled => closed
2022-05-24 09:58hgbotNote Added: 0137669
2022-05-24 10:18hgbotNote Added: 0137672

Notes
(0137316)
hgbot   
2022-05-16 13:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/751 [^]
(0137656)
hgbot   
2022-05-24 09:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: d46ee8c829afc697120b23aa267112d2d5f06869
Author: Asier Perez <asier.perez@openbravo.com>
Date: 24-05-2022 07:08:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d46ee8c829afc697120b23aa267112d2d5f06869 [^]

Fix ISSUE-48834: Increase Jest coverage of BaseSwipeableLine.jsx

---
M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/__test__/ConfigSwipeableLine.test.jsx
---
(0137657)
hgbot   
2022-05-24 09:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/751 [^]
(0137667)
hgbot   
2022-05-24 09:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/756 [^]
(0137668)
hgbot   
2022-05-24 09:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 8c9c1f82dc2143b7c6b74161e3e293718d38cf8f
Author: Asier Perez <asier.perez@openbravo.com>
Date: 24-05-2022 07:51:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/8c9c1f82dc2143b7c6b74161e3e293718d38cf8f [^]

Related to ISSUE-48834: Increase Jest coverage of BaseSwipeableLine.jsx

---
M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/__test__/ConfigSwipeableLine.test.jsx
---
(0137669)
hgbot   
2022-05-24 09:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 233159b2c2ce6b557c52110762a00c97e66a38f6
Author: Asier Perez <asier.perez@openbravo.com>
Date: 24-05-2022 07:51:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/233159b2c2ce6b557c52110762a00c97e66a38f6 [^]

Fixes ISSUE-48834: Add test for BaseSwipeableLine

---
M web-jspack/org.openbravo.core2/src/components/ConfigSwipeableLine/__test__/ConfigSwipeableLine.test.jsx
---
(0137672)
hgbot   
2022-05-24 10:18   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/756 [^]