Openbravo Issue Tracking System - POS2
View Issue Details
0048791POS2POSpublic2022-03-14 18:322024-03-14 12:38
timothee_catteeuw 
Retail 
normalmajoralways
newopen 
5
 
 
No
0048791: JIRA 2763 - Error message too quickly displayed when modifiers selection have no default value
In that context for example (cf. screen shot without error message)

- Type de cuisson has a default value, and the selection of 1 value is necessary

- Ingredient has no default value and requires at least the selection of 1 value


if I press "saignant", an error message is displayed (cf. other screenshot)

it is caused by ingredients list because :

- this list has no default value

- it is mandatory to select at least one value of modifiers group. Otherwise it is not possible to move forward.

Steps to reproduce :
1) go to BO
2) create 2 modifiers groups
3) for the 1st,min and max selection equals to 1
4) for the second, min selection = 1 and mas selection = 3
5) link a product to both modifiers
6) go to webpos
7) Select the product
8) select a value different than the default value for the 1st modifier
--> a message appears too soon --> Select at least one option
Actually the problem happens due to the validation of the modifier group constraints.

Taking the above example, we have 2 modifier groups

Group 1:

    Minimum (of selected options) 1
    Maximum (of selected options) 1

    Option 1 - Default value
    Option 2 -
    Option 3 -

Group 2:

    Minimum (of selected options) 1
    Maximum (of selected options) 3

    Option 1 -
    Option 2 -
    Option 3 -

------------------------------------------------

Once the product configuration window is displayed, it is divided into the corresponding 2 groups, but the validations (which are executed in case of any change in any of the modifiers) are performed on ALL the different modifiers (regardless of the group), so when the modification or configuration is performed on any of the modifiers of the first group, the validation is performed for the first group as for the second one (which does not comply with its configuration and the message is displayed).

------------------------------------------------

Therefore, the following 2 solutions are proposed:

-----

SOLUTION 1:

1.- Internally divide the modifiers window into 2 different forms (in case of having X groups, divide them into X forms).

2.- Once a modifier has been selected. Perform the validations of the modifiers on the form to which it belongs (independently of the rest).

(This way we could, also, be able to show more 'accurate' error messages in the groups where the requirements are not fulfilled).
(This way we would avoid error messages for modifier groups that have not yet been selected).

-----

SOLUTION 2:

1.- Perform validations/verification of modifier groups when the 'Finish' button is pressed (which is currently disabled because the requirements are not met).

-----

Forced solution:

1.- That all modifier groups have 1 default value set.
No tags attached.
png image-2022-03-14-18-12-55-081.png (21,479) 2022-03-14 18:33
https://issues.openbravo.com/file_download.php?file_id=16754&type=bug
png

png image-2022-03-14-18-13-43-663.png (25,400) 2022-03-14 18:33
https://issues.openbravo.com/file_download.php?file_id=16755&type=bug
png
Issue History
2022-03-14 18:32timothee_catteeuwNew Issue
2022-03-14 18:32timothee_catteeuwAssigned To => Retail
2022-03-14 18:32timothee_catteeuwTriggers an Emergency Pack => No
2022-03-14 18:33timothee_catteeuwFile Added: image-2022-03-14-18-12-55-081.png
2022-03-14 18:33timothee_catteeuwFile Added: image-2022-03-14-18-13-43-663.png
2022-04-21 15:04sntgrealeAssigned ToRetail => sntgreale
2022-04-21 15:04sntgrealeStatusnew => acknowledged
2022-04-22 04:11sntgrealeStatusacknowledged => scheduled
2022-05-04 17:23guilleaerAssigned Tosntgreale => Retail
2022-05-04 17:23guilleaerStatusscheduled => acknowledged
2022-05-04 17:24guilleaerNote Added: 0136952
2022-05-04 20:18sntgrealeProposed Solution updated
2022-05-04 20:24sntgrealeProposed Solution updated
2022-05-04 20:24sntgrealeProposed Solution updated
2022-05-17 15:47AugustoMauchAssigned ToRetail => meriem_azaf
2022-05-17 17:29AugustoMauchStatusacknowledged => scheduled
2023-05-12 11:16ebecerraTag Attached: EBE - Pending Revision
2023-05-16 09:57AugustoMauchAssigned Tomeriem_azaf => ebecerra
2023-05-16 09:58guilleaerAssigned Toebecerra => Retail
2023-05-16 09:58guilleaerCategoryRestaurants => POS
2023-05-16 09:59guilleaerStatusscheduled => acknowledged
2024-03-14 12:38guilleaerTag Detached: EBE - Pending Revision

Notes
(0136952)
guilleaer   
2022-05-04 17:24   
We have sttoped to work on it because solution looks complex and now this is not a priority. As a workaround a default option should be selected