Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048768Retail ModulesCash uppublic2022-03-11 12:432022-04-07 13:08
Reporteridiez 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR21Q1.1 
Target VersionFixed in VersionRR22Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket39106
Regression level
Regression date2022-03-24
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048768: Error cash register closing with master/slave terminal configuration and shared payment methods
DescriptionError cash register closing with master/slave terminal configuration and shared payment methods in the version 21q1

The video link: https://drive.google.com/file/d/1xyyxhVlpVCK5XZeJGMMK_wxZc4tCuLlO/view?usp=sharing [^]
Steps To Reproduce1) Configure the terminal with the settings "master slay" and "shared payment method".

2) Make a ticket

3) Pay it with the payment method "Shared credit card".

4) Go to the second terminal

5) Make another ticket and use the payment method "Shared credit card".

6) Make a cash closing

7) Make another ticket in the same terminal and we pay again with the method "Shared credit card".

8) Return to make a new closing of the cash register.

9) Return to terminal 1

10) Make a cash closing and we can see that the last payment that was made in the previous ticket has not been taken into account.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-11 12:43idiezNew Issue
2022-03-11 12:43idiezAssigned To => Retail
2022-03-11 12:43idiezOBNetwork customer => OBPS
2022-03-11 12:43idiezSupport ticket => 39106
2022-03-11 12:43idiezRegression date => 2022-03-24
2022-03-11 12:43idiezTriggers an Emergency Pack => No
2022-03-21 05:04rqueraltaAssigned ToRetail => rqueralta
2022-03-21 05:04rqueraltaStatusnew => scheduled
2022-03-28 23:02hgbotMerge Request Status => open
2022-03-28 23:02hgbotNote Added: 0136120
2022-03-30 16:34eugeniIssue Monitored: eugeni
2022-03-30 16:58eugeniNote Added: 0136182
2022-03-30 17:00eugeniNote Edited: 0136182bug_revision_view_page.php?bugnote_id=0136182#r23829
2022-04-07 13:06hgbotMerge Request Statusopen => approved
2022-04-07 13:06hgbotNote Added: 0136395
2022-04-07 13:06hgbotResolutionopen => fixed
2022-04-07 13:06hgbotStatusscheduled => closed
2022-04-07 13:06hgbotFixed in Version => RR22Q3
2022-04-07 13:06hgbotNote Added: 0136396
2022-04-07 13:08marvintmNote Added: 0136397

Notes
(0136120)
hgbot   
2022-03-28 23:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/753 [^]
(0136182)
eugeni   
2022-03-30 16:58   
(edited on: 2022-03-30 17:00)
Note that in previous releases a SECOND cash up in the slave terminal was not allowed if master terminal was not previously cashed up (as there is an internal relation between slave cash up and master cash up). I remember a message like (more or less) "Please, do the cash up in the master terminal first".

May this control has been removed by error? We think this would a fair approach as well.
(0136395)
hgbot   
2022-04-07 13:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/753 [^]
(0136396)
hgbot   
2022-04-07 13:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 93335e6622fffcb256b196b6176c8777a6dc8fe4
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 07-04-2022 11:06:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/93335e6622fffcb256b196b6176c8777a6dc8fe4 [^]

Fixed BUG-48768: Check if exits more than one cashup in slave terminal related with the marter terminal

---
M src/org/openbravo/retail/posterminal/ProcessCashCloseSlave.java
---
(0136397)
marvintm   
2022-04-07 13:08   
We haven't actually been able to reproduce the issue except in one case. In that case, there were more than one cashup created, and in that case it was possible to execute the cashup process twice in the slave terminal.

We have added an additional validation to detect this case, so that it is not possible to do cashup a second time in the slave terminal, without doing cashup in the master first, which is how it was designed to work.