Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048762Retail ModulesWeb POSpublic2022-03-10 13:242022-04-03 23:54
aferraz 
gorka_gil 
normalmajorhave not tried
closedfixed 
5
 
RR22Q2 
Production - QA Approved
RR22Q1
No
0048762: Many unneded tax rules are loaded in WebPOS making tax engine very slow
Many unneded tax rules are loaded in WebPOS making tax engine very slow
Check in Information tab from Organization window "Vall Blanca Store" belongs to "Spain" country (id="106").

Check WebPOS loads some tax rules defined for a country different than Spain:
>>new Set(OB.Taxes.Pos.ruleImpls.map(rule => rule.country))
Set(4) {null, '106', '100', '102'}

By default, only rules with empty country or Spain country should be loaded in WebPOS.
Rules defined for other countries should be loaded only in case the store allows to have more than one location (0048093).
Add back to TaxRate.java and TaxZone.java the filters removed in https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/612 [^]
Skip these filters (or filter by every store location) just in case the store allows to have more than one location.
No tags attached.
related to defect 0048737 closed aferraz Performance problem in Tax Engine having tax rules with many tax zones 
depends on backport 0048950RR22Q1.2 closed gorka_gil Many unneded tax rules are loaded in WebPOS making tax engine very slow 
caused by feature request 0048093RR22Q1 closed gorka_gil Allow stores to have many locations/addresses 
Issue History
2022-03-10 13:24aferrazNew Issue
2022-03-10 13:24aferrazAssigned To => Retail
2022-03-10 13:24aferrazTriggers an Emergency Pack => No
2022-03-10 13:25aferrazRelationship addedcaused by 0048093
2022-03-10 13:27aferrazRegression level => Production - QA Approved
2022-03-10 13:27aferrazRegression introduced in release => RR22Q1
2022-03-10 13:31aferrazProposed Solution updated
2022-03-10 13:37aferrazRelationship addedrelated to 0048737
2022-03-10 13:45aferrazProposed Solution updated
2022-03-16 07:52marvintmAssigned ToRetail => gorka_gil
2022-03-25 13:26hgbotNote Added: 0136060
2022-03-30 17:55hgbotNote Added: 0136185
2022-03-30 18:19hgbotNote Added: 0136186
2022-03-31 16:37gorka_gilStatusnew => scheduled
2022-04-01 10:14hgbotResolutionopen => fixed
2022-04-01 10:14hgbotStatusscheduled => closed
2022-04-01 10:14hgbotNote Added: 0136234
2022-04-01 10:14hgbotFixed in Version => RR22Q2
2022-04-01 10:14hgbotNote Added: 0136235
2022-04-01 10:14hgbotNote Added: 0136236
2022-04-01 10:14hgbotNote Added: 0136237
2022-04-01 10:14hgbotNote Added: 0136238
2022-04-01 10:14hgbotNote Added: 0136239
2022-04-01 10:14hgbotNote Added: 0136240
2022-04-01 10:14hgbotNote Added: 0136241
2022-04-01 10:14hgbotNote Added: 0136242
2022-04-01 10:14hgbotNote Added: 0136243
2022-04-01 10:14hgbotNote Added: 0136244
2022-04-01 10:14hgbotNote Added: 0136245
2022-04-03 23:54hgbotNote Added: 0136287

Notes
(0136060)
hgbot   
2022-03-25 13:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/752 [^]
(0136185)
hgbot   
2022-03-30 17:55   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/176 [^]
(0136186)
hgbot   
2022-03-30 18:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/39 [^]
(0136234)
hgbot   
2022-04-01 10:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/752 [^]
(0136235)
hgbot   
2022-04-01 10:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3186194fc1de958f7579f13831df3efdb5863c18
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:14:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3186194fc1de958f7579f13831df3efdb5863c18 [^]

Fixed ISSUE-48762: only avoid filter taxes when we have many locations per store

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136236)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a68790c64f90e3b8d437eaf799ec9b9938065f52
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:14:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a68790c64f90e3b8d437eaf799ec9b9938065f52 [^]

Related to ISSUE-48762: cross store also needs to load all taxes

Since with crosstore the tax from is where the product is located

---
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136237)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c605cc3723c6cd29fc78945b6f2693d84af4c1ed
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:14:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c605cc3723c6cd29fc78945b6f2693d84af4c1ed [^]

Related to ISSUE-48762: Review: move condition to a function

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136238)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 490a7ca0d8b97d993cc610bac6f80ce8181d1d85
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:14:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/490a7ca0d8b97d993cc610bac6f80ce8181d1d85 [^]

Related to ISSUE-48762: Review: Fix copyrigth year, name of preference, parameter name

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136239)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 7aa9306be75c07fdaff9e51681a057d72272a4f9
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 30-03-2022 17:48:49
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/7aa9306be75c07fdaff9e51681a057d72272a4f9 [^]

Related to ISSUE-48762: active OBPOS_organizationWithMultipleLocations pref in OrgLocations test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136240)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 2bef7becf08688c2432eb1b9eebf353ed004e672
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 13:25:58
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/2bef7becf08688c2432eb1b9eebf353ed004e672 [^]

Related to ISSUE-48762: try another workaround for test OrgLocations

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136241)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: e22b47bcc7e62e69769c5aa285625dced591d6f5
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:03:40
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/e22b47bcc7e62e69769c5aa285625dced591d6f5 [^]

Related to ISSUE-48762: fix copyrigth year

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136242)
hgbot   
2022-04-01 10:14   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/176 [^]
(0136243)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: c3c93999b45e34ff0501df8583b597b53980f30c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 30-03-2022 18:14:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/c3c93999b45e34ff0501df8583b597b53980f30c [^]

Related to ISSUE-48762: take into account the preference when loading org locations

---
M src/org/openbravo/retail/sessions/OrganizationLocation.java
---
(0136244)
hgbot   
2022-04-01 10:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 8aafdf3ebc29171283dae5f1d6c4bbb48eeda201
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 31-03-2022 19:12:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/8aafdf3ebc29171283dae5f1d6c4bbb48eeda201 [^]

Related to ISSUE-48762: Review: Fix copyrigth year, name of preference

---
M src/org/openbravo/retail/sessions/OrganizationLocation.java
---
(0136245)
hgbot   
2022-04-01 10:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/39 [^]
(0136287)
hgbot   
2022-04-03 23:54   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 0ae3599e8b31c780ea94b8f8f168096ac1c31907
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 03-04-2022 23:54:36
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/0ae3599e8b31c780ea94b8f8f168096ac1c31907 [^]

Related to ISSUE-48762: Fix test orgLocations: update preference name

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---