Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004865Openbravo ERP07. Sales managementpublic2008-09-09 09:232008-11-25 23:11
Reporterrafaroda 
Assigned Torafaroda 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 7.10
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004865: 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER
DescriptionIn some files, AD_COLUMN_IDENTIFIER is used, for instance, as:
AD_COLUMN_IDENTIFIER(TO_CHAR('M_Product'), TO_CHAR(T.M_PRODUCT_ID), TO_CHAR('es_ES')) in order to get the name of a product in Spanish, if this product has a translation to Spanish.

But, in the following files, TO_CHAR('es_ES') or 'es_ES' is hardcoded instead of using TO_CHAR('vars.getLanguage()') or 'vars.getLanguage()':
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql [^]
* https://dev.openbravo.com/websvn/openbravo/trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql [^]
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0004864 closed rafaroda AD_COLUMN_IDENTIFIER does not work correctly for 'M_Product' table 
depends on backport 0004867 closed rafaroda 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER 
Attached Filesdiff ReportSalesDimensionalAnalyzeJR-bug-4865.diff (1,354) 2008-09-09 09:36
https://issues.openbravo.com/file_download.php?file_id=248&type=bug
Issue History
Date ModifiedUsernameFieldChange
2008-09-09 09:23rafarodaNew Issue
2008-09-09 09:23rafarodaAssigned To => cromero
2008-09-09 09:23rafarodasf_bug_id0 => 2101548
2008-09-09 09:23rafarodaRegression testing => No
2008-09-09 09:23rafarodaRelationship addeddepends on 0004864
2008-09-09 09:36rafarodaFile Added: ReportSalesDimensionalAnalyzeJR-bug-4865.diff
2008-09-09 09:36rafarodaNote Added: 0008927
2008-09-09 09:37rafarodaAssigned Tocromero => rafaroda
2008-09-09 10:14rafarodaSummaryto_char('es_ES') hardcoded in AD_COLUMN_IDENTIFIER => 'es_ES' hardcoded in AD_COLUMN_IDENTIFIER
2008-09-09 10:14rafarodaDescription Updated
2008-09-09 10:19rafarodaSeveritymajor => minor
2008-09-09 10:20rafarodaStatusnew => scheduled
2008-09-09 10:20rafarodafix_in_branch => trunk
2008-09-11 11:16rafarodaNote Added: 0008989
2008-09-11 16:19svnbotCheckin
2008-09-11 16:19svnbotNote Added: 0009002
2008-09-11 16:19svnbotStatusscheduled => resolved
2008-09-11 16:19svnbotResolutionopen => fixed
2008-09-11 16:19svnbotsvn_revision => 7207
2008-11-25 23:11psarobeStatusresolved => closed

Notes
(0008927)
rafaroda   
2008-09-09 09:36   
Patch added for ReportSalesDimensionalAnalyzeJR.java.
(0008989)
rafaroda   
2008-09-11 11:16   
In order to test it:
1) Create a product translation for Spanish, for instance, Hammer -> Martillo ('Master Data Management || Product || Product >> Translation')
2) Then log in in Spanish (no need to install the translation) and run:
2.1) Valued Stock Report in 'Warehouse Management || Analysis Tools || Valued Stock Report'
2.2) Sales Dimensional Report (selecting Product dimension) in 'Sales Management || Analysis Tools || Sales Dimensional Report'

In both cases Hammer should appear translated as Martillo.
(0009002)
svnbot   
2008-09-11 16:19   
Repository: openbravo
Revision: 7207
Author: rafaroda
Date: 2008-09-11 16:18:42 +0200 (Thu, 11 Sep 2008)

Fixes bug 0004865 Replaced 'es_ES' by 'vars.getLanguage()' in AD_COLUMN_IDENTIFIER() functions.

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Shipment_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
U trunk/src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations.java
U trunk/src/org/openbravo/erpCommon/ad_process/CashBankOperations_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderDimensionalPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=7207&sc=1 [^]