Openbravo Issue Tracking System - POS2 | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0048645 | POS2 | POS | public | 2022-02-21 14:19 | 2023-07-26 13:51 |
| Reporter | AugustoMauch | ||||
| Assigned To | Retail | ||||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0048645: The LastOrderComplete property should be removed from the application state | ||||
| Description | The size of the application state has a big impact on the performance, as bigger states results in its persistence taking longer, and also on more frequent garbage collection runs. We are currently storing in the LastOrderComplete property of the state the full object that represents the last completed order. This means that any time that any property of the state is updated, that order will be loaded into memory and then persisted again, unmodified. We should remove that property of the state. If it cannot be removed (i.e. because some component listens to changes done in some part of it), we could leave that part in the state and remove the rest, that would be loaded only when necessary (i.e. on an action preparation or a useEffect hook) | ||||
| Steps To Reproduce | In the terminal where this problem was reproducible, the average duration of the addProduct task went down from ~400ms to ~230ms after cleaning up the state. This included not only the LastOrderComplete property but others too. | ||||
| Proposed Solution | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2022-02-21 14:19 | AugustoMauch | New Issue | |||
| 2022-02-21 14:19 | AugustoMauch | Assigned To | => Retail | ||
| 2022-02-21 14:19 | AugustoMauch | Triggers an Emergency Pack | => No | ||
| 2022-02-21 14:19 | AugustoMauch | Issue generated from | 0048643 | ||
| 2022-02-21 14:23 | AugustoMauch | Issue cloned | 0048646 | ||
| There are no notes attached to this issue. |