Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048627ModulesExternal Integration Infrastructurepublic2022-02-18 08:352022-05-17 13:13
Reportercaristu 
Assigned Tonjimenez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocaristu
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0048627: Use core JSONMatchers in the test infrastructure
DescriptionThe following module: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests [^] contains the testing infrastructure of the connectors (org.openbravo.service.external.integration) module. It currently uses a custom JSON comparator for asserting the results. This should be replaced with the core JSONMatchers that are now available.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0048373 closed caristu Openbravo ERP Provide test matchers for asserting JSON objects 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-02-18 08:35caristuNew Issue
2022-02-18 08:35caristuAssigned To => Triage Platform Conn
2022-02-18 08:35caristuOBNetwork customer => No
2022-02-18 08:36caristuStatusnew => acknowledged
2022-02-18 08:36caristuRelationship addedrelated to 0048373
2022-03-29 16:46hgbotMerge Request Status => open
2022-03-29 16:46hgbotNote Added: 0136133
2022-05-17 13:05hgbotMerge Request Statusopen => approved
2022-05-17 13:11hgbotNote Added: 0137376
2022-05-17 13:11hgbotNote Added: 0137377
2022-05-17 13:13caristuStatusacknowledged => scheduled
2022-05-17 13:13caristuAssigned ToTriage Platform Conn => njimenez
2022-05-17 13:13caristuStatusscheduled => resolved
2022-05-17 13:13caristuResolutionopen => fixed
2022-05-17 13:13caristuReview Assigned To => caristu
2022-05-17 13:13caristuStatusresolved => closed

Notes
(0136133)
hgbot   
2022-03-29 16:46   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/7 [^]
(0137376)
hgbot   
2022-05-17 13:11   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests [^]
Changeset: edebc060b246c156b52d5968633c68087f7e52d2
Author: Natalia Jiménez <natalia.jimenez@openbravo.com>
Date: 17-05-2022 13:10:46
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/commit/edebc060b246c156b52d5968633c68087f7e52d2 [^]

Fix ISSUE-48627: Use JSONMatchers instead of custom implementation

---
M src-test/org/openbravo/service/external/integration/test/datasource/JavaPropertyMappingHandlerDSTest.java
M src-test/org/openbravo/service/external/integration/test/datasource/QueryExporterDSTest.java
M src-test/org/openbravo/service/external/integration/test/export/CountryExportTest.java
M src-test/org/openbravo/service/external/integration/test/util/SynchronizableBusinessObjectToJsonConverterTest.java
M src-test/org/openbravo/service/external/integration/test/util/TestUtils.java
R src-test/org/openbravo/service/external/integration/test/util/JsonComparator.java
---
(0137377)
hgbot   
2022-05-17 13:11   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/7 [^]