0048619: Wrong tax assigned when you are using tax exempt ticket line and you have some taxes with same configuration

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0048619

Retail Modules

Tax Exempt

public

2022-02-17 14:28

2022-03-16 14:51

Reporter

jetxarri

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q4

Fixed in Version

RR22Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0048619: Wrong tax assigned when you are using tax exempt ticket line and you have some taxes with same configuration

Description

Wrong tax assigned when you are using tax exempt ticket line (or BP) and you have some taxes with same configuration.

Steps To Reproduce

Scenario:
-2 taxes defined exactly equal and the only difference is the business partner tax category and valid from date
-inside web POS, select a bp with tax exempt
-Add a product with tax category of the defined tax rates

Verify that the applied tax is the one with more recent valifFromDate. So change not applied tax with a newer validFromDate and do the same steps. Now the other tax is applied

Proposed Solution

In the following function

const checkTaxCategory = rule => {
      const isTaxExempt =
        line.taxExempt || ticket.businessPartner.taxExempt ;
      return (
        (isTaxExempt
          ? equals(rule.taxExempt, isTaxExempt)
          : equals(
              rule.businessPartnerTaxCategory,
              ticket.businessPartner.taxCategory
            )) && equals(rule.taxCategory, line.product.taxCategory)
      );
    };

When we check if "isTaxExempt" to get the rule (tax rate) we are only taking into account the checkbox "taxExempt" when we should check "taxExempt" check + the business partner tax category.

return (
        (isTaxExempt
          ? equals(rule.taxExempt, isTaxExempt) && equals(
              rule.businessPartnerTaxCategory,
              ticket.businessPartner.taxCategory
            )
          : equals(
              rule.businessPartnerTaxCategory,
              ticket.businessPartner.taxCategory
            )) && equals(rule.taxCategory, line.product.taxCategory)
      );

Additional Information