Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048604Retail ModulesWeb POSpublic2022-02-15 16:532023-01-04 07:49
Reporterrafaroda 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048604: Can't VERIFY RETURN a ticket in POS that contains a payment method not configured in the POS
DescriptionCan't VERIFY RETURN a ticket in POS that contains a payment method not configured in the POS

In Omnichannel scenarios:
* You accept Paypal in Internet, but not in store
* You are able to load these tickets via the external Order Loader in a terminal web POS that has this payment method
* And in the Touchpoint of the store: you will be able to recall that web ticket (that has been integrated via the Exernal Order Loader): but you can't verified return it
Steps To Reproduce
1) Create a ticket 1 in POS A for payment method A
2) in POS B, make sure you DON'T have payment method A
3) You can open Ticket 1 in POS B: but if you try to do verified return, you get an error JS, see image attached
Proposed SolutionWe should indeed be in a position to open a ticket and VERIFY RETURN it which contains payment method A in a POS that has NOT this payment method A configured at all
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0054006 closed SABARINATH P Verified Return with payments of different currency -This receipt is not fully paid 
related to defect 0051546 closed ranjith_qualiantech_com Can't VERIFY RETURN a ticket in POS that contains a payment method not configured in the POS + payment method defined in POS 
Attached Filespng image_2022_12_05T12_14_00_798Z.png (42,392) 2022-12-05 13:22
https://issues.openbravo.com/file_download.php?file_id=17910&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-02-15 16:53rafarodaNew Issue
2022-02-15 16:53rafarodaAssigned To => marvintm
2022-02-15 16:53rafarodaTriggers an Emergency Pack => No
2022-02-21 11:52psanjuanNote Added: 0135173
2022-11-03 09:13rafarodaDescription Updatedbug_revision_view_page.php?rev_id=25038#r25038
2022-11-03 09:13rafarodaProposed Solution updated
2022-11-03 09:17rafarodaSummaryWeb POS Disable Payment Method: displayed in POS, but not usable/clickable => Web POS Disable Payment Method: displayed in POS, but not usable/clickable or hidden
2022-11-03 09:17rafarodaDescription Updatedbug_revision_view_page.php?rev_id=25039#r25039
2022-12-02 12:44eduardo_ArgalTypefeature request => defect
2022-12-05 11:46rafarodaNote Added: 0144408
2022-12-05 11:46rafarodaSummaryWeb POS Disable Payment Method: displayed in POS, but not usable/clickable or hidden => Can't open a ticket in POS that contains a payment method not configured in the POS
2022-12-05 11:46rafarodaProposed Solution updated
2022-12-05 11:48rafarodaDescription Updatedbug_revision_view_page.php?rev_id=25202#r25202
2022-12-05 11:48rafarodaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25204#r25204
2022-12-05 13:21rafarodaAssigned Tomarvintm => ranjith_qualiantech_com
2022-12-05 13:21rafarodaSummaryCan't open a ticket in POS that contains a payment method not configured in the POS => Can't VERIFY RETURN a ticket in POS that contains a payment method not configured in the POS
2022-12-05 13:21rafarodaDescription Updatedbug_revision_view_page.php?rev_id=25207#r25207
2022-12-05 13:21rafarodaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25208#r25208
2022-12-05 13:21rafarodaProposed Solution updated
2022-12-05 13:22rafarodaNote Edited: 0144408bug_revision_view_page.php?bugnote_id=0144408#r25210
2022-12-05 13:22rafarodaFile Added: image_2022_12_05T12_14_00_798Z.png
2022-12-05 13:35ranjith_qualiantech_comStatusnew => scheduled
2022-12-06 14:01hgbotNote Added: 0144459
2022-12-06 14:01hgbotNote Added: 0144460
2022-12-06 14:01hgbotNote Added: 0144461
2022-12-19 08:42hgbotResolutionopen => fixed
2022-12-19 08:42hgbotStatusscheduled => closed
2022-12-19 08:42hgbotNote Added: 0144801
2022-12-19 08:42hgbotFixed in Version => RR23Q1
2022-12-19 08:42hgbotNote Added: 0144802
2022-12-19 08:42hgbotNote Added: 0144803
2022-12-19 08:42hgbotNote Added: 0144804
2022-12-19 08:43hgbotNote Added: 0144805
2022-12-19 08:43hgbotNote Added: 0144806
2022-12-21 13:33ranjith_qualiantech_comNote Added: 0144900
2022-12-21 13:33ranjith_qualiantech_comStatusclosed => new
2022-12-21 13:33ranjith_qualiantech_comResolutionfixed => open
2022-12-21 13:33ranjith_qualiantech_comFixed in VersionRR23Q1 =>
2022-12-21 13:33ranjith_qualiantech_comStatusnew => scheduled
2022-12-21 13:33ranjith_qualiantech_comNote Edited: 0144900bug_revision_view_page.php?bugnote_id=0144900#r25288
2022-12-21 13:36ranjith_qualiantech_comNote Edited: 0144900bug_revision_view_page.php?bugnote_id=0144900#r25289
2022-12-22 13:38hgbotNote Added: 0144929
2022-12-22 13:39hgbotNote Added: 0144930
2023-01-04 07:48hgbotResolutionopen => fixed
2023-01-04 07:48hgbotStatusscheduled => closed
2023-01-04 07:48hgbotFixed in Version => RR23Q1
2023-01-04 07:48hgbotNote Added: 0145145
2023-01-04 07:48hgbotNote Added: 0145146
2023-01-04 07:49hgbotNote Added: 0145147
2023-01-04 07:49hgbotNote Added: 0145148
2023-02-09 10:23rafarodaRelationship addedrelated to 0051546
2023-12-15 11:00marvintmRelationship addedhas duplicate 0054006

Notes
(0135173)
psanjuan   
2022-02-21 11:52   
As discussed with SF team, we might have a better solution depending of the funcional need for this :

- Antonio is telling us that some fixe were done in more advance versions to handle order integration within the POS with PM that are not supported / configured by the POS
- I didn't know the original need for PN to be there bu disabled so I 'd like @Rafa Roda (or @Raphael Wicher ? ) to explain it so we can see if this is a good solution ( and a better one IMO )

thank you.
(0144408)
rafaroda   
2022-12-05 11:46   
(edited on: 2022-12-05 13:22)
So instead of a feature request, this is considered as a bug: with no configuration extra we should indeed be in a position to open and verify return a ticket which contains payment method A in a POS that has NOT this payment method A configured at all
(0144459)
hgbot   
2022-12-06 14:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1010 [^]
(0144460)
hgbot   
2022-12-06 14:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/47 [^]
(0144461)
hgbot   
2022-12-06 14:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1405 [^]
(0144801)
hgbot   
2022-12-19 08:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1010 [^]
(0144802)
hgbot   
2022-12-19 08:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 30668dab0f129577a84c35ec06cd1ab10b07c8e6
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 19-12-2022 07:22:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/30668dab0f129577a84c35ec06cd1ab10b07c8e6 [^]

Fixed ISSUE-48604: Updated validation when loading accepted refund payments
* If payment is not present in POS, then it should not be added in
  refund payments

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
---
(0144803)
hgbot   
2022-12-19 08:42   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: b9752abc6c5168888f105932d85cfbadc7e339ad
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 19-12-2022 07:22:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/b9752abc6c5168888f105932d85cfbadc7e339ad [^]

Related to ISSUE-48604: Foreign amount should be calculated when doing verified return
* When doing verified return, Foreign amount should be calculated
  even if payment is not present in POS

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0144804)
hgbot   
2022-12-19 08:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/47 [^]
(0144805)
hgbot   
2022-12-19 08:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f77fff86143beb13cf5f05c81c11828ba1d84325
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 19-12-2022 07:42:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f77fff86143beb13cf5f05c81c11828ba1d84325 [^]

Related to ISSUE-48604: Reverse payment should be hidden if payment is not exists
* When opening paid receipt, Reverse payment should be hidden
  if payment is not exists in POS

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentAction.jsx
---
(0144806)
hgbot   
2022-12-19 08:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1405 [^]
(0144900)
ranjith_qualiantech_com   
2022-12-21 13:33   
(edited on: 2022-12-21 13:36)
Steps to reproduce in livebuilds pos2 modules
Backoffice
1) Organization - "Vallblanca Store"
   Update "Allow Mixing verified return with" = "Nothing"
2) Channel Touchpoint Type - "POS2SD VBS POS2 Terminal Type"
   Payment Method - Credit Card
     Update "Allowed PMs for Refund" - "Only those defined"
     PM For Refund tab
     Add "Cash" & "USA Cash"

   Payment Method - USA Cash
     Update "Allowed PMs for Refund" - "Only those defined"
     PM For Refund tab
     Add "Cash"

POS
Click "Refresh Masterdata"
1) Add product, Complete the ticket with "Card" payment
2) Reopen last completed order and Create "Verified Returns"
3) Click "Refund" button - Payment tab will be shown
   "Cash" & "USA Cash" will be listed for Refund. (Other payments can't selected)
    https://drive.google.com/file/d/1DFFXU2VNfRmmvqiqiqVS0WkOcunfVxC0/view?usp=share_link [^]
4) Complete the "Verified Returns" by refunding through "Cash" or "USA Cash"
5) Repeat Step 1 for next Case - T1
6) Repeat Step 1 for next Case - T2

Backoffice
1) Create preference
   Property: "Web POS payment Card". Check: "Selected". Value: "N"


POS
Click "Refresh Masterdata"
1) Open ticket - T1 and Create "Verified Returns"
2) Click "Refund" button
   JS Error occurs
(0144929)
hgbot   
2022-12-22 13:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1020 [^]
(0144930)
hgbot   
2022-12-22 13:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1427 [^]
(0145145)
hgbot   
2023-01-04 07:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6c9ff43f5aeffc2921e7fe8ae10931e5f294d71f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 29-12-2022 09:37:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6c9ff43f5aeffc2921e7fe8ae10931e5f294d71f [^]

Fixed ISSUE-48604: Refund Payment should not be generated for inactive payments

---
M web-test/model/business-object/ticket/TicketUtils.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
---
(0145146)
hgbot   
2023-01-04 07:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1020 [^]
(0145147)
hgbot   
2023-01-04 07:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5a8a2619406d1f4c24cddcd2a3b284c05200cb63
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-01-2023 06:49:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5a8a2619406d1f4c24cddcd2a3b284c05200cb63 [^]

Related to ISSUE-48604: Active Payment should be used to calculate refund payments

---
M web-jspack/org.openbravo.pos2/src/components/Payments/AuxiliaryPaymentsGrid/RefundLimitsGrid.jsx
---
(0145148)
hgbot   
2023-01-04 07:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1427 [^]