Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048565POS2POSpublic2022-02-10 08:182022-07-15 13:50
Reporterjorge-garcia 
Assigned Tosntgreale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048565: JIRA 2688: Store address is not loaded properly in POS2 if address is only set in 1st line or region is not set
DescriptionStore address is not loaded properly in POS application if address is only set in 1st line location selector
Steps To Reproduce1) Login in ERP as Openbravo
2) Switch to The White Valley Group role
3) Go to Organization window
4) Select Vall Blanca Store record and navigate to Information tab
5) Press on Location/Address field and put Pau Claris 138 1-1 into the 1st line field and delete value inside 2nd line field
6) Save the record

7) Login in VBS-1 terminal (POS2) with vallblanca user
8) Wait until the login and load masterdata are complete
9) Click in the terminal info at the top right of the application next to logo
10) Verify first line (address) is not rendered(see attached file)
Proposed SolutionTerminal information is getting from an existing ModelExtension from posterminal module.

In CrossStoreInfoProperties.java there is part of the code to take the address:
    final String addressHQL = ""
    + "CONCAT("
    + " COALESCE(l.addressLine1, ''), "
    + " CASE WHEN l.addressLine2 IS NOT NULL THEN "
    + " CONCAT(' - ',l.addressLine2,',') "
    + " END, "
    + " ' ', "
    + " COALESCE(l.postalCode, ''), "
    + " ' ', "
    + " COALESCE(l.cityName, ''), "
    + " CASE WHEN r.name IS NOT NULL THEN "
    + " CONCAT(' (',trim(r.name),'),') "
    + " END, "
    + " ' ', "
    + " COALESCE(c.name, '')"
    + ")";
    //@formatter:on
    list.add(new HQLProperty(addressHQL, "address"));

The sql executed here does not work if address is set only in 1st line field from locator selector
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng noAddress.png (22,455) 2022-02-10 08:18
https://issues.openbravo.com/file_download.php?file_id=16605&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-02-10 08:18jorge-garciaNew Issue
2022-02-10 08:18jorge-garciaAssigned To => Retail
2022-02-10 08:18jorge-garciaFile Added: noAddress.png
2022-02-10 08:18jorge-garciaOBNetwork customer => No
2022-02-10 08:18jorge-garciaTriggers an Emergency Pack => No
2022-02-10 09:13mmohammadNote Added: 0134859
2022-02-10 09:33guilleaerOBNetwork customerNo => Gold
2022-02-10 09:33guilleaerSummaryStore address is not loaded properly in POS application if address is only set in 1st line location selector => JIRA 2688: Store address is not loaded properly in POS application if address is only set in 1st line location selector
2022-02-10 09:34guilleaerSummaryJIRA 2688: Store address is not loaded properly in POS application if address is only set in 1st line location selector => JIRA 2688: Store address is not loaded properly in POS2 if address is only set in 1st line or region is not set
2022-02-14 13:31sntgrealeAssigned ToRetail => sntgreale
2022-02-14 13:31sntgrealeStatusnew => scheduled
2022-02-15 20:24hgbotMerge Request Status => open
2022-02-15 20:24hgbotNote Added: 0135027
2022-02-15 22:57hgbotMerge Request Statusopen => approved
2022-02-15 22:57hgbotResolutionopen => fixed
2022-02-15 22:57hgbotStatusscheduled => closed
2022-02-15 22:57hgbotFixed in Version => RR22Q2
2022-02-15 22:57hgbotNote Added: 0135028
2022-02-15 22:57hgbotNote Added: 0135029
2022-07-13 06:56hgbotNote Added: 0139289
2022-07-15 13:50hgbotNote Added: 0139351
2022-07-15 13:50hgbotNote Added: 0139352

Notes
(0134859)
mmohammad   
2022-02-10 09:13   
related to jira 2688 : https://openbravo.atlassian.net/browse/FLUN-2688 [^]
(0135027)
hgbot   
2022-02-15 20:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/719 [^]
(0135028)
hgbot   
2022-02-15 22:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9638d958ebbf4e50040d56ebfbf81287cc1b6b96
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 15-02-2022 21:57:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9638d958ebbf4e50040d56ebfbf81287cc1b6b96 [^]

Fixes ISSUE-48565: HQL query to load address as a string updated.

---
M src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java
---
(0135029)
hgbot   
2022-02-15 22:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/719 [^]
(0139289)
hgbot   
2022-07-13 06:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/856 [^]
(0139351)
hgbot   
2022-07-15 13:50   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 91ceb115ccc7f900e54c944cb373fb147c703810
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 15-07-2022 11:49:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/91ceb115ccc7f900e54c944cb373fb147c703810 [^]

Related to ISSUE-48565: Updated CrossStoreInfoProperties to avoid casting problem in oracle

---
M src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java
---
(0139352)
hgbot   
2022-07-15 13:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/856 [^]