Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048537POS2POSpublic2022-02-04 15:002022-02-24 15:17
Reportercberner 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048537: Server timeout popup is reset by pager status check requests, and should not
DescriptionOnly user requests should reset the timeout period after which the session timeout popup should appear. However, any request that goes through onSucceededRequest is triggering it, a filter should be applied to allow filtering which requests are server checkup and not user started actions, which should not reset the session timeout period.
Steps To Reproduce1. Login Backoffice as Vallblanca Admin group role
2. Go to Organization window and select Vallblanca Store org, then check "Terminals will check pager status" and set "Time (in minutes) to check pager server status" to 1 minute. (Screenshot provided)
3. Switch to System role and go to AD Implementation Mapping window
4. Filter and select Timeout. In parameters subtab, select timeout and set value to 5 minutes
5. Login in WebPOS and wait 3 minutes, no popup appears, and it should have appeared.

Checking network tab in developer tools, there are several successfull requests for pager, which resets the popup each minute to be launched after 3 minutes.
Proposed SolutionFilter some requests that shouldn't trigger a reset of the session timeout.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng set pager status.png (89,119) 2022-02-04 15:00
https://issues.openbravo.com/file_download.php?file_id=16582&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2022-02-04 15:00cbernerNew Issue
2022-02-04 15:00cbernerAssigned To => Retail
2022-02-04 15:00cbernerFile Added: set pager status.png
2022-02-04 15:00cbernerTriggers an Emergency Pack => No
2022-02-04 15:01cbernerStatusnew => acknowledged
2022-02-07 18:46hgbotNote Added: 0134816
2022-02-07 18:47hgbotNote Added: 0134817
2022-02-09 12:39hgbotResolutionopen => fixed
2022-02-09 12:39hgbotStatusacknowledged => closed
2022-02-09 12:39hgbotNote Added: 0134843
2022-02-09 12:39hgbotFixed in Version => RR22Q2
2022-02-09 12:39hgbotNote Added: 0134844
2022-02-09 12:39hgbotNote Added: 0134845
2022-02-09 12:39hgbotNote Added: 0134846
2022-02-21 11:46hgbotNote Added: 0135165
2022-02-24 15:17hgbotNote Added: 0135280

Notes
(0134816)
hgbot   
2022-02-07 18:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/800 [^]
(0134817)
hgbot   
2022-02-07 18:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/328 [^]
(0134843)
hgbot   
2022-02-09 12:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/328 [^]
(0134844)
hgbot   
2022-02-09 12:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 3fafe3a028773a190f54e99137c153c640ba800a
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 09-02-2022 10:03:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3fafe3a028773a190f54e99137c153c640ba800a [^]

Fixes ISSUE-48537: Server timeout popup is reset by pager status check requests

Some requests are not launched by the user but however reset the session
timeout popup, and the backoffice user session. To fix this, mobile
service requests now will allow to include extra params, one of these
may be IsAjaxCall and ignoreForSessionTimeout. If these two are present,
both frontend and backend will ignore this for session expiration time
update.

Also sets ignoreForSessionTimeout flag on requests coming from automatic
TerminalLogLoader messages.

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/TerminalLogGenerateMessage.js
M web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js
M web/org.openbravo.mobile.core/app/util/network/Request.js
---
(0134845)
hgbot   
2022-02-09 12:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4999c6f77ca53af252b7a0b8ef4e86cc88924512
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 08-02-2022 15:29:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4999c6f77ca53af252b7a0b8ef4e86cc88924512 [^]

Related to ISSUE-48537: Set ignoreForSessionTimeout on requests for pager status check

Previously requests from pager were treated as normal requests from the
user, meaning these would reset the session timeout. That's no longer
the case, this requests will not reset the session timeout.

It also sets ignoreForSessionTimeout flag on requests from
checkAuthentication.

---
M web-jspack/org.openbravo.pos2/src/authentication/checkTerminalAuth.js
M web-jspack/org.openbravo.pos2/src/services/pager/PagerStatusStoreCheck.js
---
(0134846)
hgbot   
2022-02-09 12:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/800 [^]
(0135165)
hgbot   
2022-02-21 11:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 5f2149482cdf25cce3681a7935ae8ae7fcc94c2f
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 21-02-2022 11:46:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/5f2149482cdf25cce3681a7935ae8ae7fcc94c2f [^]

Fixes ISSUE-48537: Server timeout popup is reset by pager status check requests

Some requests are not launched by the user but however reset the session
timeout popup, and the backoffice user session. To fix this, mobile
service requests now will allow to include extra params, one of these
may be IsAjaxCall and ignoreForSessionTimeout. If these two are present,
both frontend and backend will ignore this for session expiration time
update.

Also sets ignoreForSessionTimeout flag on requests coming from automatic
TerminalLogLoader messages.

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/TerminalLogGenerateMessage.js
M web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js
M web/org.openbravo.mobile.core/app/util/network/Request.js
---
(0135280)
hgbot   
2022-02-24 15:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d303f61dc55015bcb80fc24c6959f83e4ab97b72
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 07-02-2022 18:43:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d303f61dc55015bcb80fc24c6959f83e4ab97b72 [^]

Fixes ISSUE-48537: Server timeout popup is reset by pager status check requests

Some requests are not launched by the user but however reset the session
timeout popup, and the backoffice user session. To fix this, mobile
service requests now will allow to include extra params, one of these
may be IsAjaxCall and ignoreForSessionTimeout. If these two are present,
both frontend and backend will ignore this for session expiration time
update.

Also sets ignoreForSessionTimeout flag on requests coming from automatic
TerminalLogLoader messages.

---
---