Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048528POS2Corepublic2022-02-03 14:572022-03-10 15:24
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048528: Offline Approval Improvements
DescriptionCurrently in order to do an approval offline, the person doing the approval must have approved that same action previously online.

This project aims to support offline approvals even when the person doing the approval has not done any previous approval in that terminal.

Functional Specification: https://docs.google.com/document/d/1vGPeqz7yrj9x731j3LHP4mO6GdyzTrDDaHEX_gA4iw8/edit#heading=h.iryidvnuj18m [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 005522324Q2 closed cberner duplicated data fetched as part of offline user masterdata models 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-02-03 14:57AugustoMauchNew Issue
2022-02-03 14:57AugustoMauchAssigned To => AugustoMauch
2022-02-03 14:57AugustoMauchTriggers an Emergency Pack => No
2022-02-04 11:27hgbotNote Added: 0134783
2022-02-04 11:27AugustoMauchStatusnew => scheduled
2022-03-10 14:32hgbotNote Added: 0135623
2022-03-10 14:32hgbotResolutionopen => fixed
2022-03-10 14:32hgbotStatusscheduled => closed
2022-03-10 14:32hgbotNote Added: 0135624
2022-03-10 15:24hgbotNote Added: 0135625
2024-04-17 14:38alostaleRelationship addedcauses 0055223

Notes
(0134783)
hgbot   
2022-02-04 11:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/696 [^]
(0135623)
hgbot   
2022-03-10 14:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/696 [^]
(0135624)
hgbot   
2022-03-10 14:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 24f78145bcbd3c718259e1d126a0c93f86516ec4
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 14:31:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/24f78145bcbd3c718259e1d126a0c93f86516ec4 [^]

Fixes ISSUE-48528: Merge branch 'fr/48528-offline-approval-improvements'

---
A src/org/openbravo/core2/master/OfflineUser.java
A src/org/openbravo/core2/master/OfflineUserRole.java
A src/org/openbravo/core2/master/UserActionAccess.java
A web-jspack/org.openbravo.core2/src/core/security/OfflineApprovals.js
A web-jspack/org.openbravo.core2/src/core/security/__mock__/offlineUserMockData.js
A web-jspack/org.openbravo.core2/src/core/security/__mock__/offlineUserRoleMockData.js
A web-jspack/org.openbravo.core2/src/core/security/__mock__/userActionAccessMockData.js
A web-jspack/org.openbravo.core2/src/core/security/__test__/OfflineApprovals.test.js
A web-jspack/org.openbravo.core2/src/model/masterdata/OfflineUser.js
A web-jspack/org.openbravo.core2/src/model/masterdata/OfflineUserRole.js
A web-jspack/org.openbravo.core2/src/model/masterdata/UserActionAccess.js
M web-jspack/org.openbravo.core2/src/core/security/ApprovalChecker.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0135625)
hgbot   
2022-03-10 15:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 55914a88b04fc7ee07f5db8ec969bbc42571a3ac
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 15:24:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/55914a88b04fc7ee07f5db8ec969bbc42571a3ac [^]

Related to ISSUE-48528: Removes dependency to posterminal object

There is no need to check if the roles have access to the POS application because we are already
checking that it has approvable user actions.

---
M src/org/openbravo/core2/master/OfflineUser.java
M src/org/openbravo/core2/master/OfflineUserRole.java
M src/org/openbravo/core2/master/UserActionAccess.java
---