Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048471Retail ModulesDiscounts and Promotionspublic2022-01-24 11:162022-02-17 11:28
a_singh 
rqueralta 
normalminoralways
closedfixed 
5
 
RR22Q2 
No
0048471: Manual promotion displays discount percentage (%) with an extra space
Manual promotion in the pos displays the name as Employee Discount - 40% - 40 % which is expected as Employee Discount - 40% - 40%.
We have successfully reproduced the same on the livebuilds with the following steps:
1. Log in to VBS-1 with Vallblanca user
2. Log in the backoffice and enable the discount Employee Discount - 40% to be used in the pos.
3. Go to the pos and Refresh Data from the menu option to load the enabled discount Employee Discount - 40%.
4. Add a product and select the added line
5. Then click on the discount button which enables manual promotions dropdown list which shows the required discount as Employee Discount - 40% - 40 % instead of Employee Discount - 40% - 40%
We have removed the extra space in the attached proposed solution
No tags attached.
diff ticket34388_patch.diff (511) 2022-01-24 11:16
https://issues.openbravo.com/file_download.php?file_id=16537&type=bug
Issue History
2022-01-24 11:16a_singhNew Issue
2022-01-24 11:16a_singhAssigned To => Retail
2022-01-24 11:16a_singhFile Added: ticket34388_patch.diff
2022-01-24 11:16a_singhTriggers an Emergency Pack => No
2022-01-27 21:09rqueraltaAssigned ToRetail => rqueralta
2022-01-27 21:09rqueraltaStatusnew => scheduled
2022-01-28 18:19hgbotNote Added: 0134666
2022-01-28 18:21hgbotNote Added: 0134667
2022-02-14 20:00hgbotNote Added: 0134975
2022-02-15 15:58hgbotNote Added: 0135002
2022-02-15 15:59hgbotNote Added: 0135003
2022-02-15 16:04hgbotNote Added: 0135004
2022-02-15 16:05hgbotNote Added: 0135005
2022-02-16 14:35hgbotNote Added: 0135050
2022-02-16 20:19hgbotNote Added: 0135061
2022-02-17 11:28hgbotResolutionopen => fixed
2022-02-17 11:28hgbotStatusscheduled => closed
2022-02-17 11:28hgbotFixed in Version => RR22Q2
2022-02-17 11:28hgbotNote Added: 0135075
2022-02-17 11:28hgbotNote Added: 0135076
2022-02-17 11:28hgbotNote Added: 0135077
2022-02-17 11:28hgbotNote Added: 0135078
2022-02-17 11:28hgbotNote Added: 0135079
2022-02-17 11:28hgbotNote Added: 0135080

Notes
(0134666)
hgbot   
2022-01-28 18:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/49 [^]
(0134667)
hgbot   
2022-01-28 18:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category/-/merge_requests/3 [^]
(0134975)
hgbot   
2022-02-14 20:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/716 [^]
(0135002)
hgbot   
2022-02-15 15:58   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category/-/merge_requests/3 [^]
(0135003)
hgbot   
2022-02-15 15:59   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/49 [^]
(0135004)
hgbot   
2022-02-15 16:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/50 [^]
(0135005)
hgbot   
2022-02-15 16:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category/-/merge_requests/4 [^]
(0135050)
hgbot   
2022-02-16 14:35   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/716 [^]
(0135061)
hgbot   
2022-02-16 20:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/721 [^]
(0135075)
hgbot   
2022-02-17 11:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: af9fcae2ba1202bf7f48a9b0d2930b345dc57834
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 16-02-2022 09:22:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/af9fcae2ba1202bf7f48a9b0d2930b345dc57834 [^]

Fixed BUG-48471: Removed extra space in discount name

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0135076)
hgbot   
2022-02-17 11:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/721 [^]
(0135077)
hgbot   
2022-02-17 11:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category [^]
Changeset: 16dc2ab6b9733c698a15153e3fc81456d76f8e34
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 15-02-2022 10:01:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category/-/commit/16dc2ab6b9733c698a15153e3fc81456d76f8e34 [^]

Fixed BUG-48471: Removed extra space in discount name

---
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---
(0135078)
hgbot   
2022-02-17 11:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.category/-/merge_requests/4 [^]
(0135079)
hgbot   
2022-02-17 11:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/50 [^]
(0135080)
hgbot   
2022-02-17 11:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: cdf8b7f3354990a1b431bdebaafc2e173178d016
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 15-02-2022 10:00:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/cdf8b7f3354990a1b431bdebaafc2e173178d016 [^]

Fixed BUG-48471: Removed extra space in discount name and updated some test

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountUserDefinedPercentageTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I30176_UndefinedDiscountWhenReturning.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I33201_VerifyPackCombinedWithManualPromotions.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I34372_VerifyDiscountInDeletedReceipt.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I37220_VerifyDiscountOnVerifiedReturns.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/I39495_VerifyDiscountOnNegativeLine.java
M src-test/org/openbravo/retail/discounts/test/unittests/combined/SplitDiscountsForNonGroupedProducts.java
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---